Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2019-01-12 Thread Michael Niewöhner
Hi again, On Sat, 2019-01-12 at 10:52 +0100, Michael Niewöhner wrote: > Hi Mimi, > > On Fri, 2019-01-11 at 10:40 -0500, Mimi Zohar wrote: > > Hi Michael, > > > > On Sun, 2018-11-11 at 19:50 +0100, Michael Niewöhner wrote: > > > > > Well, there are at least two implementations I know of: > > >

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2019-01-12 Thread Michael Niewöhner
Hi Mimi, On Fri, 2019-01-11 at 10:40 -0500, Mimi Zohar wrote: > Hi Michael, > > On Sun, 2018-11-11 at 19:50 +0100, Michael Niewöhner wrote: > > > Well, there are at least two implementations I know of: > > For my Lenovo X260 I can choose between Infineon TPM 1.2 or Intel PTT TPM > > 2.0 > >

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2019-01-11 Thread Mimi Zohar
Hi Michael, On Sun, 2018-11-11 at 19:50 +0100, Michael Niewöhner wrote: > Well, there are at least two implementations I know of: > For my Lenovo X260 I can choose between Infineon TPM 1.2 or Intel PTT TPM 2.0 > This here is my ThinkStation P320 which can choose between PTT 1.2, PTT 2.0, >

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-26 Thread Jarkko Sakkinen
On Mon, Nov 26, 2018 at 08:15:38PM +0100, Michael Niewöhner wrote: > Hi again, > > after some experiments I finally found a solution... > There seems to be a bug in TPM2.0 firmware version (1.3.1.0) included in > Lenovos > UEFI image but they do not provide an update. > > I have extracted the

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-26 Thread Jarkko Sakkinen
On Mon, Nov 26, 2018 at 08:15:38PM +0100, Michael Niewöhner wrote: > Hi again, > > after some experiments I finally found a solution... > There seems to be a bug in TPM2.0 firmware version (1.3.1.0) included in > Lenovos > UEFI image but they do not provide an update. > > I have extracted the

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-26 Thread Michael Niewöhner
Hi again, after some experiments I finally found a solution... There seems to be a bug in TPM2.0 firmware version (1.3.1.0) included in Lenovos UEFI image but they do not provide an update. I have extracted the firmware version 1.3.2.8 from Dell's XPS15 TPM2.0 firmware update and used this to

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-26 Thread Michael Niewöhner
Hi again, after some experiments I finally found a solution... There seems to be a bug in TPM2.0 firmware version (1.3.1.0) included in Lenovos UEFI image but they do not provide an update. I have extracted the firmware version 1.3.2.8 from Dell's XPS15 TPM2.0 firmware update and used this to

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-25 Thread Michael Niewöhner
Hi, On Mon, 2018-11-19 at 15:49 +0200, Jarkko Sakkinen wrote: > On Sun, Nov 18, 2018 at 03:10:06PM +0100, Michael Niewöhner wrote: > > On Sun, 2018-11-18 at 10:18 +0200, Jarkko Sakkinen wrote: > > > On Fri, Nov 16, 2018 at 10:06:28PM +0100, Michael Niewöhner wrote: > > > > On Wed, 2018-11-14 at

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-25 Thread Michael Niewöhner
Hi, On Mon, 2018-11-19 at 15:49 +0200, Jarkko Sakkinen wrote: > On Sun, Nov 18, 2018 at 03:10:06PM +0100, Michael Niewöhner wrote: > > On Sun, 2018-11-18 at 10:18 +0200, Jarkko Sakkinen wrote: > > > On Fri, Nov 16, 2018 at 10:06:28PM +0100, Michael Niewöhner wrote: > > > > On Wed, 2018-11-14 at

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-19 Thread Jarkko Sakkinen
On Sun, Nov 18, 2018 at 03:10:06PM +0100, Michael Niewöhner wrote: > On Sun, 2018-11-18 at 10:18 +0200, Jarkko Sakkinen wrote: > > On Fri, Nov 16, 2018 at 10:06:28PM +0100, Michael Niewöhner wrote: > > > On Wed, 2018-11-14 at 21:46 +0100, Michael Niewöhner wrote: > > > > Hi all, > > > > > > > > I

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-19 Thread Jarkko Sakkinen
On Sun, Nov 18, 2018 at 03:10:06PM +0100, Michael Niewöhner wrote: > On Sun, 2018-11-18 at 10:18 +0200, Jarkko Sakkinen wrote: > > On Fri, Nov 16, 2018 at 10:06:28PM +0100, Michael Niewöhner wrote: > > > On Wed, 2018-11-14 at 21:46 +0100, Michael Niewöhner wrote: > > > > Hi all, > > > > > > > > I

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-18 Thread Michael Niewöhner
On Sun, 2018-11-18 at 10:18 +0200, Jarkko Sakkinen wrote: > On Fri, Nov 16, 2018 at 10:06:28PM +0100, Michael Niewöhner wrote: > > On Wed, 2018-11-14 at 21:46 +0100, Michael Niewöhner wrote: > > > Hi all, > > > > > > I tried that patch mentioned by Mimi but it does not change anything for > > >

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-18 Thread Michael Niewöhner
On Sun, 2018-11-18 at 10:18 +0200, Jarkko Sakkinen wrote: > On Fri, Nov 16, 2018 at 10:06:28PM +0100, Michael Niewöhner wrote: > > On Wed, 2018-11-14 at 21:46 +0100, Michael Niewöhner wrote: > > > Hi all, > > > > > > I tried that patch mentioned by Mimi but it does not change anything for > > >

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-18 Thread Jarkko Sakkinen
On Fri, Nov 16, 2018 at 10:06:28PM +0100, Michael Niewöhner wrote: > On Wed, 2018-11-14 at 21:46 +0100, Michael Niewöhner wrote: > > Hi all, > > > > I tried that patch mentioned by Mimi but it does not change anything for me. > > > > Then I did some more tests with different kernel configs and

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-18 Thread Jarkko Sakkinen
On Fri, Nov 16, 2018 at 10:06:28PM +0100, Michael Niewöhner wrote: > On Wed, 2018-11-14 at 21:46 +0100, Michael Niewöhner wrote: > > Hi all, > > > > I tried that patch mentioned by Mimi but it does not change anything for me. > > > > Then I did some more tests with different kernel configs and

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-16 Thread Michael Niewöhner
On Wed, 2018-11-14 at 21:46 +0100, Michael Niewöhner wrote: > Hi all, > > I tried that patch mentioned by Mimi but it does not change anything for me. > > Then I did some more tests with different kernel configs and finally got TPM > working by > a) compiling TPM as modules and rmmod tpm* and

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-16 Thread Michael Niewöhner
On Wed, 2018-11-14 at 21:46 +0100, Michael Niewöhner wrote: > Hi all, > > I tried that patch mentioned by Mimi but it does not change anything for me. > > Then I did some more tests with different kernel configs and finally got TPM > working by > a) compiling TPM as modules and rmmod tpm* and

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-14 Thread Michael Niewöhner
Hi all, I tried that patch mentioned by Mimi but it does not change anything for me. Then I did some more tests with different kernel configs and finally got TPM working by a) compiling TPM as modules and rmmod tpm* and re-modprobe tpm_tis. (initramfs) dmesg | grep -i tpm [0.00] efi:

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-14 Thread Michael Niewöhner
Hi all, I tried that patch mentioned by Mimi but it does not change anything for me. Then I did some more tests with different kernel configs and finally got TPM working by a) compiling TPM as modules and rmmod tpm* and re-modprobe tpm_tis. (initramfs) dmesg | grep -i tpm [0.00] efi:

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-13 Thread Jarkko Sakkinen
On Sun, Nov 11, 2018 at 10:11:33PM +0100, Michael Niewöhner wrote: > Very strange... When I pull the power cord, then replug and boot, I get these > dmesg messages: > [0.00] efi: ACPI > 2.0=0x9ea78000 ACPI=0x9ea78000 SMBIOS=0x9f5e5000 SMBIOS > 3.0=0x9f5e4000 MPS=0xfca00

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-13 Thread Jarkko Sakkinen
On Sun, Nov 11, 2018 at 10:11:33PM +0100, Michael Niewöhner wrote: > Very strange... When I pull the power cord, then replug and boot, I get these > dmesg messages: > [0.00] efi: ACPI > 2.0=0x9ea78000 ACPI=0x9ea78000 SMBIOS=0x9f5e5000 SMBIOS > 3.0=0x9f5e4000 MPS=0xfca00

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-13 Thread Jarkko Sakkinen
On Sun, Nov 11, 2018 at 06:55:36PM +0100, Michael Niewöhner wrote: > Hi all, > > Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / tpm_i2c_nuvoton > while it works in TPM 1.2 mode (I can reflash it via UEFI setup). > Kernel version is 4.19.1 Can you check what ACPI dump would show up

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-13 Thread Jarkko Sakkinen
On Sun, Nov 11, 2018 at 06:55:36PM +0100, Michael Niewöhner wrote: > Hi all, > > Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / tpm_i2c_nuvoton > while it works in TPM 1.2 mode (I can reflash it via UEFI setup). > Kernel version is 4.19.1 Can you check what ACPI dump would show up

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Mimi Zohar
> Very strange... When I pull the power cord, then replug and boot, I get these > dmesg messages: > [0.00] efi: ACPI > 2.0=0x9ea78000 ACPI=0x9ea78000 SMBIOS=0x9f5e5000 SMBIOS > 3.0=0x9f5e4000 MPS=0xfca00 ESRT=0x9c06e918 MEMATTR=0x99cb9018 > TPMEventLog=0x > 98d0c018 > [

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Mimi Zohar
> Very strange... When I pull the power cord, then replug and boot, I get these > dmesg messages: > [0.00] efi: ACPI > 2.0=0x9ea78000 ACPI=0x9ea78000 SMBIOS=0x9f5e5000 SMBIOS > 3.0=0x9f5e4000 MPS=0xfca00 ESRT=0x9c06e918 MEMATTR=0x99cb9018 > TPMEventLog=0x > 98d0c018 > [

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
On Sun, 2018-11-11 at 21:34 +0100, Michael Niewöhner wrote: > On Sun, 2018-11-11 at 12:29 -0800, James Bottomley wrote: > > On Sun, 2018-11-11 at 21:09 +0100, Michael Niewöhner wrote: > > > On Sun, 2018-11-11 at 10:57 -0800, James Bottomley wrote: > > > > [...] > > > > Well, I still think the

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
On Sun, 2018-11-11 at 21:34 +0100, Michael Niewöhner wrote: > On Sun, 2018-11-11 at 12:29 -0800, James Bottomley wrote: > > On Sun, 2018-11-11 at 21:09 +0100, Michael Niewöhner wrote: > > > On Sun, 2018-11-11 at 10:57 -0800, James Bottomley wrote: > > > > [...] > > > > Well, I still think the

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
On Sun, 2018-11-11 at 12:29 -0800, James Bottomley wrote: > On Sun, 2018-11-11 at 21:09 +0100, Michael Niewöhner wrote: > > On Sun, 2018-11-11 at 10:57 -0800, James Bottomley wrote: > > [...] > > > Well, I still think the ACPI setup is incorrect. What's in > > > /sys/class/platform (should be

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
On Sun, 2018-11-11 at 12:29 -0800, James Bottomley wrote: > On Sun, 2018-11-11 at 21:09 +0100, Michael Niewöhner wrote: > > On Sun, 2018-11-11 at 10:57 -0800, James Bottomley wrote: > > [...] > > > Well, I still think the ACPI setup is incorrect. What's in > > > /sys/class/platform (should be

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread James Bottomley
On Sun, 2018-11-11 at 21:09 +0100, Michael Niewöhner wrote: > On Sun, 2018-11-11 at 10:57 -0800, James Bottomley wrote: [...] > > Well, I still think the ACPI setup is incorrect. What's in > > /sys/class/platform (should be directories of ACPI devices)? The > > TPM is supposed to show up as

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread James Bottomley
On Sun, 2018-11-11 at 21:09 +0100, Michael Niewöhner wrote: > On Sun, 2018-11-11 at 10:57 -0800, James Bottomley wrote: [...] > > Well, I still think the ACPI setup is incorrect. What's in > > /sys/class/platform (should be directories of ACPI devices)? The > > TPM is supposed to show up as

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
On Sun, 2018-11-11 at 10:57 -0800, James Bottomley wrote: > On Sun, 2018-11-11 at 19:50 +0100, Michael Niewöhner wrote: > [...] > > > However, this makes me wonder about yours: > > > > > > > [0.003517] ACPI: TPM2 0x9E490ED8 34 (v03 LENOVO > > > > TC- > > > > S06 1300 AMI

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
On Sun, 2018-11-11 at 10:57 -0800, James Bottomley wrote: > On Sun, 2018-11-11 at 19:50 +0100, Michael Niewöhner wrote: > [...] > > > However, this makes me wonder about yours: > > > > > > > [0.003517] ACPI: TPM2 0x9E490ED8 34 (v03 LENOVO > > > > TC- > > > > S06 1300 AMI

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread James Bottomley
On Sun, 2018-11-11 at 19:50 +0100, Michael Niewöhner wrote: [...] > > However, this makes me wonder about yours: > > > > > [0.003517] ACPI: TPM2 0x9E490ED8 34 (v03 LENOVO > > > TC- > > > S06 1300 AMI ) > > > > I thought the Lenovo "upgrade to 2.0" in fact disabled

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread James Bottomley
On Sun, 2018-11-11 at 19:50 +0100, Michael Niewöhner wrote: [...] > > However, this makes me wonder about yours: > > > > > [0.003517] ACPI: TPM2 0x9E490ED8 34 (v03 LENOVO > > > TC- > > > S06 1300 AMI ) > > > > I thought the Lenovo "upgrade to 2.0" in fact disabled

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
Hi Mimi, On Sun, 2018-11-11 at 13:33 -0500, Mimi Zohar wrote: > On Sun, 2018-11-11 at 18:55 +0100, Michael Niewöhner wrote: > > Hi all, > > > > Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / tpm_i2c_nuvoton > > while it works in TPM 1.2 mode (I can reflash it via UEFI setup). > >

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
Hi Mimi, On Sun, 2018-11-11 at 13:33 -0500, Mimi Zohar wrote: > On Sun, 2018-11-11 at 18:55 +0100, Michael Niewöhner wrote: > > Hi all, > > > > Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / tpm_i2c_nuvoton > > while it works in TPM 1.2 mode (I can reflash it via UEFI setup). > >

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
Hi James, On Sun, 2018-11-11 at 10:24 -0800, James Bottomley wrote: > On Sun, 2018-11-11 at 18:55 +0100, Michael Niewöhner wrote: > > Hi all, > > > > Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / > > tpm_i2c_nuvoton while it works in TPM 1.2 mode (I can reflash it via > > UEFI

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
Hi James, On Sun, 2018-11-11 at 10:24 -0800, James Bottomley wrote: > On Sun, 2018-11-11 at 18:55 +0100, Michael Niewöhner wrote: > > Hi all, > > > > Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / > > tpm_i2c_nuvoton while it works in TPM 1.2 mode (I can reflash it via > > UEFI

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Mimi Zohar
On Sun, 2018-11-11 at 18:55 +0100, Michael Niewöhner wrote: > Hi all, > > Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / tpm_i2c_nuvoton > while it works in TPM 1.2 mode (I can reflash it via UEFI setup). > Kernel version is 4.19.1 > > Kernel config: > > $ cat .config | egrep

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Mimi Zohar
On Sun, 2018-11-11 at 18:55 +0100, Michael Niewöhner wrote: > Hi all, > > Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / tpm_i2c_nuvoton > while it works in TPM 1.2 mode (I can reflash it via UEFI setup). > Kernel version is 4.19.1 > > Kernel config: > > $ cat .config | egrep

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread James Bottomley
On Sun, 2018-11-11 at 18:55 +0100, Michael Niewöhner wrote: > Hi all, > > Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / > tpm_i2c_nuvoton while it works in TPM 1.2 mode (I can reflash it via > UEFI setup). Kernel version is 4.19.1 Not that this helps you, but mine definitely

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread James Bottomley
On Sun, 2018-11-11 at 18:55 +0100, Michael Niewöhner wrote: > Hi all, > > Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / > tpm_i2c_nuvoton while it works in TPM 1.2 mode (I can reflash it via > UEFI setup). Kernel version is 4.19.1 Not that this helps you, but mine definitely

[BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
Hi all, Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / tpm_i2c_nuvoton while it works in TPM 1.2 mode (I can reflash it via UEFI setup). Kernel version is 4.19.1 Kernel config: $ cat .config | egrep 'TCG|TPM|CRB|_TIS' CONFIG_TCG_TPM=y CONFIG_HW_RANDOM_TPM=y CONFIG_TCG_TIS_CORE=y

[BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
Hi all, Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / tpm_i2c_nuvoton while it works in TPM 1.2 mode (I can reflash it via UEFI setup). Kernel version is 4.19.1 Kernel config: $ cat .config | egrep 'TCG|TPM|CRB|_TIS' CONFIG_TCG_TPM=y CONFIG_HW_RANDOM_TPM=y CONFIG_TCG_TIS_CORE=y