Re: [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

2019-04-02 Thread Mark Brown
On Tue, Apr 02, 2019 at 08:37:23AM +0200, H. Nikolaus Schaller wrote: > I have learned from Linus that the problem with legacy spi-cs-high are mostly > embedded > powerpc systems deployed between 2008 and 2013 where the boot-loader can't be > changed. And where the dts is not maintained on kernel

Re: [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

2019-04-01 Thread H. Nikolaus Schaller
> Am 02.04.2019 um 07:31 schrieb Mark Brown : > > It's relatively common, especially with older devices, for people to be > perfectly happy to update the kernel and do so frequently but unwilling > to update the bootloader as the procedure for recovering a broken > bootloader is difficult or per

Re: [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

2019-04-01 Thread Mark Brown
On Tue, Apr 02, 2019 at 07:05:35AM +0200, H. Nikolaus Schaller wrote: > > Am 02.04.2019 um 06:02 schrieb Linus Walleij : Please delete unneeded context from mails when replying. Doing this makes it much easier to find your reply in the message, helping ensure it won't be missed by people scrollin

Re: [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

2019-04-01 Thread H. Nikolaus Schaller
Hi Linus, > Am 02.04.2019 um 06:02 schrieb Linus Walleij : > > (CC Kumar and Wolfgang who came up with spi-active-low, I think.) > > On Sun, Mar 24, 2019 at 1:56 PM H. Nikolaus Schaller > wrote: >>> Am 24.03.2019 um 05:15 schrieb Linus Walleij : > >>> But I fixed it in that case by introducin

Re: [Letux-kernel] [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

2019-04-01 Thread Linus Walleij
On Sun, Mar 31, 2019 at 1:33 AM Andreas Kemnade wrote: > > > But I fixed it in that case by introducing a spi-cs-high into the DTS > > > file: > > > https://marc.info/?l=linux-arm-kernel&m=155292310015309&w=2 > > > > Yes, that of course works and is our temporary solution. > > > > And I see that

Re: [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

2019-04-01 Thread Linus Walleij
(CC Kumar and Wolfgang who came up with spi-active-low, I think.) On Sun, Mar 24, 2019 at 1:56 PM H. Nikolaus Schaller wrote: > > Am 24.03.2019 um 05:15 schrieb Linus Walleij : > > But I fixed it in that case by introducing a spi-cs-high into the DTS file: > > https://marc.info/?l=linux-arm-kern

Re: [Letux-kernel] [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

2019-03-30 Thread H. Nikolaus Schaller
Hi Andreas, > Am 30.03.2019 um 19:33 schrieb Andreas Kemnade : > > On Sun, 24 Mar 2019 07:56:17 +0100 > "H. Nikolaus Schaller" wrote: > >> Hi Linus, >> >>> Am 24.03.2019 um 05:15 schrieb Linus Walleij : >>> >>> On Sat, Mar 23, 2019 at 3:40 PM H. Nikolaus Schaller >>> wrote: >>> (1) c1

Re: [Letux-kernel] [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

2019-03-30 Thread Andreas Kemnade
On Sun, 24 Mar 2019 07:56:17 +0100 "H. Nikolaus Schaller" wrote: > Hi Linus, > > > Am 24.03.2019 um 05:15 schrieb Linus Walleij : > > > > On Sat, Mar 23, 2019 at 3:40 PM H. Nikolaus Schaller > > wrote: > > > >> (1) c1c04cea13dc gpio: of: Fix logic inversion > >> > >> together with the bas

Re: [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

2019-03-23 Thread H. Nikolaus Schaller
Hi Linus, > Am 24.03.2019 um 05:15 schrieb Linus Walleij : > > On Sat, Mar 23, 2019 at 3:40 PM H. Nikolaus Schaller > wrote: > >> (1) c1c04cea13dc gpio: of: Fix logic inversion >> >> together with the basic patch >> >> (2) 6953c57ab172 gpio: of: Handle SPI chipselect legacy bindings >> >> l

Re: [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

2019-03-23 Thread Linus Walleij
On Sat, Mar 23, 2019 at 3:40 PM H. Nikolaus Schaller wrote: > (1) c1c04cea13dc gpio: of: Fix logic inversion > > together with the basic patch > > (2) 6953c57ab172 gpio: of: Handle SPI chipselect legacy bindings > > leads to a severe regression for our GTA04 board. Sorry! :( I found the same pr

[BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

2019-03-23 Thread H. Nikolaus Schaller
Hi Linus, I am sorry to report that your patch (1) c1c04cea13dc gpio: of: Fix logic inversion together with the basic patch (2) 6953c57ab172 gpio: of: Handle SPI chipselect legacy bindings leads to a severe regression for our GTA04 board. The symptom was easy to see but really difficult to und