Re: [BUG RFC] iio: pressure: zpa2326: incorrect condition or inconsistent return handling

2017-05-03 Thread Peter Meerwald-Stadler
Hello, > wait_for_completion_interruptible_timeout() returns -ERESTARTSYS, 0 or > remaining time in jiffies (atleast 1), thus the if (ret != -ERESTARTSYS) > case here is unreachable. if is not unreachable, there is a ret = -ETIME above it > As it is not clear from the warn message if this

Re: [BUG RFC] iio: pressure: zpa2326: incorrect condition or inconsistent return handling

2017-05-03 Thread Peter Meerwald-Stadler
Hello, > wait_for_completion_interruptible_timeout() returns -ERESTARTSYS, 0 or > remaining time in jiffies (atleast 1), thus the if (ret != -ERESTARTSYS) > case here is unreachable. if is not unreachable, there is a ret = -ETIME above it > As it is not clear from the warn message if this

[BUG RFC] iio: pressure: zpa2326: incorrect condition or inconsistent return handling

2017-05-03 Thread Nicholas Mc Guire
wait_for_completion_interruptible_timeout() returns -ERESTARTSYS, 0 or remaining time in jiffies (atleast 1), thus the if (ret != -ERESTARTSYS) case here is unreachable. As it is not clear from the warn message if this should simply be changed to if (ret == -ERESTARTSYS), this needs a review by

[BUG RFC] iio: pressure: zpa2326: incorrect condition or inconsistent return handling

2017-05-03 Thread Nicholas Mc Guire
wait_for_completion_interruptible_timeout() returns -ERESTARTSYS, 0 or remaining time in jiffies (atleast 1), thus the if (ret != -ERESTARTSYS) case here is unreachable. As it is not clear from the warn message if this should simply be changed to if (ret == -ERESTARTSYS), this needs a review by