Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Jiang Liu (Gerry)
On 2013/6/14 12:43, Alexander E. Patrakov wrote: 2013/6/14 Jiang Liu (Gerry) : What's the situation now? Could you please send out dmesgs\ioports\iomem? Thanks! The requested information has been added to https://bugzilla.kernel.org/show_bug.cgi?id=56531 The changes in

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Alexander E. Patrakov
2013/6/14 Jiang Liu (Gerry) : > What's the situation now? Could you please send out dmesgs\ioports\iomem? > Thanks! The requested information has been added to https://bugzilla.kernel.org/show_bug.cgi?id=56531 The changes in pci_move_pcibios_add_bus_down.patch are not needed. The radeon card

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Jiang Liu (Gerry)
On 2013/6/14 12:07, Alexander E. Patrakov wrote: 2013/6/14 Jiang Liu (Gerry) : On 2013/6/14 10:30, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 7:09 PM, Jiang Liu (Gerry) wrote: On 2013/6/14 2:42, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 9:32 AM, Jiang Liu wrote: Alexander E. Patrakov

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Alexander E. Patrakov
2013/6/14 Jiang Liu (Gerry) : > On 2013/6/14 10:30, Yinghai Lu wrote: >> >> On Thu, Jun 13, 2013 at 7:09 PM, Jiang Liu (Gerry) >> wrote: >>> >>> On 2013/6/14 2:42, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 9:32 AM, Jiang Liu wrote: > > > Alexander E. Patrakov reports

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Jiang Liu (Gerry)
On 2013/6/14 11:43, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 8:30 PM, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 7:51 PM, Jiang Liu (Gerry) wrote: For the first step, I'm trying to make hotplug case work in the same way as boot time. Do you think this patch help? diff --git

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Yinghai Lu
On Thu, Jun 13, 2013 at 8:30 PM, Yinghai Lu wrote: >> diff --git a/drivers/pci/hotplug/acpiphp_glue.c >> b/drivers/pci/hotplug/acpiphp_gl >> index 270fdba..12e3f6e 100644 >> --- a/drivers/pci/hotplug/acpiphp_glue.c >> +++ b/drivers/pci/hotplug/acpiphp_glue.c >> @@ -837,13 +837,13 @@ static int

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Yinghai Lu
On Thu, Jun 13, 2013 at 8:30 PM, Yinghai Lu wrote: > On Thu, Jun 13, 2013 at 7:51 PM, Jiang Liu (Gerry) > wrote: >> For the first step, I'm trying to make hotplug case work in the same way as >> boot time. Do you think this patch help? >> >> diff --git a/drivers/pci/hotplug/acpiphp_glue.c >>

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Yinghai Lu
On Thu, Jun 13, 2013 at 7:51 PM, Jiang Liu (Gerry) wrote: > On 2013/6/14 10:30, Yinghai Lu wrote: >> >> On Thu, Jun 13, 2013 at 7:09 PM, Jiang Liu (Gerry) >> wrote: > > Not sure. But a little concern about check_hotplug_bridge(), it treats > dock station and devices on dock station with _EJD as

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Yinghai Lu
On Thu, Jun 13, 2013 at 7:06 PM, Alexander E. Patrakov wrote: > 2013/6/14 Yinghai Lu : >> the 3) is about pci resource allocation? >> because pcibios_add_bus is called too early? > > (3) is https://bugzilla.kernel.org/show_bug.cgi?id=56531 > >> If that is case, we should have something like

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Jiang Liu (Gerry)
On 2013/6/14 10:30, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 7:09 PM, Jiang Liu (Gerry) wrote: On 2013/6/14 2:42, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 9:32 AM, Jiang Liu wrote: Alexander E. Patrakov reports two bugs related to dock station support on Sony VAIO VPCZ23A4R. Actually

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Alexander E. Patrakov
2013/6/14 Yinghai Lu : > Is it a regression? No. -- Alexander E. Patrakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Yinghai Lu
On Thu, Jun 13, 2013 at 7:09 PM, Jiang Liu (Gerry) wrote: > On 2013/6/14 2:42, Yinghai Lu wrote: >> >> On Thu, Jun 13, 2013 at 9:32 AM, Jiang Liu wrote: >>> >>> Alexander E. Patrakov reports two bugs related to >>> dock station support on Sony VAIO VPCZ23A4R. Actually there are at least >>>

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Alexander E. Patrakov
2013/6/14 Yinghai Lu : > the 3) is about pci resource allocation? > because pcibios_add_bus is called too early? (3) is https://bugzilla.kernel.org/show_bug.cgi?id=56531 > If that is case, we should have something like attached patch for it. It does not even compile because the argument of

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Jiang Liu (Gerry)
On 2013/6/14 2:42, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 9:32 AM, Jiang Liu wrote: Alexander E. Patrakov reports two bugs related to dock station support on Sony VAIO VPCZ23A4R. Actually there are at least four bugs related to Sony VAIO VPCZ23A4R dock support. 1) can't correctly detect

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Yinghai Lu
On Thu, Jun 13, 2013 at 12:02 PM, Rafael J. Wysocki wrote: > On Thursday, June 13, 2013 11:42:16 AM Yinghai Lu wrote: >> On Thu, Jun 13, 2013 at 9:32 AM, Jiang Liu wrote: >> > Alexander E. Patrakov reports two bugs related to >> > dock station support on Sony VAIO VPCZ23A4R. Actually there are

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Rafael J. Wysocki
On Thursday, June 13, 2013 11:42:16 AM Yinghai Lu wrote: > On Thu, Jun 13, 2013 at 9:32 AM, Jiang Liu wrote: > > Alexander E. Patrakov reports two bugs related to > > dock station support on Sony VAIO VPCZ23A4R. Actually there are at least > > four bugs related to Sony VAIO VPCZ23A4R dock

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Yinghai Lu
On Thu, Jun 13, 2013 at 9:32 AM, Jiang Liu wrote: > Alexander E. Patrakov reports two bugs related to > dock station support on Sony VAIO VPCZ23A4R. Actually there are at least > four bugs related to Sony VAIO VPCZ23A4R dock support. > 1) can't correctly detect hotplug slot for dock state > 2)

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Alexander E. Patrakov
2013/6/13 Alexander E. Patrakov : > 2013/6/13 Jiang Liu : >> Alexander E. Patrakov reports two bugs related to >> dock station support on Sony VAIO VPCZ23A4R. Actually there are at least >> four bugs related to Sony VAIO VPCZ23A4R dock support. >> 1) can't correctly detect hotplug slot for dock

[BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Jiang Liu
Alexander E. Patrakov reports two bugs related to dock station support on Sony VAIO VPCZ23A4R. Actually there are at least four bugs related to Sony VAIO VPCZ23A4R dock support. 1) can't correctly detect hotplug slot for dock state 2) resource leak on undocking 3) resource allocation failure for

[BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Jiang Liu
Alexander E. Patrakov patra...@gmail.com reports two bugs related to dock station support on Sony VAIO VPCZ23A4R. Actually there are at least four bugs related to Sony VAIO VPCZ23A4R dock support. 1) can't correctly detect hotplug slot for dock state 2) resource leak on undocking 3) resource

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Alexander E. Patrakov
2013/6/13 Alexander E. Patrakov patra...@gmail.com: 2013/6/13 Jiang Liu jiang@huawei.com: Alexander E. Patrakov patra...@gmail.com reports two bugs related to dock station support on Sony VAIO VPCZ23A4R. Actually there are at least four bugs related to Sony VAIO VPCZ23A4R dock support. 1)

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Yinghai Lu
On Thu, Jun 13, 2013 at 9:32 AM, Jiang Liu jiang@huawei.com wrote: Alexander E. Patrakov patra...@gmail.com reports two bugs related to dock station support on Sony VAIO VPCZ23A4R. Actually there are at least four bugs related to Sony VAIO VPCZ23A4R dock support. 1) can't correctly detect

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Rafael J. Wysocki
On Thursday, June 13, 2013 11:42:16 AM Yinghai Lu wrote: On Thu, Jun 13, 2013 at 9:32 AM, Jiang Liu jiang@huawei.com wrote: Alexander E. Patrakov patra...@gmail.com reports two bugs related to dock station support on Sony VAIO VPCZ23A4R. Actually there are at least four bugs related to

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Yinghai Lu
On Thu, Jun 13, 2013 at 12:02 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Thursday, June 13, 2013 11:42:16 AM Yinghai Lu wrote: On Thu, Jun 13, 2013 at 9:32 AM, Jiang Liu jiang@huawei.com wrote: Alexander E. Patrakov patra...@gmail.com reports two bugs related to dock station support on

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Jiang Liu (Gerry)
On 2013/6/14 2:42, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 9:32 AM, Jiang Liu jiang@huawei.com wrote: Alexander E. Patrakov patra...@gmail.com reports two bugs related to dock station support on Sony VAIO VPCZ23A4R. Actually there are at least four bugs related to Sony VAIO VPCZ23A4R dock

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Alexander E. Patrakov
2013/6/14 Yinghai Lu ying...@kernel.org: the 3) is about pci resource allocation? because pcibios_add_bus is called too early? (3) is https://bugzilla.kernel.org/show_bug.cgi?id=56531 If that is case, we should have something like attached patch for it. It does not even compile because the

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Yinghai Lu
On Thu, Jun 13, 2013 at 7:09 PM, Jiang Liu (Gerry) jiang@huawei.com wrote: On 2013/6/14 2:42, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 9:32 AM, Jiang Liu jiang@huawei.com wrote: Alexander E. Patrakov patra...@gmail.com reports two bugs related to dock station support on Sony VAIO

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Alexander E. Patrakov
2013/6/14 Yinghai Lu ying...@kernel.org: Is it a regression? No. -- Alexander E. Patrakov -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Jiang Liu (Gerry)
On 2013/6/14 10:30, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 7:09 PM, Jiang Liu (Gerry) jiang@huawei.com wrote: On 2013/6/14 2:42, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 9:32 AM, Jiang Liu jiang@huawei.com wrote: Alexander E. Patrakov patra...@gmail.com reports two bugs related

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Yinghai Lu
On Thu, Jun 13, 2013 at 7:06 PM, Alexander E. Patrakov patra...@gmail.com wrote: 2013/6/14 Yinghai Lu ying...@kernel.org: the 3) is about pci resource allocation? because pcibios_add_bus is called too early? (3) is https://bugzilla.kernel.org/show_bug.cgi?id=56531 If that is case, we should

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Yinghai Lu
On Thu, Jun 13, 2013 at 7:51 PM, Jiang Liu (Gerry) jiang@huawei.com wrote: On 2013/6/14 10:30, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 7:09 PM, Jiang Liu (Gerry) jiang@huawei.com wrote: Not sure. But a little concern about check_hotplug_bridge(), it treats dock station and devices

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Yinghai Lu
On Thu, Jun 13, 2013 at 8:30 PM, Yinghai Lu ying...@kernel.org wrote: On Thu, Jun 13, 2013 at 7:51 PM, Jiang Liu (Gerry) jiang@huawei.com wrote: For the first step, I'm trying to make hotplug case work in the same way as boot time. Do you think this patch help? diff --git

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Yinghai Lu
On Thu, Jun 13, 2013 at 8:30 PM, Yinghai Lu ying...@kernel.org wrote: diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_gl index 270fdba..12e3f6e 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++ b/drivers/pci/hotplug/acpiphp_glue.c @@ -837,13 +837,13 @@ static

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Jiang Liu (Gerry)
On 2013/6/14 11:43, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 8:30 PM, Yinghai Lu ying...@kernel.org wrote: On Thu, Jun 13, 2013 at 7:51 PM, Jiang Liu (Gerry) jiang@huawei.com wrote: For the first step, I'm trying to make hotplug case work in the same way as boot time. Do you think this

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Alexander E. Patrakov
2013/6/14 Jiang Liu (Gerry) jiang@huawei.com: On 2013/6/14 10:30, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 7:09 PM, Jiang Liu (Gerry) jiang@huawei.com wrote: On 2013/6/14 2:42, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 9:32 AM, Jiang Liu jiang@huawei.com wrote: Alexander

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Jiang Liu (Gerry)
On 2013/6/14 12:07, Alexander E. Patrakov wrote: 2013/6/14 Jiang Liu (Gerry) jiang@huawei.com: On 2013/6/14 10:30, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 7:09 PM, Jiang Liu (Gerry) jiang@huawei.com wrote: On 2013/6/14 2:42, Yinghai Lu wrote: On Thu, Jun 13, 2013 at 9:32 AM,

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Alexander E. Patrakov
2013/6/14 Jiang Liu (Gerry) jiang@huawei.com: What's the situation now? Could you please send out dmesgs\ioports\iomem? Thanks! The requested information has been added to https://bugzilla.kernel.org/show_bug.cgi?id=56531 The changes in pci_move_pcibios_add_bus_down.patch are not needed.

Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver

2013-06-13 Thread Jiang Liu (Gerry)
On 2013/6/14 12:43, Alexander E. Patrakov wrote: 2013/6/14 Jiang Liu (Gerry) jiang@huawei.com: What's the situation now? Could you please send out dmesgs\ioports\iomem? Thanks! The requested information has been added to https://bugzilla.kernel.org/show_bug.cgi?id=56531 The changes in