On Wed, Feb 13 2008 at 21:38 +0200, Jan Engelhardt <[EMAIL PROTECTED]> wrote:
> On Feb 13 2008 11:03, Boaz Harrosh wrote:
>>> I've tested this patch now - and it works fine. Now rmmod, halt and
>>> reboot also works.
>>>
>>> Stefan Priebe
>>>
>> This is grate news Stefan. Thank you very much for
On Wed, Feb 13 2008 at 19:36 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
>> ---
>> From: Boaz Harrosh <[EMAIL PROTECTED]>
>> Subject: [PATCH] gdth: bugfix for the at-exit problems
>>
>> gdth_exit would first remove all cards then stop the timer
>> and would not sync with the timer function.
On Wed, Feb 13 2008 at 19:36 +0200, James Bottomley [EMAIL PROTECTED] wrote:
snip
---
From: Boaz Harrosh [EMAIL PROTECTED]
Subject: [PATCH] gdth: bugfix for the at-exit problems
gdth_exit would first remove all cards then stop the timer
and would not sync with the timer function. This caused
On Wed, Feb 13 2008 at 21:38 +0200, Jan Engelhardt [EMAIL PROTECTED] wrote:
On Feb 13 2008 11:03, Boaz Harrosh wrote:
I've tested this patch now - and it works fine. Now rmmod, halt and
reboot also works.
Stefan Priebe
This is grate news Stefan. Thank you very much for all your time
and
On Wed, Feb 13, 2008 at 11:03:45AM -0600, James Bottomley wrote:
> > I don't understand please explain.
> > What does a driver need to do if it needs a consistent shutdown retine?
> > module or built in? unload or shutdown?
>
> It needs to register a reboot notifier, which gdth does.
Well, for
On Feb 13 2008 11:03, Boaz Harrosh wrote:
>>
>> I've tested this patch now - and it works fine. Now rmmod, halt and
>> reboot also works.
>>
>> Stefan Priebe
>>
>This is grate news Stefan. Thank you very much for all your time
>and effort, with out we could not have fixed all this.
Do you
On Wed, 2008-02-13 at 19:12 +0200, Boaz Harrosh wrote:
> On Wed, Feb 13 2008 at 19:03 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> > On Wed, 2008-02-13 at 18:50 +0200, Boaz Harrosh wrote:
> >> On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley <[EMAIL PROTECTED]>
> >> wrote:
> >>> On Wed,
On Wed, 2008-02-13 at 19:18 +0200, Boaz Harrosh wrote:
> On Wed, Feb 13 2008 at 19:03 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> > It needs to register a reboot notifier, which gdth does.
> >
> > However, the notifier is only called on reboot, so it also needs to
> > clean up correctly
On Wed, Feb 13 2008 at 19:03 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Wed, 2008-02-13 at 18:50 +0200, Boaz Harrosh wrote:
>> On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley <[EMAIL PROTECTED]>
>> wrote:
>>> On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote:
On Wed, Feb
On Wed, Feb 13 2008 at 19:03 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Wed, 2008-02-13 at 18:50 +0200, Boaz Harrosh wrote:
>> On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley <[EMAIL PROTECTED]>
>> wrote:
>>> On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote:
On Wed, Feb
On Wed, 2008-02-13 at 18:50 +0200, Boaz Harrosh wrote:
> On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> > On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote:
> >> On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> >>> On Wed, Feb 13
On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote:
>> On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>>> On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley <[EMAIL PROTECTED]>
>>>
On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote:
> On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> > On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley <[EMAIL PROTECTED]>
> > wrote:
> >> On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote:
> >>> -
On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
>> On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote:
>>> - gdth_flush(ha);
>>> -
>> This piece doesn't look right. gdth_flush()
On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote:
>> -gdth_flush(ha);
>> -
>
> This piece doesn't look right. gdth_flush() forces the internal cache
> to disk backing. If you remove it, you're taking the
On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote:
> - gdth_flush(ha);
> -
This piece doesn't look right. gdth_flush() forces the internal cache
to disk backing. If you remove it, you're taking the chance that the
machine will be powered off without a writeback which can cause data
On Tue, Feb 12 2008 at 19:40 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> gdth _exit would first remove all cards then stop the timer
> and would not sync with the timer function. This caused a crash
> in gdth_timer() when module was unloaded.
>
> del_timer_sync the timer before we delete the
On Wed, Feb 13 2008 at 9:06 +0200, Stefan Priebe - allied internet ag <[EMAIL
PROTECTED]> wrote:
> Hello!
>
> I've tested this patch now - and it works fine. Now rmmod, halt and
> reboot also works.
>
> Stefan Priebe
>
This is grate news Stefan. Thank you very much for all your time
and
On Wed, Feb 13 2008 at 9:06 +0200, Stefan Priebe - allied internet ag [EMAIL
PROTECTED] wrote:
Hello!
I've tested this patch now - and it works fine. Now rmmod, halt and
reboot also works.
Stefan Priebe
This is grate news Stefan. Thank you very much for all your time
and effort, with
On Tue, Feb 12 2008 at 19:40 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
gdth _exit would first remove all cards then stop the timer
and would not sync with the timer function. This caused a crash
in gdth_timer() when module was unloaded.
del_timer_sync the timer before we delete the cards.
On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote:
- gdth_flush(ha);
-
This piece doesn't look right. gdth_flush() forces the internal cache
to disk backing. If you remove it, you're taking the chance that the
machine will be powered off without a writeback which can cause data
On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote:
-gdth_flush(ha);
-
This piece doesn't look right. gdth_flush() forces the internal cache
to disk backing. If you remove it, you're taking the chance that
On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote:
On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley [EMAIL PROTECTED]
wrote:
On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote:
- gdth_flush(ha);
-
On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote:
- gdth_flush(ha);
-
This piece doesn't look right. gdth_flush() forces the internal
On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote:
On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley [EMAIL PROTECTED]
wrote:
On Tue,
On Wed, Feb 13 2008 at 19:03 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Wed, 2008-02-13 at 18:50 +0200, Boaz Harrosh wrote:
On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley [EMAIL PROTECTED]
wrote:
On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote:
On Wed, Feb 13 2008 at 17:54
On Wed, Feb 13 2008 at 19:03 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Wed, 2008-02-13 at 18:50 +0200, Boaz Harrosh wrote:
On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley [EMAIL PROTECTED]
wrote:
On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote:
On Wed, Feb 13 2008 at 17:54
On Wed, 2008-02-13 at 18:50 +0200, Boaz Harrosh wrote:
On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote:
On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
On Wed, Feb 13 2008 at 17:44
On Wed, 2008-02-13 at 19:18 +0200, Boaz Harrosh wrote:
On Wed, Feb 13 2008 at 19:03 +0200, James Bottomley [EMAIL PROTECTED] wrote:
It needs to register a reboot notifier, which gdth does.
However, the notifier is only called on reboot, so it also needs to
clean up correctly on module
On Wed, 2008-02-13 at 19:12 +0200, Boaz Harrosh wrote:
On Wed, Feb 13 2008 at 19:03 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Wed, 2008-02-13 at 18:50 +0200, Boaz Harrosh wrote:
On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley [EMAIL PROTECTED]
wrote:
On Wed, 2008-02-13 at
On Feb 13 2008 11:03, Boaz Harrosh wrote:
I've tested this patch now - and it works fine. Now rmmod, halt and
reboot also works.
Stefan Priebe
This is grate news Stefan. Thank you very much for all your time
and effort, with out we could not have fixed all this.
Do you have a git tree
On Wed, Feb 13, 2008 at 11:03:45AM -0600, James Bottomley wrote:
I don't understand please explain.
What does a driver need to do if it needs a consistent shutdown retine?
module or built in? unload or shutdown?
It needs to register a reboot notifier, which gdth does.
Well, for crappy
Hello!
I've tested this patch now - and it works fine. Now rmmod, halt and
reboot also works.
Stefan Priebe
Boaz Harrosh schrieb:
gdth _exit would first remove all cards then stop the timer
and would not sync with the timer function. This caused a crash
in gdth_timer() when module was
gdth _exit would first remove all cards then stop the timer
and would not sync with the timer function. This caused a crash
in gdth_timer() when module was unloaded.
del_timer_sync the timer before we delete the cards.
NOT YET TESTED
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
gdth _exit would first remove all cards then stop the timer
and would not sync with the timer function. This caused a crash
in gdth_timer() when module was unloaded.
del_timer_sync the timer before we delete the cards.
NOT YET TESTED
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
Hello!
I've tested this patch now - and it works fine. Now rmmod, halt and
reboot also works.
Stefan Priebe
Boaz Harrosh schrieb:
gdth _exit would first remove all cards then stop the timer
and would not sync with the timer function. This caused a crash
in gdth_timer() when module was
36 matches
Mail list logo
