Re: [Bug fix]mips 64bits checksum error -- csum_tcpudp_nofold

2017-01-26 Thread Ralf Baechle
avemloft.net>, > Alexander Duyck <adu...@mirantis.com>, linux-m...@linux-mips.org, > "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> > Subject: Re: [Bug fix]mips 64bits checksum error -- csum_tcpudp_nofold > Content-Type: text/plain; charset=UTF-8

Re: [Bug fix]mips 64bits checksum error -- csum_tcpudp_nofold

2017-01-26 Thread Ralf Baechle
> Subject: Re: [Bug fix]mips 64bits checksum error -- csum_tcpudp_nofold > Content-Type: text/plain; charset=UTF-8 > > On Wed, Jan 25, 2017 at 6:33 PM, Mark Zhang wrote: > > Hi Alex, > > > > Thanks for your reply. > > I tested your correction. The re

Re: [Bug fix]mips 64bits checksum error -- csum_tcpudp_nofold

2017-01-26 Thread Alexander Duyck
On Wed, Jan 25, 2017 at 6:33 PM, Mark Zhang wrote: > Hi Alex, > > Thanks for your reply. > I tested your correction. The result is correct. > The C language will cause this function(csum_tcpudp_nofold) become > 176 MIPS instructions. The assemble code is 150 MIPS

Re: [Bug fix]mips 64bits checksum error -- csum_tcpudp_nofold

2017-01-26 Thread Alexander Duyck
On Wed, Jan 25, 2017 at 6:33 PM, Mark Zhang wrote: > Hi Alex, > > Thanks for your reply. > I tested your correction. The result is correct. > The C language will cause this function(csum_tcpudp_nofold) become > 176 MIPS instructions. The assemble code is 150 MIPS instruction. > If

Re: [Bug fix]mips 64bits checksum error -- csum_tcpudp_nofold

2017-01-26 Thread Ralf Baechle
On Wed, Jan 25, 2017 at 10:13:32AM -0800, Alexander Duyck wrote: > On Tue, Jan 24, 2017 at 8:35 PM, Mark Zhang wrote: > > If the input parameters as saddr = 0xc0a8fd60,daddr = 0xc0a8fda1,len = > > 80, proto = 17, sum =0x7eae049d. > > The correct result should be 1, but

Re: [Bug fix]mips 64bits checksum error -- csum_tcpudp_nofold

2017-01-26 Thread Ralf Baechle
On Wed, Jan 25, 2017 at 10:13:32AM -0800, Alexander Duyck wrote: > On Tue, Jan 24, 2017 at 8:35 PM, Mark Zhang wrote: > > If the input parameters as saddr = 0xc0a8fd60,daddr = 0xc0a8fda1,len = > > 80, proto = 17, sum =0x7eae049d. > > The correct result should be 1, but original function return

Re: [Bug fix]mips 64bits checksum error -- csum_tcpudp_nofold

2017-01-25 Thread Mark Zhang
Hi Alex, Thanks for your reply. I tested your correction. The result is correct. The C language will cause this function(csum_tcpudp_nofold) become 176 MIPS instructions. The assemble code is 150 MIPS instruction. If the MIPS CPU is running as 1GHz, C language cause more 60 nano

Re: [Bug fix]mips 64bits checksum error -- csum_tcpudp_nofold

2017-01-25 Thread Mark Zhang
Hi Alex, Thanks for your reply. I tested your correction. The result is correct. The C language will cause this function(csum_tcpudp_nofold) become 176 MIPS instructions. The assemble code is 150 MIPS instruction. If the MIPS CPU is running as 1GHz, C language cause more 60 nano

Re: [Bug fix]mips 64bits checksum error -- csum_tcpudp_nofold

2017-01-25 Thread Alexander Duyck
On Tue, Jan 24, 2017 at 8:35 PM, Mark Zhang wrote: > If the input parameters as saddr = 0xc0a8fd60,daddr = 0xc0a8fda1,len = > 80, proto = 17, sum =0x7eae049d. > The correct result should be 1, but original function return 0. > > Attached the correction patch. I've copied

Re: [Bug fix]mips 64bits checksum error -- csum_tcpudp_nofold

2017-01-25 Thread Alexander Duyck
On Tue, Jan 24, 2017 at 8:35 PM, Mark Zhang wrote: > If the input parameters as saddr = 0xc0a8fd60,daddr = 0xc0a8fda1,len = > 80, proto = 17, sum =0x7eae049d. > The correct result should be 1, but original function return 0. > > Attached the correction patch. I've copied your patch here: >From

[Bug fix]mips 64bits checksum error -- csum_tcpudp_nofold

2017-01-24 Thread Mark Zhang
If the input parameters as saddr = 0xc0a8fd60,daddr = 0xc0a8fda1,len = 80, proto = 17, sum =0x7eae049d. The correct result should be 1, but original function return 0. Attached the correction patch. 0001-Fixed-the-mips-64bits-checksum-error-csum_tcpudp_nof.patch Description: Binary data

[Bug fix]mips 64bits checksum error -- csum_tcpudp_nofold

2017-01-24 Thread Mark Zhang
If the input parameters as saddr = 0xc0a8fd60,daddr = 0xc0a8fda1,len = 80, proto = 17, sum =0x7eae049d. The correct result should be 1, but original function return 0. Attached the correction patch. 0001-Fixed-the-mips-64bits-checksum-error-csum_tcpudp_nof.patch Description: Binary data