Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

On 11/25/2015 9:12 AM, Jiang Liu wrote: On 2015/11/25 6:19, Rafael J. Wysocki wrote: On Tue, Nov 24, 2015 at 5:49 PM, Bjorn Helgaas wrote: On Mon, Nov 16, 2015 at 12:27:37PM +0800, Jiang Liu wrote: From: Liu Jiang Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support PCI host

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

Jiang Liu wrote on 25/11/15 18:57: Hi Arthur, Thanks for reminder again! It's a little strange, the formal patch "[Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245" is based on the debug patch I sent to you at 9 November 2015. Could you please h

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

esource *res; > struct resource *root; > > @@ -61,6 +63,7 @@ void x86_pci_root_bus_resources(int bus, struct > list_head *resources) > else > root = _resource; > insert_resource(root, res); > +#endif > } > return; > > ### &g

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

On 2015/11/25 6:19, Rafael J. Wysocki wrote: > On Tue, Nov 24, 2015 at 5:49 PM, Bjorn Helgaas wrote: >> On Mon, Nov 16, 2015 at 12:27:37PM +0800, Jiang Liu wrote: >>> From: Liu Jiang >>> >>> Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support >>> PCI host bridge") converted x86

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

Jiang Liu wrote on 25/11/15 18:57: Hi Arthur, Thanks for reminder again! It's a little strange, the formal patch "[Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245" is based on the debug patch I sent to you at 9 November 2015. Could you please h

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

pci_add_resource(resources, >busn); > > list_for_each_entry(root_res, >resources, list) { > +pci_add_resource(resources, _res->res); > +#if 0 > struct resource *res; > struct resource *root; > > @@ -61,6 +63,7 @@ void x86_pci

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

On 2015/11/25 6:19, Rafael J. Wysocki wrote: > On Tue, Nov 24, 2015 at 5:49 PM, Bjorn Helgaas wrote: >> On Mon, Nov 16, 2015 at 12:27:37PM +0800, Jiang Liu wrote: >>> From: Liu Jiang >>> >>> Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

On 11/25/2015 9:12 AM, Jiang Liu wrote: On 2015/11/25 6:19, Rafael J. Wysocki wrote: On Tue, Nov 24, 2015 at 5:49 PM, Bjorn Helgaas wrote: On Mon, Nov 16, 2015 at 12:27:37PM +0800, Jiang Liu wrote: From: Liu Jiang Commit 4d6b4e69a245

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

ad *resources) else root = _resource; insert_resource(root, res); +#endif } return; ### The patch postd by Jian Liu on 16 November 2015 "[Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245" had *not* been seen or tested by me before being

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

On Tue, Nov 24, 2015 at 11:19:34PM +0100, Rafael J. Wysocki wrote: > Quite frankly, I'm more likely to revert the offending commit at this > point as that's not the only regression reported against it and the > fix only helps in one case (out of three known to me). Using 4.4-rc1 and can confirm

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

On Tue, Nov 24, 2015 at 5:49 PM, Bjorn Helgaas wrote: > On Mon, Nov 16, 2015 at 12:27:37PM +0800, Jiang Liu wrote: >> From: Liu Jiang >> >> Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support >> PCI host bridge") converted x86 to use the common interface >> acpi_pci_root_create,

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

On Mon, Nov 16, 2015 at 12:27:37PM +0800, Jiang Liu wrote: > From: Liu Jiang > > Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support > PCI host bridge") converted x86 to use the common interface > acpi_pci_root_create, but the conversion missed on code piece in >

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

On Tue, Nov 24, 2015 at 5:49 PM, Bjorn Helgaas wrote: > On Mon, Nov 16, 2015 at 12:27:37PM +0800, Jiang Liu wrote: >> From: Liu Jiang >> >> Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support >> PCI host bridge") converted x86 to use

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

On Tue, Nov 24, 2015 at 11:19:34PM +0100, Rafael J. Wysocki wrote: > Quite frankly, I'm more likely to revert the offending commit at this > point as that's not the only regression reported against it and the > fix only helps in one case (out of three known to me). Using 4.4-rc1 and can confirm

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

On Mon, Nov 16, 2015 at 12:27:37PM +0800, Jiang Liu wrote: > From: Liu Jiang > > Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support > PCI host bridge") converted x86 to use the common interface > acpi_pci_root_create, but the conversion missed on code

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

e(root, res); +#endif } return; ### The patch postd by Jian Liu on 16 November 2015 "[Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245" had *not* been seen or tested by me before being posted to the linux-acpi list and when I did test it (after remov

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

On 11/16/2015 08:06 AM, Arthur Marsh wrote: Jiang Liu wrote on 16/11/15 14:57: From: Liu Jiang Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support PCI host bridge") converted x86 to use the common interface acpi_pci_root_create, but the conversion missed on code piece in

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

On 11/16/2015 08:06 AM, Arthur Marsh wrote: Jiang Liu wrote on 16/11/15 14:57: From: Liu Jiang Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support PCI host bridge") converted x86 to use the common interface acpi_pci_root_create, but the conversion

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

Jiang Liu wrote on 16/11/15 14:57: From: Liu Jiang Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support PCI host bridge") converted x86 to use the common interface acpi_pci_root_create, but the conversion missed on code piece in arch/x86/pci/bus_numa.c, which causes regression

[Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

From: Liu Jiang Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support PCI host bridge") converted x86 to use the common interface acpi_pci_root_create, but the conversion missed on code piece in arch/x86/pci/bus_numa.c, which causes regression on some legacy AMD platforms as

[Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

From: Liu Jiang Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support PCI host bridge") converted x86 to use the common interface acpi_pci_root_create, but the conversion missed on code piece in arch/x86/pci/bus_numa.c, which causes regression on some

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

Jiang Liu wrote on 16/11/15 14:57: From: Liu Jiang Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support PCI host bridge") converted x86 to use the common interface acpi_pci_root_create, but the conversion missed on code piece in