Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update

2007-01-31 Thread Christoph Hellwig
On Wed, Jan 31, 2007 at 09:57:26AM +1100, Benjamin Herrenschmidt wrote: > On Tue, 2007-01-30 at 14:49 -0800, Carl Love wrote: > > Christoph: > > > > In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt > > said that we should remove macros that are only used once and just put >

Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update

2007-01-31 Thread Christoph Hellwig
On Wed, Jan 31, 2007 at 09:57:26AM +1100, Benjamin Herrenschmidt wrote: On Tue, 2007-01-30 at 14:49 -0800, Carl Love wrote: Christoph: In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt said that we should remove macros that are only used once and just put the

Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update

2007-01-30 Thread Benjamin Herrenschmidt
On Tue, 2007-01-30 at 14:49 -0800, Carl Love wrote: > Christoph: > > In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt > said that we should remove macros that are only used once and just put > the actual code in. That is why the macros were removed. Heh... there is a

Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update

2007-01-30 Thread Benjamin Herrenschmidt
On Tue, 2007-01-30 at 14:49 -0800, Carl Love wrote: > Christoph: > > In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt > said that we should remove macros that are only used once and just put > the actual code in. That is why the macros were removed. I've looked at the

Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update

2007-01-30 Thread Carl Love
Christoph: In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt said that we should remove macros that are only used once and just put the actual code in. That is why the macros were removed. Carl Love On Tue, 2007-01-30 at 11:39 +0100, Christoph Hellwig wrote:

Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update

2007-01-30 Thread Christoph Hellwig
On Mon, Jan 29, 2007 at 01:46:50PM -0600, Maynard Johnson wrote: > > I don't think the macro removal is helpful, getting rid of the names makes the code less readable to me. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update

2007-01-30 Thread Christoph Hellwig
On Mon, Jan 29, 2007 at 01:46:50PM -0600, Maynard Johnson wrote: I don't think the macro removal is helpful, getting rid of the names makes the code less readable to me. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update

2007-01-30 Thread Carl Love
Christoph: In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt said that we should remove macros that are only used once and just put the actual code in. That is why the macros were removed. Carl Love On Tue, 2007-01-30 at 11:39 +0100, Christoph Hellwig wrote:

Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update

2007-01-30 Thread Benjamin Herrenschmidt
On Tue, 2007-01-30 at 14:49 -0800, Carl Love wrote: Christoph: In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt said that we should remove macros that are only used once and just put the actual code in. That is why the macros were removed. I've looked at the macros

Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update

2007-01-30 Thread Benjamin Herrenschmidt
On Tue, 2007-01-30 at 14:49 -0800, Carl Love wrote: Christoph: In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt said that we should remove macros that are only used once and just put the actual code in. That is why the macros were removed. Heh... there is a balance

Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update

2007-01-29 Thread Arnd Bergmann
On Monday 29 January 2007 20:46, Maynard Johnson wrote: > This is a clean up patch that includes the following changes: > >         -It removes some macro definitions that are only used once >          with the actual code. >         -Some comments were added to clarify the code based on

Re: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update

2007-01-29 Thread Arnd Bergmann
On Monday 29 January 2007 20:46, Maynard Johnson wrote: This is a clean up patch that includes the following changes:         -It removes some macro definitions that are only used once          with the actual code.         -Some comments were added to clarify the code based on feedback