Re: [Cluster-devel] [PATCH] fs: gfs2: prevent OOB access in gfs2_read_sb()

2020-10-14 Thread Fox Chen
Hi Andrew, On Wed, Oct 14, 2020 at 9:04 PM Andrew Price wrote: > Just a heads-up to avoid duplication of effort: Fox Chen (CCed) has > attempted to fix this also[1], but I don't know if they plan to send > another patch. Oh, I thought it was solved by someone else as you've pointed out the

Re: [Cluster-devel] [PATCH] fs: gfs2: prevent OOB access in gfs2_read_sb()

2020-10-14 Thread Anant Thazhemadam
On 14/10/20 6:34 pm, Andrew Price wrote: > On 13/10/2020 16:26, Anant Thazhemadam wrote: >> In gfs2_read_sb(), if the condition >> (d != sdp->sd_heightsize[x - 1] || m) >> isn't satisfied (in the first 11 iterations), the loop continues, >> and begins to perform out-of-bounds access. >> Fix

Re: [Cluster-devel] [PATCH] fs: gfs2: prevent OOB access in gfs2_read_sb()

2020-10-14 Thread Andrew Price
On 13/10/2020 16:26, Anant Thazhemadam wrote: In gfs2_read_sb(), if the condition (d != sdp->sd_heightsize[x - 1] || m) isn't satisfied (in the first 11 iterations), the loop continues, and begins to perform out-of-bounds access. Fix this out-of-bounds access by introducing a condition