Re: [Cocci] SmPL for automatic request_firmware_nowait() conversion

2014-06-23 Thread Luis R. Rodriguez
On Tue, Jun 24, 2014 at 01:21:07AM +0200, Luis R. Rodriguez wrote: > On Sat, Jun 21, 2014 at 12:52:05PM +0200, Francois Romieu wrote: > > Luis R. Rodriguez : > I was actually in the hopes a suitable transormation can be designed > to put a wait_for_completion() in say ndo_init(). I was looking to

Re: [Cocci] SmPL for automatic request_firmware_nowait() conversion

2014-06-20 Thread SF Markus Elfring
> Obviously I considered writing SmPL for this, but one thing which seemed > hard was that for after the request_firmware_nowait() we tend to tuck > away into another new call the rest of the code that was in place in the > original function after the old request_firmware() call. Is there a way > t

Re: [Cocci] SmPL for automatic request_firmware_nowait() conversion

2014-06-20 Thread Julia Lawall
On Sat, 21 Jun 2014, Luis R. Rodriguez wrote: > I was just porting over an ethernet driver [0] to use > request_firmware_nowait() > since firmware loading seems can take over a minute on one device, while > at it I noticed no other ethernet drivers yet use this API so figure > this may be a trend