Re: [EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-11 Thread Jose R. Santos
The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but create_proc_entry() does not do lookups on file names that are more that one directory deep. This causes the entry creation to fail and hence, no proc file is created. Instead of fixing this on procfs might as well move the

Re: [EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-11 Thread Andrew Morton
On Wed, 11 Jul 2007 00:38:09 -0500 "Jose R. Santos" <[EMAIL PROTECTED]> wrote: > > > Alternatively (and preferably) do this via an update to > > Documentation/filesystems/ext4.txt. > > Seems like I also need to update the doc on Kconfig as well. Do you > prefer this in separate patches?

Re: [EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-11 Thread Mingming Cao
On Wed, 2007-07-11 at 00:38 -0500, Jose R. Santos wrote: > On Tue, 10 Jul 2007 16:30:25 -0700 > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > On Sun, 01 Jul 2007 03:36:48 -0400 > > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > > > > On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote: > > > > >

Re: [EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-11 Thread Mingming Cao
On Wed, 2007-07-11 at 00:38 -0500, Jose R. Santos wrote: On Tue, 10 Jul 2007 16:30:25 -0700 Andrew Morton [EMAIL PROTECTED] wrote: On Sun, 01 Jul 2007 03:36:48 -0400 Mingming Cao [EMAIL PROTECTED] wrote: On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote: The jbd2-debug file

Re: [EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-11 Thread Andrew Morton
On Wed, 11 Jul 2007 00:38:09 -0500 Jose R. Santos [EMAIL PROTECTED] wrote: Alternatively (and preferably) do this via an update to Documentation/filesystems/ext4.txt. Seems like I also need to update the doc on Kconfig as well. Do you prefer this in separate patches? (current patch,

Re: [EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-11 Thread Jose R. Santos
The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but create_proc_entry() does not do lookups on file names that are more that one directory deep. This causes the entry creation to fail and hence, no proc file is created. Instead of fixing this on procfs might as well move the

Re: [EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-10 Thread Jose R. Santos
On Tue, 10 Jul 2007 16:30:25 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Sun, 01 Jul 2007 03:36:48 -0400 > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > > On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote: > > > > The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but >

Re: [EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:36:48 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > > On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote: > > > The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but > > > create_proc_entry() does not do lookups on file names with more that one > > >

Re: [EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:36:48 -0400 Mingming Cao [EMAIL PROTECTED] wrote: On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote: The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but create_proc_entry() does not do lookups on file names with more that one directory deep.

Re: [EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-10 Thread Jose R. Santos
On Tue, 10 Jul 2007 16:30:25 -0700 Andrew Morton [EMAIL PROTECTED] wrote: On Sun, 01 Jul 2007 03:36:48 -0400 Mingming Cao [EMAIL PROTECTED] wrote: On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote: The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but

[EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-01 Thread Mingming Cao
> On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote: > > The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but > > create_proc_entry() does not do lookups on file names with more that one > > directory deep. This causes the entry creation to fail and hence, no proc > > file is

[EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-01 Thread Mingming Cao
On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote: The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but create_proc_entry() does not do lookups on file names with more that one directory deep. This causes the entry creation to fail and hence, no proc file is created.