Re: [Eas-dev] [PATCH V4 0/3] sched: cpufreq: Allow remote callbacks

2017-07-27 Thread Joel Fernandes (Google)
On Thu, Jul 27, 2017 at 12:21 AM, Juri Lelli wrote: [..] >> > >> > But even without that, if you see the routine >> > init_entity_runnable_average() in fair.c, the new tasks are >> > initialized in a way that they are seen as heavy tasks. And so even >> > for the first time

Re: [Eas-dev] [PATCH V4 0/3] sched: cpufreq: Allow remote callbacks

2017-07-27 Thread Joel Fernandes (Google)
On Thu, Jul 27, 2017 at 12:21 AM, Juri Lelli wrote: [..] >> > >> > But even without that, if you see the routine >> > init_entity_runnable_average() in fair.c, the new tasks are >> > initialized in a way that they are seen as heavy tasks. And so even >> > for the first time they run, freq should

Re: [Eas-dev] [PATCH V4 0/3] sched: cpufreq: Allow remote callbacks

2017-07-27 Thread Juri Lelli
Hi, On 26/07/17 23:23, Joel Fernandes (Google) wrote: > Hi Viresh, > > On Wed, Jul 26, 2017 at 10:46 PM, Viresh Kumar > wrote: > > On 26-07-17, 22:14, Joel Fernandes (Google) wrote: [...] > > > > But even without that, if you see the routine > >

Re: [Eas-dev] [PATCH V4 0/3] sched: cpufreq: Allow remote callbacks

2017-07-27 Thread Juri Lelli
Hi, On 26/07/17 23:23, Joel Fernandes (Google) wrote: > Hi Viresh, > > On Wed, Jul 26, 2017 at 10:46 PM, Viresh Kumar > wrote: > > On 26-07-17, 22:14, Joel Fernandes (Google) wrote: [...] > > > > But even without that, if you see the routine > > init_entity_runnable_average() in fair.c, the

Re: [Eas-dev] [PATCH V4 0/3] sched: cpufreq: Allow remote callbacks

2017-07-27 Thread Viresh Kumar
On 26-07-17, 23:23, Joel Fernandes (Google) wrote: > Ok, but the "heavy" in init_entity_runnable_average means for load, > not the util_avg. The util_avg is what's used for frequency scaling > IIUC and is set to 0 in that function no? That's because the task isn't enqueued yet and so don't have

Re: [Eas-dev] [PATCH V4 0/3] sched: cpufreq: Allow remote callbacks

2017-07-27 Thread Viresh Kumar
On 26-07-17, 23:23, Joel Fernandes (Google) wrote: > Ok, but the "heavy" in init_entity_runnable_average means for load, > not the util_avg. The util_avg is what's used for frequency scaling > IIUC and is set to 0 in that function no? That's because the task isn't enqueued yet and so don't have

Re: [Eas-dev] [PATCH V4 0/3] sched: cpufreq: Allow remote callbacks

2017-07-27 Thread Joel Fernandes (Google)
Hi Viresh, On Wed, Jul 26, 2017 at 10:46 PM, Viresh Kumar wrote: > On 26-07-17, 22:14, Joel Fernandes (Google) wrote: >> Also one more comment about this usecase: >> >> You mentioned in our discussion at [2] sometime back, about the >> question of initial utilization,

Re: [Eas-dev] [PATCH V4 0/3] sched: cpufreq: Allow remote callbacks

2017-07-27 Thread Joel Fernandes (Google)
Hi Viresh, On Wed, Jul 26, 2017 at 10:46 PM, Viresh Kumar wrote: > On 26-07-17, 22:14, Joel Fernandes (Google) wrote: >> Also one more comment about this usecase: >> >> You mentioned in our discussion at [2] sometime back, about the >> question of initial utilization, >> >> "We don't have any

Re: [Eas-dev] [PATCH V4 0/3] sched: cpufreq: Allow remote callbacks

2017-07-26 Thread Viresh Kumar
On 26-07-17, 22:14, Joel Fernandes (Google) wrote: > I think you dropped [1] in your cover-letter. May be you meant to add > it at the end of the cover letter? > > I noticed from your v2 that its: > https://pastebin.com/7LkMSRxE Yeah, I missed it. Thanks :) > Also one more comment about this

Re: [Eas-dev] [PATCH V4 0/3] sched: cpufreq: Allow remote callbacks

2017-07-26 Thread Viresh Kumar
On 26-07-17, 22:14, Joel Fernandes (Google) wrote: > I think you dropped [1] in your cover-letter. May be you meant to add > it at the end of the cover letter? > > I noticed from your v2 that its: > https://pastebin.com/7LkMSRxE Yeah, I missed it. Thanks :) > Also one more comment about this

Re: [Eas-dev] [PATCH V4 0/3] sched: cpufreq: Allow remote callbacks

2017-07-26 Thread Joel Fernandes (Google)
Hi Viresh, On Wed, Jul 26, 2017 at 2:22 AM, Viresh Kumar wrote: > > With Android UI and benchmarks the latency of cpufreq response to > certain scheduling events can become very critical. Currently, callbacks > into schedutil are only made from the scheduler if the

Re: [Eas-dev] [PATCH V4 0/3] sched: cpufreq: Allow remote callbacks

2017-07-26 Thread Joel Fernandes (Google)
Hi Viresh, On Wed, Jul 26, 2017 at 2:22 AM, Viresh Kumar wrote: > > With Android UI and benchmarks the latency of cpufreq response to > certain scheduling events can become very critical. Currently, callbacks > into schedutil are only made from the scheduler if the target CPU of the > event is