Re: [External] [PATCH v2 2/5] hugetlb: convert page_huge_active() HPageMigratable flag

2021-02-03 Thread Mike Kravetz
On 2/2/21 11:42 PM, Muchun Song wrote: > On Wed, Jan 20, 2021 at 9:33 AM Mike Kravetz wrote: >> >> Signed-off-by: Mike Kravetz > > Hi Mike, > > I found that you may forget to remove set_page_huge_active() > from include/linux/hugetlb.h. > > diff --git a/include/linux/hugetlb.h b/include/linux/

Re: [External] [PATCH v2 2/5] hugetlb: convert page_huge_active() HPageMigratable flag

2021-02-02 Thread Muchun Song
On Wed, Jan 20, 2021 at 9:33 AM Mike Kravetz wrote: > > Use the new hugetlb page specific flag HPageMigratable to replace the > page_huge_active interfaces. By it's name, page_huge_active implied > that a huge page was on the active list. However, that is not really > what code checking the flag

Re: [External] [PATCH v2 2/5] hugetlb: convert page_huge_active() HPageMigratable flag

2021-01-21 Thread Muchun Song
On Wed, Jan 20, 2021 at 9:33 AM Mike Kravetz wrote: > > Use the new hugetlb page specific flag HPageMigratable to replace the > page_huge_active interfaces. By it's name, page_huge_active implied > that a huge page was on the active list. However, that is not really > what code checking the flag