Re: [External] Re: [PATCH] mm: memcontrol: Add the missing numa stat of anon and file for cgroup v2

2020-09-11 Thread Roman Gushchin
On Fri, Sep 11, 2020 at 11:51:42AM +0800, Muchun Song wrote: > On Fri, Sep 11, 2020 at 12:02 AM Shakeel Butt wrote: > > > > On Thu, Sep 10, 2020 at 1:46 AM Muchun Song > > wrote: > > > > > > In the cgroup v1, we have a numa_stat interface. This is useful for > > > providing visibility into the

Re: [External] Re: [PATCH] mm: memcontrol: Add the missing numa stat of anon and file for cgroup v2

2020-09-11 Thread Shakeel Butt
On Thu, Sep 10, 2020 at 8:52 PM Muchun Song wrote: > > On Fri, Sep 11, 2020 at 12:02 AM Shakeel Butt wrote: > > > > On Thu, Sep 10, 2020 at 1:46 AM Muchun Song > > wrote: > > > > > > In the cgroup v1, we have a numa_stat interface. This is useful for > > > providing visibility into the numa

Re: [External] Re: [PATCH] mm: memcontrol: Add the missing numa stat of anon and file for cgroup v2

2020-09-11 Thread Shakeel Butt
On Fri, Sep 11, 2020 at 8:48 AM Muchun Song wrote: > [snip] > > I got it, thanks. Because the "state" interface exposes the anon and > file information. So I think that we also should expose the anon and > file for "numa_stat" per node instead of the lru statistics. Maybe it is > better that we

Re: [External] Re: [PATCH] mm: memcontrol: Add the missing numa stat of anon and file for cgroup v2

2020-09-11 Thread Muchun Song
On Fri, Sep 11, 2020 at 10:55 PM Shakeel Butt wrote: > > On Thu, Sep 10, 2020 at 8:52 PM Muchun Song wrote: > > > > On Fri, Sep 11, 2020 at 12:02 AM Shakeel Butt wrote: > > > > > > On Thu, Sep 10, 2020 at 1:46 AM Muchun Song > > > wrote: > > > > > > > > In the cgroup v1, we have a numa_stat

Re: [External] Re: [PATCH] mm: memcontrol: Add the missing numa stat of anon and file for cgroup v2

2020-09-10 Thread Muchun Song
On Fri, Sep 11, 2020 at 12:02 AM Shakeel Butt wrote: > > On Thu, Sep 10, 2020 at 1:46 AM Muchun Song wrote: > > > > In the cgroup v1, we have a numa_stat interface. This is useful for > > providing visibility into the numa locality information within an > > memcg since the pages are allowed to