Re: [External] Re: [PATCH 5/5] mm: memcontrol: Simplify the mem_cgroup_page_lruvec

2020-10-27 Thread Muchun Song
On Tue, Oct 27, 2020 at 9:36 PM Michal Hocko wrote: > > On Tue 27-10-20 16:02:56, Muchun Song wrote: > > We can reuse the code of mem_cgroup_lruvec() to simplify the code > > of the mem_cgroup_page_lruvec(). > > yes, removing the code duplication is reasonable. But ... > > > > > Signed-off-by: Muc

Re: [External] Re: [PATCH 5/5] mm: memcontrol: Simplify the mem_cgroup_page_lruvec

2020-10-27 Thread Michal Hocko
On Tue 27-10-20 22:15:16, Muchun Song wrote: > On Tue, Oct 27, 2020 at 9:36 PM Michal Hocko wrote: > > > > On Tue 27-10-20 16:02:56, Muchun Song wrote: > > > We can reuse the code of mem_cgroup_lruvec() to simplify the code > > > of the mem_cgroup_page_lruvec(). > > > > yes, removing the code dupl