Re: [External] Re: [PATCH v2 4/6] mm: hugetlb: add return -EAGAIN for dissolve_free_huge_page

2021-01-07 Thread Michal Hocko
On Thu 07-01-21 17:01:16, Muchun Song wrote: > On Thu, Jan 7, 2021 at 4:39 PM Michal Hocko wrote: > > > > On Thu 07-01-21 11:11:41, Muchun Song wrote: > > > On Thu, Jan 7, 2021 at 1:07 AM Michal Hocko wrote: > > > > > > > > On Wed 06-01-21 16:47:37, Muchun Song wrote: > > > > > When dissolve_free

Re: [External] Re: [PATCH v2 4/6] mm: hugetlb: add return -EAGAIN for dissolve_free_huge_page

2021-01-07 Thread Muchun Song
On Thu, Jan 7, 2021 at 4:39 PM Michal Hocko wrote: > > On Thu 07-01-21 11:11:41, Muchun Song wrote: > > On Thu, Jan 7, 2021 at 1:07 AM Michal Hocko wrote: > > > > > > On Wed 06-01-21 16:47:37, Muchun Song wrote: > > > > When dissolve_free_huge_page() races with __free_huge_page(), we can > > > >

Re: [External] Re: [PATCH v2 4/6] mm: hugetlb: add return -EAGAIN for dissolve_free_huge_page

2021-01-07 Thread Michal Hocko
On Thu 07-01-21 11:11:41, Muchun Song wrote: > On Thu, Jan 7, 2021 at 1:07 AM Michal Hocko wrote: > > > > On Wed 06-01-21 16:47:37, Muchun Song wrote: > > > When dissolve_free_huge_page() races with __free_huge_page(), we can > > > do a retry. Because the race window is small. > > > > Is this a bu

Re: [External] Re: [PATCH v2 4/6] mm: hugetlb: add return -EAGAIN for dissolve_free_huge_page

2021-01-06 Thread Muchun Song
On Thu, Jan 7, 2021 at 1:07 AM Michal Hocko wrote: > > On Wed 06-01-21 16:47:37, Muchun Song wrote: > > When dissolve_free_huge_page() races with __free_huge_page(), we can > > do a retry. Because the race window is small. > > Is this a bug fix or mere optimization. I have hard time to tell from >