Re: [Fwd: 2.4.0-test12-pre7]

2000-12-07 Thread Alan Cox
> I think that Linus's patch is correct and that > pci/setup_res.c::pdev_enable_device() shouldn't be doing this: > > /* ??? Always turn on bus mastering. If the device doesn't support > it, the bit will go into the bucket. */ > cmd |= PCI_COMMAND_MASTER; > > First, the

[Fwd: 2.4.0-test12-pre7]

2000-12-07 Thread Randy Dunlap
> From: Russell King [mailto:[EMAIL PROTECTED]] > > Linus Torvalds writes: > > - me: UHCI drivers really need to enable bus mastering. > > But it'll already be turned on if pci_assign_unassigned_resources() is > called. This calls pdev_enable_device for every single device, which > turns

[Fwd: 2.4.0-test12-pre7]

2000-12-07 Thread Randy Dunlap
From: Russell King [mailto:[EMAIL PROTECTED]] Linus Torvalds writes: - me: UHCI drivers really need to enable bus mastering. But it'll already be turned on if pci_assign_unassigned_resources() is called. This calls pdev_enable_device for every single device, which turns on the bus

Re: [Fwd: 2.4.0-test12-pre7]

2000-12-07 Thread Alan Cox
I think that Linus's patch is correct and that pci/setup_res.c::pdev_enable_device() shouldn't be doing this: /* ??? Always turn on bus mastering. If the device doesn't support it, the bit will go into the bucket. */ cmd |= PCI_COMMAND_MASTER; First, the ??? makes