Re: [GIT PULL] Btrfs deadlock fix

2014-11-24 Thread David Sterba
On Mon, Nov 24, 2014 at 01:01:10PM -0500, Chris Mason wrote: > > I've retested it again including this pull and still deadlocks > > reliably > > at btrfs/070. > > This wasn't a new problem, so I had it queued for the merge window. Well, I don't remember seeing this problem with anything 3.17

Re: [GIT PULL] Btrfs deadlock fix

2014-11-24 Thread Chris Mason
On Mon, Nov 24, 2014 at 12:39 PM, David Sterba wrote: Hi Chris, I thought the fix for the scrub/replace deadlock would be included in this pull, I can reproduce it on each run of xfstests with 3.18-rc. btrfs: fix dead lock while running replace and defrag concurrently

Re: [GIT PULL] Btrfs deadlock fix

2014-11-24 Thread David Sterba
Hi Chris, I thought the fix for the scrub/replace deadlock would be included in this pull, I can reproduce it on each run of xfstests with 3.18-rc. btrfs: fix dead lock while running replace and defrag concurrently https://patchwork.kernel.org/patch/5264531/ I've retested it again including

Re: [GIT PULL] Btrfs deadlock fix

2014-11-24 Thread David Sterba
Hi Chris, I thought the fix for the scrub/replace deadlock would be included in this pull, I can reproduce it on each run of xfstests with 3.18-rc. btrfs: fix dead lock while running replace and defrag concurrently https://patchwork.kernel.org/patch/5264531/ I've retested it again including

Re: [GIT PULL] Btrfs deadlock fix

2014-11-24 Thread Chris Mason
On Mon, Nov 24, 2014 at 12:39 PM, David Sterba dste...@suse.cz wrote: Hi Chris, I thought the fix for the scrub/replace deadlock would be included in this pull, I can reproduce it on each run of xfstests with 3.18-rc. btrfs: fix dead lock while running replace and defrag concurrently

Re: [GIT PULL] Btrfs deadlock fix

2014-11-24 Thread David Sterba
On Mon, Nov 24, 2014 at 01:01:10PM -0500, Chris Mason wrote: I've retested it again including this pull and still deadlocks reliably at btrfs/070. This wasn't a new problem, so I had it queued for the merge window. Well, I don't remember seeing this problem with anything 3.17 based but

Re: [GIT PULL] Btrfs deadlock fix

2014-11-23 Thread Benjamin Herrenschmidt
On Sun, 2014-11-23 at 19:27 -0500, Chris Mason wrote: > This should be from CONFIG_BTRFS_FS_RUN_SANITY_TESTS=y. I do test > with this on here, but I'll look it over for ppc related fun. > > The deadlock fix from this pull shouldn't be related. Just to make > sure I read your email right, this

Re: [GIT PULL] Btrfs deadlock fix

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 7:23 PM, Benjamin Herrenschmidt wrote: On Sun, 2014-11-23 at 10:14 -0500, Chris Mason wrote: Hi Linus, My for-linus branch: Not sure if this is related, but with -rc4, on this ppc64el box, when grub updates (it starts trying to mount everything under the sun

Re: [GIT PULL] Btrfs deadlock fix

2014-11-23 Thread Benjamin Herrenschmidt
On Sun, 2014-11-23 at 10:14 -0500, Chris Mason wrote: > Hi Linus, > > My for-linus branch: Not sure if this is related, but with -rc4, on this ppc64el box, when grub updates (it starts trying to mount everything under the sun with every filesystem), the box hangs with: [ 177.344522] INFO:

[GIT PULL] Btrfs deadlock fix

2014-11-23 Thread Chris Mason
Hi Linus, My for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Has a fix for a long standing deadlock that we've been trying to nail down for a while. It ended up being a bad interaction with the fair reader/writer locks and the order btrfs

[GIT PULL] Btrfs deadlock fix

2014-11-23 Thread Chris Mason
Hi Linus, My for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Has a fix for a long standing deadlock that we've been trying to nail down for a while. It ended up being a bad interaction with the fair reader/writer locks and the order btrfs

Re: [GIT PULL] Btrfs deadlock fix

2014-11-23 Thread Benjamin Herrenschmidt
On Sun, 2014-11-23 at 10:14 -0500, Chris Mason wrote: Hi Linus, My for-linus branch: Not sure if this is related, but with -rc4, on this ppc64el box, when grub updates (it starts trying to mount everything under the sun with every filesystem), the box hangs with: [ 177.344522] INFO:

Re: [GIT PULL] Btrfs deadlock fix

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 7:23 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Sun, 2014-11-23 at 10:14 -0500, Chris Mason wrote: Hi Linus, My for-linus branch: Not sure if this is related, but with -rc4, on this ppc64el box, when grub updates (it starts trying to mount

Re: [GIT PULL] Btrfs deadlock fix

2014-11-23 Thread Benjamin Herrenschmidt
On Sun, 2014-11-23 at 19:27 -0500, Chris Mason wrote: This should be from CONFIG_BTRFS_FS_RUN_SANITY_TESTS=y. I do test with this on here, but I'll look it over for ppc related fun. The deadlock fix from this pull shouldn't be related. Just to make sure I read your email right, this stall