Re: [GIT PULL] EDAC fixes for 3.8

2013-03-12 Thread Mauro Carvalho Chehab
Em Tue, 12 Mar 2013 12:56:32 +0100 Borislav Petkov escreveu: > On Tue, Mar 12, 2013 at 08:34:48AM -0300, Mauro Carvalho Chehab wrote: > > Looks ok on my eyes. I'll test it here on both systems, with both this > > patch and the second one: > > > >

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-12 Thread Borislav Petkov
On Tue, Mar 12, 2013 at 08:34:48AM -0300, Mauro Carvalho Chehab wrote: > Looks ok on my eyes. I'll test it here on both systems, with both this > patch and the second one: > > http://git.infradead.org/users/mchehab/edac.git/commitdiff/56ba4c93d909ef9dfab4f1101a8c3bf75bc4cdab > > It should take

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-12 Thread Mauro Carvalho Chehab
Em Tue, 12 Mar 2013 10:16:30 +0100 Borislav Petkov escreveu: > Btw, > > the first one I changed to not divide by the channel_count, see below. > Now I'll go and run them to check everything's fine. Looks ok on my eyes. I'll test it here on both systems, with both this patch and the second one:

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-12 Thread Mauro Carvalho Chehab
Em Mon, 11 Mar 2013 21:43:03 +0100 Borislav Petkov escreveu: > On Mon, Mar 11, 2013 at 05:08:37PM -0300, Mauro Carvalho Chehab wrote: > > While this machine is reserved for my usage, do you need a different > > test on it? > > Yes please. Can you send dmesg and sysfs entries before applying

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-12 Thread Mauro Carvalho Chehab
Em Tue, 12 Mar 2013 09:58:55 +0100 Borislav Petkov escreveu: > On Mon, Mar 11, 2013 at 09:28:48AM -0300, Mauro Carvalho Chehab wrote: > > @@ -740,7 +740,6 @@ struct mem_ctl_info { > > u32 fake_inject_ue; > > u16 fake_inject_count; > > #endif > > - __u8 csbased : 1, /*

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-12 Thread Borislav Petkov
Btw, the first one I changed to not divide by the channel_count, see below. Now I'll go and run them to check everything's fine. Thanks. >From ef11e0b3e22d19f06474ced9365c69a0353f793a Mon Sep 17 00:00:00 2001 From: Mauro Carvalho Chehab Date: Mon, 11 Mar 2013 09:07:46 -0300 Subject: [PATCH

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-12 Thread Borislav Petkov
On Mon, Mar 11, 2013 at 09:28:48AM -0300, Mauro Carvalho Chehab wrote: > @@ -740,7 +740,6 @@ struct mem_ctl_info { > u32 fake_inject_ue; > u16 fake_inject_count; > #endif > - __u8 csbased : 1, /* csrow-based memory controller */ >__resv : 7; I don't know how

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-12 Thread Borislav Petkov
On Mon, Mar 11, 2013 at 09:28:48AM -0300, Mauro Carvalho Chehab wrote: @@ -740,7 +740,6 @@ struct mem_ctl_info { u32 fake_inject_ue; u16 fake_inject_count; #endif - __u8 csbased : 1, /* csrow-based memory controller */ __resv : 7; I don't know how you

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-12 Thread Borislav Petkov
Btw, the first one I changed to not divide by the channel_count, see below. Now I'll go and run them to check everything's fine. Thanks. From ef11e0b3e22d19f06474ced9365c69a0353f793a Mon Sep 17 00:00:00 2001 From: Mauro Carvalho Chehab mche...@redhat.com Date: Mon, 11 Mar 2013 09:07:46 -0300

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-12 Thread Mauro Carvalho Chehab
Em Tue, 12 Mar 2013 09:58:55 +0100 Borislav Petkov b...@alien8.de escreveu: On Mon, Mar 11, 2013 at 09:28:48AM -0300, Mauro Carvalho Chehab wrote: @@ -740,7 +740,6 @@ struct mem_ctl_info { u32 fake_inject_ue; u16 fake_inject_count; #endif - __u8 csbased : 1, /*

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-12 Thread Mauro Carvalho Chehab
Em Mon, 11 Mar 2013 21:43:03 +0100 Borislav Petkov b...@alien8.de escreveu: On Mon, Mar 11, 2013 at 05:08:37PM -0300, Mauro Carvalho Chehab wrote: While this machine is reserved for my usage, do you need a different test on it? Yes please. Can you send dmesg and sysfs entries before

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-12 Thread Mauro Carvalho Chehab
Em Tue, 12 Mar 2013 10:16:30 +0100 Borislav Petkov b...@alien8.de escreveu: Btw, the first one I changed to not divide by the channel_count, see below. Now I'll go and run them to check everything's fine. Looks ok on my eyes. I'll test it here on both systems, with both this patch and the

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-12 Thread Borislav Petkov
On Tue, Mar 12, 2013 at 08:34:48AM -0300, Mauro Carvalho Chehab wrote: Looks ok on my eyes. I'll test it here on both systems, with both this patch and the second one: http://git.infradead.org/users/mchehab/edac.git/commitdiff/56ba4c93d909ef9dfab4f1101a8c3bf75bc4cdab It should take some

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-12 Thread Mauro Carvalho Chehab
Em Tue, 12 Mar 2013 12:56:32 +0100 Borislav Petkov b...@alien8.de escreveu: On Tue, Mar 12, 2013 at 08:34:48AM -0300, Mauro Carvalho Chehab wrote: Looks ok on my eyes. I'll test it here on both systems, with both this patch and the second one:

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-11 Thread Borislav Petkov
On Mon, Mar 11, 2013 at 05:08:37PM -0300, Mauro Carvalho Chehab wrote: > While this machine is reserved for my usage, do you need a different > test on it? Yes please. Can you send dmesg and sysfs entries before applying your patches? Thanks. -- Regards/Gruss, Boris. Sent from a fat crate

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-11 Thread Mauro Carvalho Chehab
Hi Boris, Em Mon, 11 Mar 2013 15:31:38 +0100 Borislav Petkov escreveu: > On Mon, Mar 11, 2013 at 11:12:15AM -0300, Mauro Carvalho Chehab wrote: > > Ok, I'll test it on a K8 box at RH. > > > > The bug seems to be on K8 rev F, right? Is there a different PCI ID on > > those machines? That would

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-11 Thread Borislav Petkov
On Mon, Mar 11, 2013 at 11:12:15AM -0300, Mauro Carvalho Chehab wrote: > Ok, I'll test it on a K8 box at RH. > > The bug seems to be on K8 rev F, right? Is there a different PCI ID on > those machines? That would help me to quickly find such machine on at > RH labs. K8 revF should be a good

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-11 Thread Mauro Carvalho Chehab
Em Mon, 11 Mar 2013 14:48:14 +0100 Borislav Petkov escreveu: > On Mon, Mar 11, 2013 at 09:28:48AM -0300, Mauro Carvalho Chehab wrote: > > With this patch, mci->csbased field got unused. So, it makes sense to > > also remove it. The enclosed patch does that. > > AFAIR, this whole fixing was done

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-11 Thread Borislav Petkov
On Mon, Mar 11, 2013 at 09:28:48AM -0300, Mauro Carvalho Chehab wrote: > With this patch, mci->csbased field got unused. So, it makes sense to > also remove it. The enclosed patch does that. AFAIR, this whole fixing was done for K8 as reported by Josh Hunt from Akamai:

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-11 Thread Mauro Carvalho Chehab
Em Mon, 11 Mar 2013 09:07:46 -0300 Mauro Carvalho Chehab escreveu: > Em Sat, 9 Mar 2013 16:46:35 +0100 > Borislav Petkov escreveu: > > > On Thu, Mar 07, 2013 at 11:02:13AM -0300, Mauro Carvalho Chehab wrote: > > > Sure. See below: > > > ... > > So, actually to satisfy the new api, you'll

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-11 Thread Mauro Carvalho Chehab
Em Sat, 9 Mar 2013 16:46:35 +0100 Borislav Petkov escreveu: > On Thu, Mar 07, 2013 at 11:02:13AM -0300, Mauro Carvalho Chehab wrote: > > Sure. See below: > > > > [ 19.062902] EDAC MC: Ver: 3.0.0 > > [ 19.088757] EDAC DEBUG: edac_mc_sysfs_init: device mc created > > [ 19.284745] AMD64 EDAC

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-11 Thread Mauro Carvalho Chehab
Em Sat, 9 Mar 2013 16:46:35 +0100 Borislav Petkov b...@alien8.de escreveu: On Thu, Mar 07, 2013 at 11:02:13AM -0300, Mauro Carvalho Chehab wrote: Sure. See below: [ 19.062902] EDAC MC: Ver: 3.0.0 [ 19.088757] EDAC DEBUG: edac_mc_sysfs_init: device mc created [ 19.284745] AMD64

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-11 Thread Mauro Carvalho Chehab
Em Mon, 11 Mar 2013 09:07:46 -0300 Mauro Carvalho Chehab mche...@redhat.com escreveu: Em Sat, 9 Mar 2013 16:46:35 +0100 Borislav Petkov b...@alien8.de escreveu: On Thu, Mar 07, 2013 at 11:02:13AM -0300, Mauro Carvalho Chehab wrote: Sure. See below: ... So, actually to satisfy the

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-11 Thread Borislav Petkov
On Mon, Mar 11, 2013 at 09:28:48AM -0300, Mauro Carvalho Chehab wrote: With this patch, mci-csbased field got unused. So, it makes sense to also remove it. The enclosed patch does that. AFAIR, this whole fixing was done for K8 as reported by Josh Hunt from Akamai:

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-11 Thread Mauro Carvalho Chehab
Em Mon, 11 Mar 2013 14:48:14 +0100 Borislav Petkov b...@alien8.de escreveu: On Mon, Mar 11, 2013 at 09:28:48AM -0300, Mauro Carvalho Chehab wrote: With this patch, mci-csbased field got unused. So, it makes sense to also remove it. The enclosed patch does that. AFAIR, this whole fixing

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-11 Thread Borislav Petkov
On Mon, Mar 11, 2013 at 11:12:15AM -0300, Mauro Carvalho Chehab wrote: Ok, I'll test it on a K8 box at RH. The bug seems to be on K8 rev F, right? Is there a different PCI ID on those machines? That would help me to quickly find such machine on at RH labs. K8 revF should be a good choice,

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-11 Thread Mauro Carvalho Chehab
Hi Boris, Em Mon, 11 Mar 2013 15:31:38 +0100 Borislav Petkov b...@alien8.de escreveu: On Mon, Mar 11, 2013 at 11:12:15AM -0300, Mauro Carvalho Chehab wrote: Ok, I'll test it on a K8 box at RH. The bug seems to be on K8 rev F, right? Is there a different PCI ID on those machines? That

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-11 Thread Borislav Petkov
On Mon, Mar 11, 2013 at 05:08:37PM -0300, Mauro Carvalho Chehab wrote: While this machine is reserved for my usage, do you need a different test on it? Yes please. Can you send dmesg and sysfs entries before applying your patches? Thanks. -- Regards/Gruss, Boris. Sent from a fat crate

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-09 Thread Borislav Petkov
On Thu, Mar 07, 2013 at 11:02:13AM -0300, Mauro Carvalho Chehab wrote: > Sure. See below: > > [ 19.062902] EDAC MC: Ver: 3.0.0 > [ 19.088757] EDAC DEBUG: edac_mc_sysfs_init: device mc created > [ 19.284745] AMD64 EDAC driver v3.4.0 > [ 19.299082] EDAC amd64: DRAM ECC enabled. > [

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-09 Thread Borislav Petkov
On Thu, Mar 07, 2013 at 11:02:13AM -0300, Mauro Carvalho Chehab wrote: Sure. See below: [ 19.062902] EDAC MC: Ver: 3.0.0 [ 19.088757] EDAC DEBUG: edac_mc_sysfs_init: device mc created [ 19.284745] AMD64 EDAC driver v3.4.0 [ 19.299082] EDAC amd64: DRAM ECC enabled. [ 19.315960]

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-07 Thread Mauro Carvalho Chehab
Em Thu, 7 Mar 2013 14:06:35 +0100 Borislav Petkov escreveu: > On Thu, Mar 07, 2013 at 09:57:03AM -0300, Mauro Carvalho Chehab wrote: > > After running my edac testbanch on an AMD64 machine, populated > > with 4 DIMMS, each being a 4GB QUAD-rank DIMMs, the EDAC driver > > reported 4 different

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-07 Thread Borislav Petkov
On Thu, Mar 07, 2013 at 09:57:03AM -0300, Mauro Carvalho Chehab wrote: > After running my edac testbanch on an AMD64 machine, populated > with 4 DIMMS, each being a 4GB QUAD-rank DIMMs, the EDAC driver > reported 4 different memory configurations ;) Can you please enable CONFIG_EDAC_DEBUG and

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-07 Thread Borislav Petkov
On Thu, Mar 07, 2013 at 09:57:03AM -0300, Mauro Carvalho Chehab wrote: After running my edac testbanch on an AMD64 machine, populated with 4 DIMMS, each being a 4GB QUAD-rank DIMMs, the EDAC driver reported 4 different memory configurations ;) Can you please enable CONFIG_EDAC_DEBUG and send

Re: [GIT PULL] EDAC fixes for 3.8

2013-03-07 Thread Mauro Carvalho Chehab
Em Thu, 7 Mar 2013 14:06:35 +0100 Borislav Petkov b...@alien8.de escreveu: On Thu, Mar 07, 2013 at 09:57:03AM -0300, Mauro Carvalho Chehab wrote: After running my edac testbanch on an AMD64 machine, populated with 4 DIMMS, each being a 4GB QUAD-rank DIMMs, the EDAC driver reported 4

[GIT PULL] EDAC fixes for 3.8

2013-01-08 Thread Borislav Petkov
Hi Linus, please pull the 3 fixes below. Thanks. The following changes since commit d1c3ed669a2d452cacfb48c2d171a1f364dae2ed: Linux 3.8-rc2 (2013-01-02 18:13:21 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git tags/edac_fixes_for_3.8

[GIT PULL] EDAC fixes for 3.8

2013-01-08 Thread Borislav Petkov
Hi Linus, please pull the 3 fixes below. Thanks. The following changes since commit d1c3ed669a2d452cacfb48c2d171a1f364dae2ed: Linux 3.8-rc2 (2013-01-02 18:13:21 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git tags/edac_fixes_for_3.8

[GIT PULL] EDAC fixes for 3.8

2012-12-11 Thread Borislav Petkov
Hi Linus, please pull the 'for-linus' branch below to receive the following changes to EDAC: * EDAC core error path fix, from Denis Kirjanov. * Generalization of AMD MCE bank names and some minor error reporting improvements. * EDAC core cleanups and simplifications, from Wei Yongjun. *

[GIT PULL] EDAC fixes for 3.8

2012-12-11 Thread Borislav Petkov
Hi Linus, please pull the 'for-linus' branch below to receive the following changes to EDAC: * EDAC core error path fix, from Denis Kirjanov. * Generalization of AMD MCE bank names and some minor error reporting improvements. * EDAC core cleanups and simplifications, from Wei Yongjun. *