On Sun, Sep 22, 2019 at 8:26 PM Ingo Molnar wrote:
>
>
> * Linus Torvalds wrote:
>
> > On Fri, Sep 20, 2019 at 9:35 AM Brendan Higgins
> > wrote:
> > >
> > > Sorry about that. I am surprised that none of the other reviewers
> > > brought this up.
> >
> > I think I'm "special".
> >
> > There was
Hi!
> > I think I'm "special".
> >
> > There was some other similar change a few years ago, which I
> > absolutely hated because of how it broke autocomplete for me. Very few
> > other people seemed to react to it.
>
> FWIW, I am obsessively sensitive to autocomplete and overall source code
>
The pull request you sent on Mon, 23 Sep 2019 16:40:15 -0600:
> git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
> tags/linux-kselftest-5.4-rc1.1
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/797a3242755da1b7c1ada6fb153cb2700ef30a80
Thank you!
On Sun, Sep 22, 2019 at 01:25:55PM +0200, Ingo Molnar wrote:
>
> * Linus Torvalds wrote:
>
> > On Fri, Sep 20, 2019 at 9:35 AM Brendan Higgins
> > wrote:
> > >
> > > Sorry about that. I am surprised that none of the other reviewers
> > > brought this up.
> >
> > I think I'm "special".
> >
>
Hi Linus,
Please pull the following Kselftest update for Linux 5.4-rc1 (minus kunit).
This Kselftest update for Linux 5.4-rc1 consists of several fixes to
existing tests.
diff is attached.
This pull has just the ksleftest patches I sent in my previous pull
request. I dropped the KUnit patches
* tim.b...@sony.com wrote:
> > -Original Message-
> > From: Ingo Molnar on Sunday, September 22, 2019 1:26 AM
> >
> > * Linus Torvalds wrote:
> >
> > > On Fri, Sep 20, 2019 at 9:35 AM Brendan Higgins
> > > wrote:
> > > >
> > > > Sorry about that. I am surprised that none of the
> -Original Message-
> From: Ingo Molnar on Sunday, September 22, 2019 1:26 AM
>
> * Linus Torvalds wrote:
>
> > On Fri, Sep 20, 2019 at 9:35 AM Brendan Higgins
> > wrote:
> > >
> > > Sorry about that. I am surprised that none of the other reviewers
> > > brought this up.
> >
> > I
Hi Linus,
Please pull the following Kselftest update for Linux 5.4-rc1.
This Kselftest update for Linux 5.4-rc1 consists of several fixes to
existing tests.
diff is attached.
This pull has just the ksleftest patches I sent in my previous pull
request. I dropped the KUnit patches and rebased.
On 9/23/19 2:53 PM, Ingo Molnar wrote:
* Shuah Khan wrote:
Right. What you suggesting is very similar to and more complete than
what I have been thinking about and proposed at the KS kselftest track.
i.e move tools/testing/selftests to kselftest at the root level. I like
your idea of moving
* Shuah Khan wrote:
> Right. What you suggesting is very similar to and more complete than
> what I have been thinking about and proposed at the KS kselftest track.
>
> i.e move tools/testing/selftests to kselftest at the root level. I like
> your idea of moving tools/testing up to root and
On 9/23/19 1:52 PM, Randy Dunlap wrote:
On 9/23/19 12:43 PM, Ingo Molnar wrote:
* Shuah Khan wrote:
I am exploring the possibility to move selftests to a better location
or add a git alias so it can be found easily. With the addition of
KUnit and future work that is planned to connect
On 9/23/19 12:43 PM, Ingo Molnar wrote:
>
> * Shuah Khan wrote:
>
>> I am exploring the possibility to move selftests to a better location
>> or add a git alias so it can be found easily. With the addition of
>> KUnit and future work that is planned to connect kselftest and KUnit,
>> it
* Shuah Khan wrote:
> I am exploring the possibility to move selftests to a better location
> or add a git alias so it can be found easily. With the addition of
> KUnit and future work that is planned to connect kselftest and KUnit,
> it would make sense have selftests to be in a location
On 9/22/19 5:52 AM, Greg KH wrote:
On Sun, Sep 22, 2019 at 01:25:55PM +0200, Ingo Molnar wrote:
* Linus Torvalds wrote:
On Fri, Sep 20, 2019 at 9:35 AM Brendan Higgins
wrote:
Sorry about that. I am surprised that none of the other reviewers
brought this up.
I think I'm "special".
> Beyond the muscle memory aspect, nonsensical naming and inanely flat file
> hierarchies annoy kernel developers
Flat(ish) file hierarchies are good -- less typing.
If you're copy-pasting then it doesn't matter much (it still matters a
little because long filename occupy more space on the screen
On Sun, Sep 22, 2019 at 01:25:55PM +0200, Ingo Molnar wrote:
>
> * Linus Torvalds wrote:
>
> > On Fri, Sep 20, 2019 at 9:35 AM Brendan Higgins
> > wrote:
> > >
> > > Sorry about that. I am surprised that none of the other reviewers
> > > brought this up.
> >
> > I think I'm "special".
> >
>
* Linus Torvalds wrote:
> On Fri, Sep 20, 2019 at 9:35 AM Brendan Higgins
> wrote:
> >
> > Sorry about that. I am surprised that none of the other reviewers
> > brought this up.
>
> I think I'm "special".
>
> There was some other similar change a few years ago, which I
> absolutely hated
On Fri, Sep 20, 2019 at 11:15 AM Linus Torvalds
wrote:
>
> On Fri, Sep 20, 2019 at 11:03 AM Brendan Higgins
> wrote:
> >
> > Fair enough. On that note, are you okay with the `include/kunit/`
> > directory, or do you want me to move it to `include/linux/kunit`?
>
> "include/kunit" should work
On Fri, Sep 20, 2019 at 11:03 AM Brendan Higgins
wrote:
>
> Fair enough. On that note, are you okay with the `include/kunit/`
> directory, or do you want me to move it to `include/linux/kunit`?
"include/kunit" should work just fine for me. At least I didn't react
to it immediately when I had
On 9/20/19 10:51 AM, Linus Torvalds wrote:
On Fri, Sep 20, 2019 at 9:35 AM Brendan Higgins
wrote:
Sorry about that. I am surprised that none of the other reviewers
brought this up.
I think I'm "special".
There was some other similar change a few years ago, which I
absolutely hated because
On Fri, Sep 20, 2019 at 9:51 AM Linus Torvalds
wrote:
>
> On Fri, Sep 20, 2019 at 9:35 AM Brendan Higgins
> wrote:
> >
> > Sorry about that. I am surprised that none of the other reviewers
> > brought this up.
>
> I think I'm "special".
Heh.
> There was some other similar change a few years
On Fri, Sep 20, 2019 at 9:35 AM Brendan Higgins
wrote:
>
> Sorry about that. I am surprised that none of the other reviewers
> brought this up.
I think I'm "special".
There was some other similar change a few years ago, which I
absolutely hated because of how it broke autocomplete for me. Very
On Fri, Sep 20, 2019 at 9:27 AM Shuah Khan wrote:
>
> Hi Linus,
>
> On Fri, Sep 20, 2019, 10:18 AM Linus Torvalds
> wrote:
>>
>> On Tue, Sep 17, 2019 at 12:26 PM Shuah Khan
>> wrote:
>> >
>> > This Kselftest update for Linux 5.4-rc1 consists of several fixes to
>> > existing tests and adds
On 9/20/19 9:17 AM, Linus Torvalds wrote:
> On Tue, Sep 17, 2019 at 12:26 PM Shuah Khan wrote:
>>
>> This Kselftest update for Linux 5.4-rc1 consists of several fixes to
>> existing tests and adds KUnit, a lightweight unit testing and mocking
>> framework for the Linux kernel from Brendan
On Tue, Sep 17, 2019 at 12:26 PM Shuah Khan wrote:
>
> This Kselftest update for Linux 5.4-rc1 consists of several fixes to
> existing tests and adds KUnit, a lightweight unit testing and mocking
> framework for the Linux kernel from Brendan Higgins.
So I pulled this, but then I almost
25 matches
Mail list logo
