Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-13 Thread Linus Torvalds
On Mon, Jun 13, 2016 at 12:04 AM, Hannes Reinecke wrote: > > And we have been running the very patch in SLES for over a year now, > without a single issue being reported. Oh, ok. So it's not "all qemu kvm instances are broken", it was a very unusual issue, and the patch has

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-13 Thread Linus Torvalds
On Mon, Jun 13, 2016 at 12:04 AM, Hannes Reinecke wrote: > > And we have been running the very patch in SLES for over a year now, > without a single issue being reported. Oh, ok. So it's not "all qemu kvm instances are broken", it was a very unusual issue, and the patch has actually gotten wider

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-13 Thread Hannes Reinecke
On 06/11/2016 11:03 PM, James Bottomley wrote: > On Sat, 2016-06-11 at 13:25 -0700, Linus Torvalds wrote: >> On Sat, Jun 11, 2016 at 12:41 PM, James Bottomley >> wrote: >>> >>> The QEMU people have accepted it as their bug and are fixing it. >> >> Of course

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-13 Thread Hannes Reinecke
On 06/11/2016 11:03 PM, James Bottomley wrote: > On Sat, 2016-06-11 at 13:25 -0700, Linus Torvalds wrote: >> On Sat, Jun 11, 2016 at 12:41 PM, James Bottomley >> wrote: >>> >>> The QEMU people have accepted it as their bug and are fixing it. >> >> Of course they are. Somebody found a bug in their

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread James Bottomley
On Sat, 2016-06-11 at 13:25 -0700, Linus Torvalds wrote: > On Sat, Jun 11, 2016 at 12:41 PM, James Bottomley > wrote: > > > > The QEMU people have accepted it as their bug and are fixing it. > > Of course they are. Somebody found a bug in their device

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread James Bottomley
On Sat, 2016-06-11 at 13:25 -0700, Linus Torvalds wrote: > On Sat, Jun 11, 2016 at 12:41 PM, James Bottomley > wrote: > > > > The QEMU people have accepted it as their bug and are fixing it. > > Of course they are. Somebody found a bug in their device model, I'd > expect nothing else. > > But

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread James Bottomley
On Sat, 2016-06-11 at 12:57 -0700, Linus Torvalds wrote: > On Sat, Jun 11, 2016 at 12:41 PM, James Bottomley > wrote: > > > > It looks like there's a hole where the emulation should be for the > > VPD > > inquiry, which is what cause the whole hang up and

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread James Bottomley
On Sat, 2016-06-11 at 12:57 -0700, Linus Torvalds wrote: > On Sat, Jun 11, 2016 at 12:41 PM, James Bottomley > wrote: > > > > It looks like there's a hole where the emulation should be for the > > VPD > > inquiry, which is what cause the whole hang up and never speak to > > us > > again problem.

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread Linus Torvalds
On Sat, Jun 11, 2016 at 12:41 PM, James Bottomley wrote: > > The QEMU people have accepted it as their bug and are fixing it. Of course they are. Somebody found a bug in their device model, I'd expect nothing else. But I'm not worried about qemu. I'm

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread Linus Torvalds
On Sat, Jun 11, 2016 at 12:41 PM, James Bottomley wrote: > > The QEMU people have accepted it as their bug and are fixing it. Of course they are. Somebody found a bug in their device model, I'd expect nothing else. But I'm not worried about qemu. I'm worried about all the other random devices

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread Linus Torvalds
On Sat, Jun 11, 2016 at 12:41 PM, James Bottomley wrote: > > It looks like there's a hole where the emulation should be for the VPD > inquiry, which is what cause the whole hang up and never speak to us > again problem. So? What makes you think real

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread Linus Torvalds
On Sat, Jun 11, 2016 at 12:41 PM, James Bottomley wrote: > > It looks like there's a hole where the emulation should be for the VPD > inquiry, which is what cause the whole hang up and never speak to us > again problem. So? What makes you think real hardware doesn't have those kinds of issues?

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread James Bottomley
On Sat, 2016-06-11 at 12:12 -0700, Linus Torvalds wrote: > On Sat, Jun 11, 2016 at 11:54 AM, Linus Torvalds > wrote: > > > > Is there some reason to believe that the qemu CD-ROM emulation is > > the only one with this problem? > > Side note:the one thing that

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread James Bottomley
On Sat, 2016-06-11 at 12:12 -0700, Linus Torvalds wrote: > On Sat, Jun 11, 2016 at 11:54 AM, Linus Torvalds > wrote: > > > > Is there some reason to believe that the qemu CD-ROM emulation is > > the only one with this problem? > > Side note:the one thing that makes the qemu cd-rom emulator

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread James Bottomley
On Sat, 2016-06-11 at 11:54 -0700, Linus Torvalds wrote: > On Sat, Jun 11, 2016 at 11:09 AM, James Bottomley > wrote: > > Two current fixes: one affects Qemu CD ROM emulation, which stopped > > working after the updates in SCSI to require VPD pages from all

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread James Bottomley
On Sat, 2016-06-11 at 11:54 -0700, Linus Torvalds wrote: > On Sat, Jun 11, 2016 at 11:09 AM, James Bottomley > wrote: > > Two current fixes: one affects Qemu CD ROM emulation, which stopped > > working after the updates in SCSI to require VPD pages from all > > conformant devices. Fix

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread Linus Torvalds
On Sat, Jun 11, 2016 at 11:54 AM, Linus Torvalds wrote: > > Is there some reason to believe that the qemu CD-ROM emulation is the > only one with this problem? Side note:the one thing that makes the qemu cd-rom emulator "special" is not that it's not real hardware:

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread Linus Torvalds
On Sat, Jun 11, 2016 at 11:54 AM, Linus Torvalds wrote: > > Is there some reason to believe that the qemu CD-ROM emulation is the > only one with this problem? Side note:the one thing that makes the qemu cd-rom emulator "special" is not that it's not real hardware: it's that it's a lot more

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread Linus Torvalds
On Sat, Jun 11, 2016 at 11:09 AM, James Bottomley wrote: > Two current fixes: one affects Qemu CD ROM emulation, which stopped > working after the updates in SCSI to require VPD pages from all > conformant devices. Fix temporarily by blacklisting Qemu (we

Re: [GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread Linus Torvalds
On Sat, Jun 11, 2016 at 11:09 AM, James Bottomley wrote: > Two current fixes: one affects Qemu CD ROM emulation, which stopped > working after the updates in SCSI to require VPD pages from all > conformant devices. Fix temporarily by blacklisting Qemu (we can relax > later when they come into

[GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread James Bottomley
Two current fixes: one affects Qemu CD ROM emulation, which stopped working after the updates in SCSI to require VPD pages from all conformant devices. Fix temporarily by blacklisting Qemu (we can relax later when they come into compliance). The other is a fix to the optimal transfer size. We

[GIT PULL] SCSI fixes for 4.7-rc2

2016-06-11 Thread James Bottomley
Two current fixes: one affects Qemu CD ROM emulation, which stopped working after the updates in SCSI to require VPD pages from all conformant devices. Fix temporarily by blacklisting Qemu (we can relax later when they come into compliance). The other is a fix to the optimal transfer size. We