On Sat, Mar 26, 2016 at 01:48:23PM -0700, Linus Torvalds wrote:
> > BTW, as far as switching ext4 to use the shared code in fs/crypto ---
> > I'm hoping to get that done for the next merge window. There are a 2
> > or 3 patches to fix some recently discovered bugs that I'll need to
> > push into t
On Sat, Mar 26, 2016 at 1:41 PM, Theodore Ts'o wrote:
>
>> I also wonder if the xts_tweak should perhaps have both the page
>> offset _and_ the inode number in it. Both ext4 and f2fs specify that
>> xts tweak size to be 16 bytes, and right now fill the last 8 bytes
>> with zero. Would it make sens
On Sat, Mar 26, 2016 at 10:53:52AM -0700, Linus Torvalds wrote:
> On Sat, Mar 26, 2016 at 6:47 AM, Eric Biggers wrote:
> > Another question about the choice of IV. If the page index in CPU order is
> > (supposed to be) used as the IV, doesn't make the on-disk format of the
> > filesystem endianne
On Sat, Mar 26, 2016 at 01:04:44PM -0700, Linus Torvalds wrote:
> On Sat, Mar 26, 2016 at 1:00 PM, Jaegeuk Kim wrote:
> >
> > After then, as Dave suggested, we needed to move the crypto libraries into
> > common fs/crypto, so that other filesystems can support that in common
> > sense.
> >
> > Pl
On Sat, Mar 26, 2016 at 1:00 PM, Jaegeuk Kim wrote:
>
> After then, as Dave suggested, we needed to move the crypto libraries into
> common fs/crypto, so that other filesystems can support that in common sense.
>
> Please check the below threads about this history.
> http://www.spinics.net/lists/l
On Sat, Mar 26, 2016 at 10:53:52AM -0700, Linus Torvalds wrote:
> Good catch, Eric.
>
> While waiting for explanations, I've committed the change to move back
> to just the page index.
Thank you.
+Ted
This was originally introduced in EXT4 for AOSP last year.
At that time, Ted suggested that it
Good catch, Eric.
While waiting for explanations, I've committed the change to move back
to just the page index.
On Sat, Mar 26, 2016 at 6:47 AM, Eric Biggers wrote:
>
> Another question about the choice of IV. If the page index in CPU order is
> (supposed to be) used as the IV, doesn't make th
It seems strange to me --- a "renaming" commit made IVs start getting reused,
weakening the encryption. Do you have an explanation for how this change got
introduced?
Another question about the choice of IV. If the page index in CPU order is
(supposed to be) used as the IV, doesn't make the on-d
On Sat, Mar 26, 2016 at 01:10:07AM -0500, Eric Biggers wrote:
> Why was the XTS tweak initialization changed in commit 0b81d0779072 ("fs
> crypto:
> move per-file encryption from f2fs tree to fs/crypto")?
>
> Old code:
>
>memcpy(xts_tweak, &index, sizeof(index));
>memset(&xts_twe
Why was the XTS tweak initialization changed in commit 0b81d0779072 ("fs crypto:
move per-file encryption from f2fs tree to fs/crypto")?
Old code:
memcpy(xts_tweak, &index, sizeof(index));
memset(&xts_tweak[sizeof(index)], 0,
F2FS_XTS_TWEAK_SIZE - sizeof(index
On Mon, Mar 21, 2016 at 11:09:45AM -0700, Linus Torvalds wrote:
> On Sun, Mar 20, 2016 at 3:58 PM, Jaegeuk Kim wrote:
> >
> > I made another pull request which removes the previous wrong commits and
> > adds
> > a single commit to migrate the f2fs crypto into fs/crypto.
>
> Ok, merged. Please d
On Sun, Mar 20, 2016 at 3:58 PM, Jaegeuk Kim wrote:
>
> I made another pull request which removes the previous wrong commits and adds
> a single commit to migrate the f2fs crypto into fs/crypto.
Ok, merged. Please double-check the end result, but since most of the
skcipher update was literally t
Hi Linus,
I made another pull request which removes the previous wrong commits and adds
a single commit to migrate the f2fs crypto into fs/crypto.
Could you please consider to pull this?
Thanks,
The following changes since commit 4de8ebeff8ddefaceeb7fc6a9b1a514fc9624509:
Merge tag 'trace-fix
Hi Linus,
Could you please pull the below patches?
Note that, I did cherry-pick one patch and add another patch to resolve the
conflict against recent crypto changes.
- cherry-picked
4bedd9f487276290c49de9b0aad8cbf7ff847543
f2fs: Use skcipher
- add
1288a901a4c85aeea183937f8e8343d61
On Thu, Mar 17, 2016 at 7:32 PM, Linus Torvalds
wrote:
\>
> Then later, you add the Makefile and Kconfig rules to start building
> the files, but still nothing *uses* it.
>
> And then, after that, you have one commit that removes the old code,
> and switches over to the new code.
Oh, and after I
On Thu, Mar 17, 2016 at 5:58 PM, Jaegeuk Kim wrote:
>
> Note that, I did cherry-pick one patch and add another patch to resolve the
> conflict against recent crypto changes.
*please* don't do things like this!
Now I have a conflict _anyway_, and because you added extra commits it
ends up being j
On Thu, Mar 17, 2016 at 07:32:34PM -0700, Linus Torvalds wrote:
> On Thu, Mar 17, 2016 at 5:58 PM, Jaegeuk Kim wrote:
> >
> > Note that, I did cherry-pick one patch and add another patch to resolve the
> > conflict against recent crypto changes.
>
> *please* don't do things like this!
My apologi
17 matches
Mail list logo