Re: [GIT PULL] please pull infiniband.git for-linus

2008-01-03 Thread Dave Dillow
On Thu, 2008-01-03 at 18:11 -0500, Rik van Riel wrote: > On Thu, 03 Jan 2008 15:20:09 -0500 > David Dillow <[EMAIL PROTECTED]> wrote: > > > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c > > b/drivers/infiniband/ulp/srp/ib_srp.c > > index 950228f..6e7e3c8 100644 > > ---

Re: [GIT PULL] please pull infiniband.git for-linus

2008-01-03 Thread Rik van Riel
On Thu, 03 Jan 2008 15:20:09 -0500 David Dillow <[EMAIL PROTECTED]> wrote: > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c > b/drivers/infiniband/ulp/srp/ib_srp.c > index 950228f..6e7e3c8 100644 > --- a/drivers/infiniband/ulp/srp/ib_srp.c > +++ b/drivers/infiniband/ulp/srp/ib_srp.c > @@

Re: [GIT PULL] please pull infiniband.git for-linus

2008-01-03 Thread Roland Dreier
> @@ -423,8 +423,8 @@ static void srp_remove_work(struct work_struct *work) > list_del(>list); > spin_unlock(>srp_host->target_lock); > > -srp_remove_host(target->scsi_host); > scsi_remove_host(target->scsi_host); > +srp_remove_host(target->scsi_host); Thanks... I

Re: [GIT PULL] please pull infiniband.git for-linus

2008-01-03 Thread David Dillow
Subject: IB/srp: Fix list corruption/oops on module reload ib_srp doesn't clean up the transport attributes properly when unloading, so it leaves references around to free'd memory. The srp_remove_host() cannot go before the scsi_remove_host() call as the documented call sequence suggests, as it

Re: [GIT PULL] please pull infiniband.git for-linus

2008-01-03 Thread David Dillow
On Thu, 2008-01-03 at 10:56 -0800, Roland Dreier wrote: > > If we've got time before 2.6.24 final, I'd wait on this a bit. > > ib_srp:srp_remove_work() has them reversed as well, and I'm currently > > tracking down why it oopses when the srp_remove_host() happens before > > the

Re: [GIT PULL] please pull infiniband.git for-linus

2008-01-03 Thread Roland Dreier
> If we've got time before 2.6.24 final, I'd wait on this a bit. > ib_srp:srp_remove_work() has them reversed as well, and I'm currently > tracking down why it oopses when the srp_remove_host() happens before > the scsi_remove_host(), which is the documented call sequence. I think the best

Re: [GIT PULL] please pull infiniband.git for-linus

2008-01-03 Thread David Dillow
On Thu, 2008-01-03 at 10:29 -0800, Roland Dreier wrote: > Linus, please pull from > > master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git > for-linus > > This tree is also available from kernel.org mirrors at: > >

[GIT PULL] please pull infiniband.git for-linus

2008-01-03 Thread Roland Dreier
Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This tree is also available from kernel.org mirrors at: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This will pull one fix for an oops caused by

[GIT PULL] please pull infiniband.git for-linus

2008-01-03 Thread Roland Dreier
Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This tree is also available from kernel.org mirrors at: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This will pull one fix for an oops caused by

Re: [GIT PULL] please pull infiniband.git for-linus

2008-01-03 Thread David Dillow
On Thu, 2008-01-03 at 10:29 -0800, Roland Dreier wrote: Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This tree is also available from kernel.org mirrors at:

Re: [GIT PULL] please pull infiniband.git for-linus

2008-01-03 Thread Roland Dreier
If we've got time before 2.6.24 final, I'd wait on this a bit. ib_srp:srp_remove_work() has them reversed as well, and I'm currently tracking down why it oopses when the srp_remove_host() happens before the scsi_remove_host(), which is the documented call sequence. I think the best thing

Re: [GIT PULL] please pull infiniband.git for-linus

2008-01-03 Thread David Dillow
On Thu, 2008-01-03 at 10:56 -0800, Roland Dreier wrote: If we've got time before 2.6.24 final, I'd wait on this a bit. ib_srp:srp_remove_work() has them reversed as well, and I'm currently tracking down why it oopses when the srp_remove_host() happens before the scsi_remove_host(),

Re: [GIT PULL] please pull infiniband.git for-linus

2008-01-03 Thread David Dillow
Subject: IB/srp: Fix list corruption/oops on module reload ib_srp doesn't clean up the transport attributes properly when unloading, so it leaves references around to free'd memory. The srp_remove_host() cannot go before the scsi_remove_host() call as the documented call sequence suggests, as it

Re: [GIT PULL] please pull infiniband.git for-linus

2008-01-03 Thread Roland Dreier
@@ -423,8 +423,8 @@ static void srp_remove_work(struct work_struct *work) list_del(target-list); spin_unlock(target-srp_host-target_lock); -srp_remove_host(target-scsi_host); scsi_remove_host(target-scsi_host); +srp_remove_host(target-scsi_host); Thanks... I

Re: [GIT PULL] please pull infiniband.git for-linus

2008-01-03 Thread Rik van Riel
On Thu, 03 Jan 2008 15:20:09 -0500 David Dillow [EMAIL PROTECTED] wrote: diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index 950228f..6e7e3c8 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp/ib_srp.c @@ -423,8 +423,8

[GIT PULL] please pull infiniband.git for-linus

2007-10-13 Thread Roland Dreier
Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This tree is also available from kernel.org mirrors at: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This will get one bug fix for a problem that

[GIT PULL] please pull infiniband.git for-linus

2007-10-13 Thread Roland Dreier
Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This tree is also available from kernel.org mirrors at: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This will get one bug fix for a problem that

Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-12 Thread Andrew Morton
On Thu, 11 Oct 2007 18:17:19 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Roland Dreier <[EMAIL PROTECTED]> > Date: Thu, 11 Oct 2007 18:08:52 -0700 > > > This will get the batch of changes queued up for the 2.6.24 merge > > window (although I still have a few more things to merge

Re: [ofa-general] Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-12 Thread Roland Dreier
> > I'm not sure what you mean. During the 2.6.23 cycle I've been sending > > any patches that potentially could conflict with the net-2.6 tree to > > you and Jeff so that you can merge them upstream via your tree. Or do > > you mean Jeff should become the maintainer of drivers/infiniband??

Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-12 Thread Jeff Garzik
Linus Torvalds wrote: Oh, and obviously, the NAPI changes may well have resulted in a merge that had no actual *conflicts* in it, but whether the end result works or not (and whether any IB drivers need updating due to the NAPI changes), I cannot tell. I've pushed out my tree, so people who

Re: [ofa-general] Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-12 Thread Roland Dreier
I'm not sure what you mean. During the 2.6.23 cycle I've been sending any patches that potentially could conflict with the net-2.6 tree to you and Jeff so that you can merge them upstream via your tree. Or do you mean Jeff should become the maintainer of drivers/infiniband?? Not

Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-12 Thread Jeff Garzik
Linus Torvalds wrote: Oh, and obviously, the NAPI changes may well have resulted in a merge that had no actual *conflicts* in it, but whether the end result works or not (and whether any IB drivers need updating due to the NAPI changes), I cannot tell. I've pushed out my tree, so people who

Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-12 Thread Andrew Morton
On Thu, 11 Oct 2007 18:17:19 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Roland Dreier [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 18:08:52 -0700 This will get the batch of changes queued up for the 2.6.24 merge window (although I still have a few more things to merge later, once

Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread Linus Torvalds
On Thu, 11 Oct 2007, Greg KH wrote: > On Thu, Oct 11, 2007 at 07:58:04PM -0700, Linus Torvalds wrote: > > > > So I merged it all, and I don't expect any problems, but I'm hoping > > somebody is thinking about that mod_devicetable.h/file2alias.c mess. > > > > I'm not entirely sure who to

Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread Greg KH
On Thu, Oct 11, 2007 at 07:58:04PM -0700, Linus Torvalds wrote: > > So I merged it all, and I don't expect any problems, but I'm hoping > somebody is thinking about that mod_devicetable.h/file2alias.c mess. > > I'm not entirely sure who to blame on that thing. I'm adding Greg to the > Cc, on

Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread David Miller
From: Linus Torvalds <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 19:58:04 -0700 (PDT) > > > On Thu, 11 Oct 2007, David Miller wrote: > > > > Even if you're confident there won't be merge issues, could you just > > wait for the net-2.6 stuff to go in first? > > I pulled the net stuff first, and

Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread Linus Torvalds
On Thu, 11 Oct 2007, David Miller wrote: > > Even if you're confident there won't be merge issues, could you just > wait for the net-2.6 stuff to go in first? I pulled the net stuff first, and merged the IB stuff afterwards. No conflicts in IB, but there *were* conflicts with the networking

Re: [ofa-general] Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 19:21:06 -0700 > I'm not sure what you mean. During the 2.6.23 cycle I've been sending > any patches that potentially could conflict with the net-2.6 tree to > you and Jeff so that you can merge them upstream via your tree. Or do >

Re: [ofa-general] Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread Roland Dreier
> > This will get the batch of changes queued up for the 2.6.24 merge > > window (although I still have a few more things to merge later, once > > Dave Miller's networking tree has landed too): > > Roland are you absolutely sure this won't create merge conflicts with > my 8MB net-2.6 merge,

Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 18:08:52 -0700 > This will get the batch of changes queued up for the 2.6.24 merge > window (although I still have a few more things to merge later, once > Dave Miller's networking tree has landed too): Roland are you absolutely sure

[GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread Roland Dreier
Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This tree is also available from kernel.org mirrors at: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This will get the batch of changes queued up for

[GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread Roland Dreier
Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This tree is also available from kernel.org mirrors at: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This will get the batch of changes queued up for

Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread David Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 18:08:52 -0700 This will get the batch of changes queued up for the 2.6.24 merge window (although I still have a few more things to merge later, once Dave Miller's networking tree has landed too): Roland are you absolutely sure this

Re: [ofa-general] Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread Roland Dreier
This will get the batch of changes queued up for the 2.6.24 merge window (although I still have a few more things to merge later, once Dave Miller's networking tree has landed too): Roland are you absolutely sure this won't create merge conflicts with my 8MB net-2.6 merge, inside

Re: [ofa-general] Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread David Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 19:21:06 -0700 I'm not sure what you mean. During the 2.6.23 cycle I've been sending any patches that potentially could conflict with the net-2.6 tree to you and Jeff so that you can merge them upstream via your tree. Or do you

Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread Linus Torvalds
On Thu, 11 Oct 2007, David Miller wrote: Even if you're confident there won't be merge issues, could you just wait for the net-2.6 stuff to go in first? I pulled the net stuff first, and merged the IB stuff afterwards. No conflicts in IB, but there *were* conflicts with the networking pull

Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 19:58:04 -0700 (PDT) On Thu, 11 Oct 2007, David Miller wrote: Even if you're confident there won't be merge issues, could you just wait for the net-2.6 stuff to go in first? I pulled the net stuff first, and merged the

Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread Greg KH
On Thu, Oct 11, 2007 at 07:58:04PM -0700, Linus Torvalds wrote: So I merged it all, and I don't expect any problems, but I'm hoping somebody is thinking about that mod_devicetable.h/file2alias.c mess. I'm not entirely sure who to blame on that thing. I'm adding Greg to the Cc, on the

Re: [GIT PULL] please pull infiniband.git for-linus

2007-10-11 Thread Linus Torvalds
On Thu, 11 Oct 2007, Greg KH wrote: On Thu, Oct 11, 2007 at 07:58:04PM -0700, Linus Torvalds wrote: So I merged it all, and I don't expect any problems, but I'm hoping somebody is thinking about that mod_devicetable.h/file2alias.c mess. I'm not entirely sure who to blame on that

[GIT PULL] please pull infiniband.git for-linus branch

2007-08-31 Thread Roland Dreier
Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This tree is also available from kernel.org mirrors at: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This will get fixes for two fairly bad ehca bugs

[GIT PULL] please pull infiniband.git for-linus branch

2007-08-31 Thread Roland Dreier
Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This tree is also available from kernel.org mirrors at: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This will get fixes for two fairly bad ehca bugs

Re: [GIT PULL] please pull infiniband.git for-linus branch

2007-08-22 Thread Stefan Roscher
Hi Roland, On Thursday 16 August 2007 18:19, Roland Dreier wrote: > > Hmm, if these things are appropriate for 2.6.23, maybe my patch > > adding linux/mutex.h to ehca_classes.h can go in too? > > Actually I queued Dotan's patches quite a while ago, although Linus > seems to be ignoring my pull

Re: [GIT PULL] please pull infiniband.git for-linus branch

2007-08-22 Thread Stefan Roscher
Hi Roland, On Thursday 16 August 2007 18:19, Roland Dreier wrote: Hmm, if these things are appropriate for 2.6.23, maybe my patch adding linux/mutex.h to ehca_classes.h can go in too? Actually I queued Dotan's patches quite a while ago, although Linus seems to be ignoring my pull

Re: [GIT PULL] please pull infiniband.git for-linus branch

2007-08-16 Thread Roland Dreier
> Hmm, if these things are appropriate for 2.6.23, maybe my patch > adding linux/mutex.h to ehca_classes.h can go in too? Actually I queued Dotan's patches quite a while ago, although Linus seems to be ignoring my pull requests. I don't see any urgency in adding more similar patches to 2.6.23,

Re: [GIT PULL] please pull infiniband.git for-linus branch

2007-08-16 Thread Michael S. Tsirkin
> Dotan Barak (3): > IB: Include from > IB: Include and from Hmm, if these things are appropriate for 2.6.23, maybe my patch adding linux/mutex.h to ehca_classes.h can go in too? -- MST - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [GIT PULL] please pull infiniband.git for-linus branch

2007-08-16 Thread Michael S. Tsirkin
Dotan Barak (3): IB: Include linux/list.h from rdma/ib_mad.h IB: Include linux/list.h and linux/rwsem.h from rdma/ib_verbs.h Hmm, if these things are appropriate for 2.6.23, maybe my patch adding linux/mutex.h to ehca_classes.h can go in too? -- MST - To unsubscribe from this

Re: [GIT PULL] please pull infiniband.git for-linus branch

2007-08-16 Thread Roland Dreier
Hmm, if these things are appropriate for 2.6.23, maybe my patch adding linux/mutex.h to ehca_classes.h can go in too? Actually I queued Dotan's patches quite a while ago, although Linus seems to be ignoring my pull requests. I don't see any urgency in adding more similar patches to 2.6.23,

[GIT PULL] please pull infiniband.git for-linus branch

2007-08-15 Thread Roland Dreier
Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This tree is also available from kernel.org mirrors at: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This is basically a resend of the small fixes for

[GIT PULL] please pull infiniband.git for-linus branch

2007-08-15 Thread Roland Dreier
Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This tree is also available from kernel.org mirrors at: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This is basically a resend of the small fixes for

[GIT PULL] please pull infiniband.git for-linus branch

2007-08-13 Thread Roland Dreier
Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This tree is also available from kernel.org mirrors at: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This will get some small fixes for 2.6.23: Dotan

[GIT PULL] please pull infiniband.git for-linus branch

2007-08-13 Thread Roland Dreier
Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This tree is also available from kernel.org mirrors at: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This will get some small fixes for 2.6.23: Dotan