RE: [GIT PULL] tracing: Updates for 5.2

2019-05-16 Thread David Laight
> This code: > > /* reset all but tr, trace, and overruns */ > memset(, 0, >sizeof(struct trace_iterator) - >offsetof(struct trace_iterator, seq)); > > not only has a completely misleading comment (it resets a lot

Re: [GIT PULL] tracing: Updates for 5.2

2019-05-15 Thread pr-tracker-bot
The pull request you sent on Wed, 15 May 2019 13:36:14 -0400: > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git > trace-v5.2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d2d8b146043ae7e250aef1fb312971f6f479d487 Thank you! -- Deet-doot-dot,

Re: [GIT PULL] tracing: Updates for 5.2

2019-05-15 Thread Linus Torvalds
On Wed, May 15, 2019 at 5:27 PM Steven Rostedt wrote: > > I can do this, but it needs testing and all that before sending to you, > and may not make the merge window. Is that fine? It's fine. The warning is annoying, but that's my own fault for updating my system just before the merge window.

Re: [GIT PULL] tracing: Updates for 5.2

2019-05-15 Thread Steven Rostedt
On Wed, 15 May 2019 16:31:34 -0700 Linus Torvalds wrote: > On Wed, May 15, 2019 at 4:29 PM Linus Torvalds > wrote: > > > > One option is to just rewrite it something like > > > > const unsigned int offset = offsetof(struct trace_iterator, seq); > > memset(offset+(void *), 0,

Re: [GIT PULL] tracing: Updates for 5.2

2019-05-15 Thread Linus Torvalds
On Wed, May 15, 2019 at 4:29 PM Linus Torvalds wrote: > > One option is to just rewrite it something like > > const unsigned int offset = offsetof(struct trace_iterator, seq); > memset(offset+(void *), 0, sizeof(iter) - offset); Side note: make it a well-named helper function,

Re: [GIT PULL] tracing: Updates for 5.2

2019-05-15 Thread Linus Torvalds
On Wed, May 15, 2019 at 10:36 AM Steven Rostedt wrote: > > The major changes in this tracing update includes: This is not directly related to this pull request, but newer versions of gcc hate your trace_iterator clearing trick. This code: /* reset all but tr, trace, and

[GIT PULL] tracing: Updates for 5.2

2019-05-15 Thread Steven Rostedt
Linus, The major changes in this tracing update includes: - Removing of non-DYNAMIC_FTRACE from 32bit x86 - Removing of mcount support from x86 - Emulating a call from int3 on x86_64, fixes live kernel patching - Consolidated Tracing Error logs file Minor updates: - Removal of