Re: [GIT PULL 1/3] stm class: Fix a module refcount leak in policy creation error path

2018-12-19 Thread Greg Kroah-Hartman
On Wed, Dec 19, 2018 at 01:45:17PM +0200, Alexander Shishkin wrote: > Greg Kroah-Hartman writes: > > > On Fri, Dec 14, 2018 at 05:53:45PM +0200, Alexander Shishkin wrote: > >> Commit ccddbbf4ef27 ("stm class: Introduce framing protocol drivers") > > > > I don't see that commit id in Linus's

Re: [GIT PULL 1/3] stm class: Fix a module refcount leak in policy creation error path

2018-12-19 Thread Alexander Shishkin
Greg Kroah-Hartman writes: > On Fri, Dec 14, 2018 at 05:53:45PM +0200, Alexander Shishkin wrote: >> Commit ccddbbf4ef27 ("stm class: Introduce framing protocol drivers") > > I don't see that commit id in Linus's tree, are you sure it is correct? No, I messed it up somehow. Sorry about that. The

Re: [GIT PULL 1/3] stm class: Fix a module refcount leak in policy creation error path

2018-12-19 Thread Greg Kroah-Hartman
On Fri, Dec 14, 2018 at 05:53:45PM +0200, Alexander Shishkin wrote: > Commit ccddbbf4ef27 ("stm class: Introduce framing protocol drivers") I don't see that commit id in Linus's tree, are you sure it is correct? thanks, greg k-h

[GIT PULL 1/3] stm class: Fix a module refcount leak in policy creation error path

2018-12-14 Thread Alexander Shishkin
Commit ccddbbf4ef27 ("stm class: Introduce framing protocol drivers") adds a bug into the error path of policy creation, that would do a module_put() on a wrong module, if one tried to create a policy for an stm device which already has a policy, using a different protocol. IOW, | mkdir