Re: [Gta04-owner] [PATCH 2/3] TTY: add support for tty_slave devices.

2015-03-30 Thread NeilBrown
On Fri, 27 Mar 2015 07:09:56 -0400 Peter Hurley wrote: > On 03/25/2015 05:17 PM, NeilBrown wrote: > > On Wed, 25 Mar 2015 12:30:00 -0400 Peter Hurley > > wrote: > > > >> On 03/18/2015 01:58 AM, NeilBrown wrote: > >> > >>> + * A "tty-slave" is a device permanently attached to a particularly >

Re: [Gta04-owner] [PATCH 2/3] TTY: add support for tty_slave devices.

2015-03-30 Thread NeilBrown
On Fri, 27 Mar 2015 07:09:56 -0400 Peter Hurley pe...@hurleysoftware.com wrote: On 03/25/2015 05:17 PM, NeilBrown wrote: On Wed, 25 Mar 2015 12:30:00 -0400 Peter Hurley pe...@hurleysoftware.com wrote: On 03/18/2015 01:58 AM, NeilBrown wrote: + * A tty-slave is a device permanently

Re: [Gta04-owner] [PATCH 2/3] TTY: add support for tty_slave devices.

2015-03-27 Thread Peter Hurley
On 03/25/2015 05:17 PM, NeilBrown wrote: > On Wed, 25 Mar 2015 12:30:00 -0400 Peter Hurley > wrote: > >> On 03/18/2015 01:58 AM, NeilBrown wrote: >> >>> + * A "tty-slave" is a device permanently attached to a particularly >>> + * tty, typically wired to a UART. >> >> Why "permanently"? >> Is

Re: [Gta04-owner] [PATCH 2/3] TTY: add support for tty_slave devices.

2015-03-27 Thread Peter Hurley
On 03/25/2015 05:17 PM, NeilBrown wrote: On Wed, 25 Mar 2015 12:30:00 -0400 Peter Hurley pe...@hurleysoftware.com wrote: On 03/18/2015 01:58 AM, NeilBrown wrote: + * A tty-slave is a device permanently attached to a particularly + * tty, typically wired to a UART. Why permanently? Is

Re: [Gta04-owner] [PATCH 2/3] TTY: add support for tty_slave devices.

2015-03-25 Thread NeilBrown
On Wed, 25 Mar 2015 12:30:00 -0400 Peter Hurley wrote: > On 03/18/2015 01:58 AM, NeilBrown wrote: > > > + * A "tty-slave" is a device permanently attached to a particularly > > + * tty, typically wired to a UART. > > Why "permanently"? > Is that a limitation of the implementation or design? >

Re: [Gta04-owner] [PATCH 2/3] TTY: add support for tty_slave devices.

2015-03-25 Thread NeilBrown
On Wed, 25 Mar 2015 12:30:00 -0400 Peter Hurley pe...@hurleysoftware.com wrote: On 03/18/2015 01:58 AM, NeilBrown wrote: + * A tty-slave is a device permanently attached to a particularly + * tty, typically wired to a UART. Why permanently? Is that a limitation of the implementation or

Re: [Gta04-owner] [PATCH 2/3] TTY: add support for tty_slave devices.

2015-03-22 Thread Pavel Machek
Hi! > > Header files usually have #include guards, and some kind of comment on > > top. > > Of 1996 files in include/linux, 1851 seem to do that. That's enough to > convince me. I've done it too. :-)). Thanks, Pavel --

Re: [Gta04-owner] [PATCH 2/3] TTY: add support for tty_slave devices.

2015-03-22 Thread Pavel Machek
Hi! Header files usually have #include guards, and some kind of comment on top. Of 1996 files in include/linux, 1851 seem to do that. That's enough to convince me. I've done it too. :-)). Thanks, Pavel --

Re: [Gta04-owner] [PATCH 2/3] TTY: add support for tty_slave devices.

2015-03-21 Thread NeilBrown
On Fri, 20 Mar 2015 20:41:50 +0100 Pavel Machek wrote: > Hi! > > (And yes, I now see dts examples, sorry for the noise.) > > Acked-by: Pavel Machek > > Minor nits below. > > > --- /dev/null > > +++ b/drivers/tty/slave/tty_slave_core.c > > @@ -0,0 +1,136 @@ > > +/* > > + * tty-slave-core -

Re: [Gta04-owner] [PATCH 2/3] TTY: add support for tty_slave devices.

2015-03-21 Thread NeilBrown
On Fri, 20 Mar 2015 20:41:50 +0100 Pavel Machek pa...@ucw.cz wrote: Hi! (And yes, I now see dts examples, sorry for the noise.) Acked-by: Pavel Machek pa...@ucw.cz Minor nits below. --- /dev/null +++ b/drivers/tty/slave/tty_slave_core.c @@ -0,0 +1,136 @@ +/* + *