Re: [Kernel-BR] Re: [PATCH] sound: pci: emu10k1: code refactoring and casting removal

2013-10-17 Thread Geyslan Gregório Bem
2013/10/17 Raphael S Carvalho : >> 2013/10/17 Takashi Iwai : >>> >>> Geyslan, you don't have to waste too much of your time (and my time >>> for review) for this kind of so old driver code unless it really fixes >>> the bugs. A clean up is good in general, but it can be sometimes >>> worse than no

Re: [Kernel-BR] Re: [PATCH] sound: pci: emu10k1: code refactoring and casting removal

2013-10-17 Thread Raphael S Carvalho
> 2013/10/17 Takashi Iwai : >> >> Geyslan, you don't have to waste too much of your time (and my time >> for review) for this kind of so old driver code unless it really fixes >> the bugs. A clean up is good in general, but it can be sometimes >> worse than nothing since it also breaks the history