Re: [Line6linux-devel] [PATCH] staging: line6: pcm.c fix checkpatch issues

2012-12-12 Thread Laurent Navet
Ping ? 2012/11/30, Stefan Hajnoczi : > Changes are fine. > > In the future, please split changes into individual patches. For example: > Patch 1 - Rename 'rv' to 'ret' > Patch 2 - Replace decprecated simple_strtoul() with kstrtoint() in > pcm_set_impulse_period() > Patch 3 - Realign comment in

Re: [Line6linux-devel] [PATCH] staging: line6: pcm.c fix checkpatch issues

2012-12-12 Thread Laurent Navet
Ping ? 2012/11/30, Stefan Hajnoczi stefa...@gmail.com: Changes are fine. In the future, please split changes into individual patches. For example: Patch 1 - Rename 'rv' to 'ret' Patch 2 - Replace decprecated simple_strtoul() with kstrtoint() in pcm_set_impulse_period() Patch 3 - Realign

Re: [Line6linux-devel] [PATCH] staging: line6: pcm.c fix checkpatch issues

2012-11-30 Thread Stefan Hajnoczi
On Fri, Nov 30, 2012 at 11:57 AM, Laurent Navet wrote: > fix those checkpatch issues > drivers/staging/line6/pcm.c:84: > WARNING: simple_strtoul is obsolete, use kstrtoul instead > call to obsolete simple_strtoul() replaced by kstrtoint() > > drivers/staging/line6/pcm.c:423: >

Re: [Line6linux-devel] [PATCH] staging: line6: pcm.c fix checkpatch issues

2012-11-30 Thread Stefan Hajnoczi
On Fri, Nov 30, 2012 at 11:57 AM, Laurent Navet laurent.na...@gmail.com wrote: fix those checkpatch issues drivers/staging/line6/pcm.c:84: WARNING: simple_strtoul is obsolete, use kstrtoul instead call to obsolete simple_strtoul() replaced by kstrtoint()