Re: [Linux-cifsd-devel] [PATCH] cifsd: use kfree to free memory allocated by kzalloc

2021-04-06 Thread ronnie sahlberg
On Fri, Apr 2, 2021 at 7:04 AM Tom Talpey wrote: > > On 4/1/2021 9:36 AM, Namjae Jeon wrote: > > 2021-04-01 22:14 GMT+09:00, Ralph Boehme : > >> Am 4/1/21 um 2:59 PM schrieb Namjae Jeon: > >>> 2021-04-01 21:50 GMT+09:00, Ralph Boehme : > fwiw, while at it what about renaming everything that

Re: [Linux-cifsd-devel] [PATCH] cifsd: use kfree to free memory allocated by kzalloc

2021-04-01 Thread Tom Talpey
On 4/1/2021 9:36 AM, Namjae Jeon wrote: 2021-04-01 22:14 GMT+09:00, Ralph Boehme : Am 4/1/21 um 2:59 PM schrieb Namjae Jeon: 2021-04-01 21:50 GMT+09:00, Ralph Boehme : fwiw, while at it what about renaming everything that still references "cifs" to "smb" ? This is not the 90's... :) It is

Re: [Linux-cifsd-devel] [PATCH] cifsd: use kfree to free memory allocated by kzalloc

2021-04-01 Thread Namjae Jeon
2021-04-01 22:14 GMT+09:00, Ralph Boehme : > Am 4/1/21 um 2:59 PM schrieb Namjae Jeon: >> 2021-04-01 21:50 GMT+09:00, Ralph Boehme : >>> fwiw, while at it what about renaming everything that still references >>> "cifs" to "smb" ? This is not the 90's... :) >> It is also used with the name "ksmbd".

Re: [Linux-cifsd-devel] [PATCH] cifsd: use kfree to free memory allocated by kzalloc

2021-04-01 Thread Namjae Jeon
2021-04-01 20:50 GMT+09:00, Dan Carpenter : > On Thu, Apr 01, 2021 at 04:39:33PM +0500, Muhammad Usama Anjum wrote: >> kfree should be used to free memory allocated by kzalloc to avoid >> any overhead and for maintaining consistency. >> >> Fixes: 5dfeb6d945 ("cifsd: use kmalloc() for small

Re: [Linux-cifsd-devel] [PATCH] cifsd: use kfree to free memory allocated by kzalloc

2021-04-01 Thread Ralph Boehme
Am 4/1/21 um 2:59 PM schrieb Namjae Jeon: 2021-04-01 21:50 GMT+09:00, Ralph Boehme : fwiw, while at it what about renaming everything that still references "cifs" to "smb" ? This is not the 90's... :) It is also used with the name "ksmbd". So function and variable prefix are used with ksmbd.

Re: [Linux-cifsd-devel] [PATCH] cifsd: use kfree to free memory allocated by kzalloc

2021-04-01 Thread Namjae Jeon
2021-04-01 21:50 GMT+09:00, Ralph Boehme : > Am 4/1/21 um 2:43 PM schrieb Namjae Jeon: >> 2021-04-01 20:50 GMT+09:00, Dan Carpenter : >>> On Thu, Apr 01, 2021 at 04:39:33PM +0500, Muhammad Usama Anjum wrote: kfree should be used to free memory allocated by kzalloc to avoid any overhead

Re: [Linux-cifsd-devel] [PATCH] cifsd: use kfree to free memory allocated by kzalloc

2021-04-01 Thread Ralph Boehme
Am 4/1/21 um 2:43 PM schrieb Namjae Jeon: 2021-04-01 20:50 GMT+09:00, Dan Carpenter : On Thu, Apr 01, 2021 at 04:39:33PM +0500, Muhammad Usama Anjum wrote: kfree should be used to free memory allocated by kzalloc to avoid any overhead and for maintaining consistency. Fixes: 5dfeb6d945