Re: [Linux-kernel-mentees][PATCH v2] packet: Fix undefined behavior in bit shift

2019-06-29 Thread David Miller
From: Jiunn Chang Date: Wed, 26 Jun 2019 22:25:30 -0500 > Shifting signed 32-bit value by 31 bits is undefined. Changing most > significant bit to unsigned. > > Changes included in v2: > - use subsystem specific subject lines > - CC required mailing lists > > Signed-off-by: Jiunn Chang

Re: [Linux-kernel-mentees][PATCH v2] packet: Fix undefined behavior in bit shift

2019-06-27 Thread David Miller
From: Jiunn Chang Date: Thu, 27 Jun 2019 11:57:28 -0500 > On Thu, Jun 27, 2019 at 09:22:53AM -0700, David Miller wrote: >> From: Shuah Khan >> Date: Wed, 26 Jun 2019 21:32:52 -0600 >> >> > On 6/26/19 9:25 PM, Jiunn Chang wrote: >> >> Shifting signed 32-bit value by 31 bits is undefined.

Re: [Linux-kernel-mentees][PATCH v2] packet: Fix undefined behavior in bit shift

2019-06-27 Thread Shuah Khan
On 6/27/19 11:05 AM, Alexei Starovoitov wrote: On Thu, Jun 27, 2019 at 9:54 AM Shuah Khan wrote: On 6/27/19 10:22 AM, David Miller wrote: From: Shuah Khan Date: Wed, 26 Jun 2019 21:32:52 -0600 On 6/26/19 9:25 PM, Jiunn Chang wrote: Shifting signed 32-bit value by 31 bits is undefined.

Re: [Linux-kernel-mentees][PATCH v2] packet: Fix undefined behavior in bit shift

2019-06-27 Thread Alexei Starovoitov
On Thu, Jun 27, 2019 at 9:54 AM Shuah Khan wrote: > > On 6/27/19 10:22 AM, David Miller wrote: > > From: Shuah Khan > > Date: Wed, 26 Jun 2019 21:32:52 -0600 > > > >> On 6/26/19 9:25 PM, Jiunn Chang wrote: > >>> Shifting signed 32-bit value by 31 bits is undefined. Changing most > >>>

Re: [Linux-kernel-mentees][PATCH v2] packet: Fix undefined behavior in bit shift

2019-06-27 Thread Jiunn Chang
On Thu, Jun 27, 2019 at 09:22:53AM -0700, David Miller wrote: > From: Shuah Khan > Date: Wed, 26 Jun 2019 21:32:52 -0600 > > > On 6/26/19 9:25 PM, Jiunn Chang wrote: > >> Shifting signed 32-bit value by 31 bits is undefined. Changing most > >> significant bit to unsigned. > >> Changes included

Re: [Linux-kernel-mentees][PATCH v2] packet: Fix undefined behavior in bit shift

2019-06-27 Thread Shuah Khan
On 6/27/19 10:22 AM, David Miller wrote: From: Shuah Khan Date: Wed, 26 Jun 2019 21:32:52 -0600 On 6/26/19 9:25 PM, Jiunn Chang wrote: Shifting signed 32-bit value by 31 bits is undefined. Changing most significant bit to unsigned. Changes included in v2: - use subsystem specific

Re: [Linux-kernel-mentees][PATCH v2] packet: Fix undefined behavior in bit shift

2019-06-27 Thread David Miller
From: Shuah Khan Date: Wed, 26 Jun 2019 21:32:52 -0600 > On 6/26/19 9:25 PM, Jiunn Chang wrote: >> Shifting signed 32-bit value by 31 bits is undefined. Changing most >> significant bit to unsigned. >> Changes included in v2: >>- use subsystem specific subject lines >>- CC required

Re: [Linux-kernel-mentees][PATCH v2] packet: Fix undefined behavior in bit shift

2019-06-26 Thread Shuah Khan
On 6/26/19 9:25 PM, Jiunn Chang wrote: Shifting signed 32-bit value by 31 bits is undefined. Changing most significant bit to unsigned. Changes included in v2: - use subsystem specific subject lines - CC required mailing lists These version change lines don't belong in the change log.

[Linux-kernel-mentees][PATCH v2] packet: Fix undefined behavior in bit shift

2019-06-26 Thread Jiunn Chang
Shifting signed 32-bit value by 31 bits is undefined. Changing most significant bit to unsigned. Changes included in v2: - use subsystem specific subject lines - CC required mailing lists Signed-off-by: Jiunn Chang --- include/uapi/linux/if_packet.h | 2 +- 1 file changed, 1 insertion(+),