Re: [MPTCP][PATCH net-next 0/2] init ahmac and port of mptcp_options_received

2020-10-20 Thread Geliang Tang
Hi Jakub, Jakub Kicinski 于2020年10月21日周三 上午7:39写道： > > On Mon, 19 Oct 2020 18:23:14 +0800 Geliang Tang wrote: > > This patchset deals with initializations of mptcp_options_received's two > > fields, ahmac and port. > > Applied, but two extra comments: > - please make sure the commit messages are

Re: [MPTCP][PATCH net-next 0/2] init ahmac and port of mptcp_options_received

2020-10-20 Thread Jakub Kicinski
On Mon, 19 Oct 2020 18:23:14 +0800 Geliang Tang wrote: > This patchset deals with initializations of mptcp_options_received's two > fields, ahmac and port. Applied, but two extra comments: - please make sure the commit messages are in imperative form e.g. "Initialize x..." rather than "This

Re: [MPTCP][PATCH net-next 0/2] init ahmac and port of mptcp_options_received

2020-10-20 Thread Matthieu Baerts
Hi Jakub, On 19/10/2020 22:40, Jakub Kicinski wrote: On Mon, 19 Oct 2020 18:27:55 +0200 Matthieu Baerts wrote: Hi Geliang, On 19/10/2020 12:23, Geliang Tang wrote: This patchset deals with initializations of mptcp_options_received's two fields, ahmac and port. Geliang Tang (2): mptcp:

Re: [MPTCP][PATCH net-next 0/2] init ahmac and port of mptcp_options_received

2020-10-19 Thread Jakub Kicinski
On Mon, 19 Oct 2020 18:27:55 +0200 Matthieu Baerts wrote: > Hi Geliang, > > On 19/10/2020 12:23, Geliang Tang wrote: > > This patchset deals with initializations of mptcp_options_received's two > > fields, ahmac and port. > > > > Geliang Tang (2): > >mptcp: initialize

Re: [MPTCP][PATCH net-next 0/2] init ahmac and port of mptcp_options_received

2020-10-19 Thread Matthieu Baerts
Hi Geliang, On 19/10/2020 12:23, Geliang Tang wrote: This patchset deals with initializations of mptcp_options_received's two fields, ahmac and port. Geliang Tang (2): mptcp: initialize mptcp_options_received's ahmac mptcp: move mptcp_options_received's port initialization Thank you

[MPTCP][PATCH net-next 0/2] init ahmac and port of mptcp_options_received

2020-10-19 Thread Geliang Tang
This patchset deals with initializations of mptcp_options_received's two fields, ahmac and port. Geliang Tang (2): mptcp: initialize mptcp_options_received's ahmac mptcp: move mptcp_options_received's port initialization net/mptcp/options.c | 3 ++- 1 file changed, 2 insertions(+), 1