Re: [MPTCP][PATCH net 1/2] mptcp: fix static checker warnings in mptcp_pm_add_timer

2020-11-11 Thread Geliang Tang
Hi Jakub, Matt, Jakub Kicinski 于2020年11月10日周二 上午6:20写道： > > On Mon, 9 Nov 2020 21:23:33 + (UTC) Matthieu Baerts wrote: > > 09 Nov 2020 21:57:05 Jakub Kicinski : > > > On Mon, 9 Nov 2020 17:28:54 +0100 Matthieu Baerts wrote: > > >> A small detail (I think): the Signed-off-by of the sender

Re: [MPTCP][PATCH net 1/2] mptcp: fix static checker warnings in mptcp_pm_add_timer

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 21:23:33 + (UTC) Matthieu Baerts wrote: > 09 Nov 2020 21:57:05 Jakub Kicinski : > > On Mon, 9 Nov 2020 17:28:54 +0100 Matthieu Baerts wrote: > >> A small detail (I think): the Signed-off-by of the sender (Geliang) > >> should be the last one in the list if I am not

Re: [MPTCP][PATCH net 1/2] mptcp: fix static checker warnings in mptcp_pm_add_timer

2020-11-09 Thread Matthieu Baerts
Hi Jakub, 09 Nov 2020 21:57:05 Jakub Kicinski : > On Mon, 9 Nov 2020 17:28:54 +0100 Matthieu Baerts wrote: >> A small detail (I think): the Signed-off-by of the sender (Geliang) >> should be the last one in the list if I am not mistaken. >> But I guess this is not blocking. >> >> Reviewed-by:

Re: [MPTCP][PATCH net 1/2] mptcp: fix static checker warnings in mptcp_pm_add_timer

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 17:28:54 +0100 Matthieu Baerts wrote: > A small detail (I think): the Signed-off-by of the sender (Geliang) > should be the last one in the list if I am not mistaken. > But I guess this is not blocking. > > Reviewed-by: Matthieu Baerts I take it you'd like me to apply patch

Re: [MPTCP][PATCH net 1/2] mptcp: fix static checker warnings in mptcp_pm_add_timer

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 21:34:19 +0300 Dan Carpenter wrote: > Generally, I like them to be in chronological order. +1

Re: [MPTCP][PATCH net 1/2] mptcp: fix static checker warnings in mptcp_pm_add_timer

2020-11-09 Thread Dan Carpenter
On Mon, Nov 09, 2020 at 05:28:54PM +0100, Matthieu Baerts wrote: > Hi Geliang, Dan, > > On 09/11/2020 14:59, Geliang Tang wrote: > > Fix the following Smatch complaint: > > Thanks for the report and the patch! > > > net/mptcp/pm_netlink.c:213 mptcp_pm_add_timer() > > warn: variable

Re: [MPTCP][PATCH net 1/2] mptcp: fix static checker warnings in mptcp_pm_add_timer

2020-11-09 Thread Matthieu Baerts
Hi Geliang, Dan, On 09/11/2020 14:59, Geliang Tang wrote: Fix the following Smatch complaint: Thanks for the report and the patch! net/mptcp/pm_netlink.c:213 mptcp_pm_add_timer() warn: variable dereferenced before check 'msk' (see line 208) net/mptcp/pm_netlink.c 207

[MPTCP][PATCH net 1/2] mptcp: fix static checker warnings in mptcp_pm_add_timer

2020-11-09 Thread Geliang Tang
Fix the following Smatch complaint: net/mptcp/pm_netlink.c:213 mptcp_pm_add_timer() warn: variable dereferenced before check 'msk' (see line 208) net/mptcp/pm_netlink.c 207 struct mptcp_sock *msk = entry->sock; 208 struct sock *sk = (struct sock *)msk;