Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-19 Thread Satyam Sharma
On 7/20/07, Neil Brown <[EMAIL PROTECTED]> wrote: On Thursday July 19, [EMAIL PROTECTED] wrote: > On Thu, Jul 19, 2007 at 10:16:14AM +1000, Neil Brown wrote: > > On Wednesday July 18, [EMAIL PROTECTED] wrote: > > > OK, here I'm still confused--what should we be doing instead? > > > > Cast the

Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-19 Thread Neil Brown
On Thursday July 19, [EMAIL PROTECTED] wrote: > On Thu, Jul 19, 2007 at 10:16:14AM +1000, Neil Brown wrote: > > On Wednesday July 18, [EMAIL PROTECTED] wrote: > > > OK, here I'm still confused--what should we be doing instead? > > > > Cast the variable to a type that printf knows about. > >

Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-19 Thread J. Bruce Fields
On Thu, Jul 19, 2007 at 10:16:14AM +1000, Neil Brown wrote: > On Wednesday July 18, [EMAIL PROTECTED] wrote: > > On Fri, Jul 13, 2007 at 12:29:33AM -0700, Andrew Morton wrote: > > > On Tue, 10 Jul 2007 12:27:37 +1000 NeilBrown <[EMAIL PROTECTED]> wrote: > > > > > > > +static void exp_flags(struct

Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-19 Thread J. Bruce Fields
On Thu, Jul 19, 2007 at 10:16:14AM +1000, Neil Brown wrote: On Wednesday July 18, [EMAIL PROTECTED] wrote: On Fri, Jul 13, 2007 at 12:29:33AM -0700, Andrew Morton wrote: On Tue, 10 Jul 2007 12:27:37 +1000 NeilBrown [EMAIL PROTECTED] wrote: +static void exp_flags(struct seq_file *m,

Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-19 Thread Neil Brown
On Thursday July 19, [EMAIL PROTECTED] wrote: On Thu, Jul 19, 2007 at 10:16:14AM +1000, Neil Brown wrote: On Wednesday July 18, [EMAIL PROTECTED] wrote: OK, here I'm still confused--what should we be doing instead? Cast the variable to a type that printf knows about.

Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-19 Thread Satyam Sharma
On 7/20/07, Neil Brown [EMAIL PROTECTED] wrote: On Thursday July 19, [EMAIL PROTECTED] wrote: On Thu, Jul 19, 2007 at 10:16:14AM +1000, Neil Brown wrote: On Wednesday July 18, [EMAIL PROTECTED] wrote: OK, here I'm still confused--what should we be doing instead? Cast the variable to a

Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-18 Thread Andrew Morton
On Wed, 18 Jul 2007 19:05:55 -0400 "J. Bruce Fields" <[EMAIL PROTECTED]> wrote: > On Fri, Jul 13, 2007 at 12:29:33AM -0700, Andrew Morton wrote: > > On Tue, 10 Jul 2007 12:27:37 +1000 NeilBrown <[EMAIL PROTECTED]> wrote: > > > > > +static void exp_flags(struct seq_file *m, int flag, int fsid, >

Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-18 Thread Neil Brown
On Wednesday July 18, [EMAIL PROTECTED] wrote: > On Fri, Jul 13, 2007 at 12:29:33AM -0700, Andrew Morton wrote: > > On Tue, 10 Jul 2007 12:27:37 +1000 NeilBrown <[EMAIL PROTECTED]> wrote: > > > > > +static void exp_flags(struct seq_file *m, int flag, int fsid, > > > + uid_t anonu, uid_t

Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-18 Thread J. Bruce Fields
On Fri, Jul 13, 2007 at 12:29:33AM -0700, Andrew Morton wrote: > On Tue, 10 Jul 2007 12:27:37 +1000 NeilBrown <[EMAIL PROTECTED]> wrote: > > > +static void exp_flags(struct seq_file *m, int flag, int fsid, > > + uid_t anonu, uid_t anong, struct nfsd4_fs_locations *fsloc) > > +{ > > +

Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-18 Thread J. Bruce Fields
On Fri, Jul 13, 2007 at 12:29:33AM -0700, Andrew Morton wrote: On Tue, 10 Jul 2007 12:27:37 +1000 NeilBrown [EMAIL PROTECTED] wrote: +static void exp_flags(struct seq_file *m, int flag, int fsid, + uid_t anonu, uid_t anong, struct nfsd4_fs_locations *fsloc) +{ +

Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-18 Thread Neil Brown
On Wednesday July 18, [EMAIL PROTECTED] wrote: On Fri, Jul 13, 2007 at 12:29:33AM -0700, Andrew Morton wrote: On Tue, 10 Jul 2007 12:27:37 +1000 NeilBrown [EMAIL PROTECTED] wrote: +static void exp_flags(struct seq_file *m, int flag, int fsid, + uid_t anonu, uid_t anong, struct

Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-18 Thread Andrew Morton
On Wed, 18 Jul 2007 19:05:55 -0400 J. Bruce Fields [EMAIL PROTECTED] wrote: On Fri, Jul 13, 2007 at 12:29:33AM -0700, Andrew Morton wrote: On Tue, 10 Jul 2007 12:27:37 +1000 NeilBrown [EMAIL PROTECTED] wrote: +static void exp_flags(struct seq_file *m, int flag, int fsid, +