Re: [Outreachy kernel] [PATCH 2/2] media: zoran: replace bit shifts by BIT() macro

2021-04-09 Thread Julia Lawall
On Fri, 9 Apr 2021, Mitali Borkar wrote: > On Fri, Apr 09, 2021 at 12:10:06AM +0200, Julia Lawall wrote: > > > > > > On Fri, 9 Apr 2021, Mitali Borkar wrote: > > > > > On Thu, Apr 08, 2021 at 11:15:07PM +0200, Julia Lawall wrote: > > > > > > > > > > > > On Fri, 9 Apr 2021, Mitali Borkar wrote:

Re: [Outreachy kernel] [PATCH 2/2] media: zoran: replace bit shifts by BIT() macro

2021-04-08 Thread Mitali Borkar
On Fri, Apr 09, 2021 at 12:10:06AM +0200, Julia Lawall wrote: > > > On Fri, 9 Apr 2021, Mitali Borkar wrote: > > > On Thu, Apr 08, 2021 at 11:15:07PM +0200, Julia Lawall wrote: > > > > > > > > > On Fri, 9 Apr 2021, Mitali Borkar wrote: > > > > > > > Added #include and replaced bit shifts by

Re: [Outreachy kernel] [PATCH 2/2] media: zoran: replace bit shifts by BIT() macro

2021-04-08 Thread Julia Lawall
On Fri, 9 Apr 2021, Mitali Borkar wrote: > On Thu, Apr 08, 2021 at 11:15:07PM +0200, Julia Lawall wrote: > > > > > > On Fri, 9 Apr 2021, Mitali Borkar wrote: > > > > > Added #include and replaced bit shifts by BIT() macro. > > > This BIT() macro from linux/bitops.h is used to define

Re: [Outreachy kernel] [PATCH 2/2] media: zoran: replace bit shifts by BIT() macro

2021-04-08 Thread Mitali Borkar
On Thu, Apr 08, 2021 at 11:15:07PM +0200, Julia Lawall wrote: > > > On Fri, 9 Apr 2021, Mitali Borkar wrote: > > > Added #include and replaced bit shifts by BIT() macro. > > This BIT() macro from linux/bitops.h is used to define ZR36057_VFESPFR_* > > bitmasks. > > Use of macro is better and

Re: [Outreachy kernel] [PATCH 2/2] media: zoran: replace bit shifts by BIT() macro

2021-04-08 Thread Julia Lawall
On Fri, 9 Apr 2021, Mitali Borkar wrote: > Added #include and replaced bit shifts by BIT() macro. > This BIT() macro from linux/bitops.h is used to define ZR36057_VFESPFR_* > bitmasks. > Use of macro is better and neater. It maintains consistency. > Reported by checkpatch. > > Signed-off-by: