Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

2017-09-08 Thread Dan Carpenter
True. Of course, normally the from line means you're forwarding a patch from someone else and then it's totally appropriate. I don't like From lines because it's just an extra thing to check. How do we know that they're not just pretending to be someone from @MajorCorporation.com? regards, dan

Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

2017-09-08 Thread Dan Carpenter
True. Of course, normally the from line means you're forwarding a patch from someone else and then it's totally appropriate. I don't like From lines because it's just an extra thing to check. How do we know that they're not just pretending to be someone from @MajorCorporation.com? regards, dan

Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, Dan Carpenter wrote: > On Fri, Sep 08, 2017 at 11:45:20AM +0200, Julia Lawall wrote: > > > > > > On Fri, 8 Sep 2017, harsha wrote: > > > > > From: Harsha Sharma > > > > > > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled >

Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, Dan Carpenter wrote: > On Fri, Sep 08, 2017 at 11:45:20AM +0200, Julia Lawall wrote: > > > > > > On Fri, 8 Sep 2017, harsha wrote: > > > > > From: Harsha Sharma > > > > > > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled > > > > > > Signed-off-by:

Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

2017-09-08 Thread Dan Carpenter
On Fri, Sep 08, 2017 at 11:45:20AM +0200, Julia Lawall wrote: > > > On Fri, 8 Sep 2017, harsha wrote: > > > From: Harsha Sharma > > > > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled > > > > Signed-off-by: Harsha Sharma

Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

2017-09-08 Thread Dan Carpenter
On Fri, Sep 08, 2017 at 11:45:20AM +0200, Julia Lawall wrote: > > > On Fri, 8 Sep 2017, harsha wrote: > > > From: Harsha Sharma > > > > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled > > > > Signed-off-by: Harsha Sharma > > --- > > Changes in v4: > > -Correct the

Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, harsha wrote: > From: Harsha Sharma > > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled > > Signed-off-by: Harsha Sharma > --- > Changes in v4: > -Correct the format of the subject. >

Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, harsha wrote: > From: Harsha Sharma > > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled > > Signed-off-by: Harsha Sharma > --- > Changes in v4: > -Correct the format of the subject. > -Signed-off properly. It's not signed off properly. Like Greg