On Fri, 3 Mar 2017, SIMRAN SINGHAL wrote:
> On Fri, Mar 3, 2017 at 3:29 AM, Joe Perches <j...@perches.com> wrote: > > On Fri, 2017-03-03 at 03:25 +0530, SIMRAN SINGHAL wrote: > >> On Fri, Mar 3, 2017 at 3:13 AM, Joe Perches <j...@perches.com> wrote: > >> > On Fri, 2017-03-03 at 02:49 +0530, simran singhal wrote: > >> > > The following Coccinelle script was used to detect this: > >> > > @r@ > >> > > expression x; > >> > > void* e; > >> > > type T; > >> > > identifier f; > >> > > @@ > >> > > ( > >> > > *((T *)e) > >> > > > > >> > > > >> > > ((T *)x)[...] > >> > > > > >> > > > >> > > ((T*)x)->f > >> > > > > >> > > > >> > > - (T*) > >> > > e > >> > > ) > >> > > >> > NAK. > >> > > >> > Nice, but you still have to verify correctness > >> > before submitting these patches. > >> > > >> > > diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c > >> > > b/drivers/staging/lustre/lustre/mgc/mgc_request.c > >> > > >> > [] > >> > > @@ -1034,7 +1034,7 @@ static int mgc_set_info_async(const struct > >> > > lu_env *env, struct obd_export *exp, > >> > > rc = sptlrpc_parse_flavor(val, &flvr); > >> > > if (rc) { > >> > > CERROR("invalid sptlrpc flavor %s to MGS\n", > >> > > - (char *)val); > >> > > + val); > >> > > >> > Try compiling this. > >> > > >> > >> I compiled it before sending. > > > > Did you look at the warnings? > > > > CC [M] drivers/staging/lustre/lustre/mgc/mgc_request.o > > drivers/staging/lustre/lustre/mgc/mgc_request.c: In function > > ‘mgc_set_info_async’: > > drivers/staging/lustre/lustre/mgc/mgc_request.c:1036:115: warning: format > > ‘%s’ expects argument of type ‘char *’, but argument 3 has type ‘void *’ > > [-Wformat=] > > CERROR("invalid sptlrpc flavor %s to MGS\n", > > > > I again compiled it and this is what I got :- > > CHK include/config/kernel.release > CHK include/generated/uapi/linux/version.h > CHK include/generated/utsrelease.h > CHK include/generated/timeconst.h > CHK include/generated/bounds.h > CHK include/generated/asm-offsets.h > CALL scripts/checksyscalls.sh > CHK include/generated/compile.h > LD arch/x86/boot/compressed/vmlinux > ZOFFSET arch/x86/boot/zoffset.h > AS arch/x86/boot/header.o > LD arch/x86/boot/setup.elf > OBJCOPY arch/x86/boot/setup.bin > OBJCOPY arch/x86/boot/vmlinux.bin > BUILD arch/x86/boot/bzImage > Setup is 17500 bytes (padded to 17920 bytes). > System is 7128 kB > CRC 37713343 > Kernel: arch/x86/boot/bzImage is ready (#4) > Building modules, stage 2. > MODPOST 4541 modules > > I am not getting any warning. Did you touch the .c file before compiling it? Warnings still allow the creation of a .o, and once there is a .o that s more recent than the .c, make won't compile it again. I got a whole of host of warnings, including the ones Joe showed. julia > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscr...@googlegroups.com. > To post to this group, send email to outreachy-ker...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/CALrZqyP6S2mwYUBERerLnG99qVSFm5jHppjy695JARHMfZ-5Pw%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. >