Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-13 Thread Jann Horn
On Fri, Aug 12, 2016 at 12:28:11PM -0400, Robert Foss wrote: > > > On 2016-08-10 02:05 PM, Jann Horn wrote: > >On Wed, Aug 10, 2016 at 10:45:51AM -0700, Sonny Rao wrote: > >>On Wed, Aug 10, 2016 at 10:37 AM, Jann Horn wrote: > >>>On Wed, Aug 10, 2016 at 10:23:53AM -0700, Sonny

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-13 Thread Jann Horn
On Fri, Aug 12, 2016 at 12:28:11PM -0400, Robert Foss wrote: > > > On 2016-08-10 02:05 PM, Jann Horn wrote: > >On Wed, Aug 10, 2016 at 10:45:51AM -0700, Sonny Rao wrote: > >>On Wed, Aug 10, 2016 at 10:37 AM, Jann Horn wrote: > >>>On Wed, Aug 10, 2016 at 10:23:53AM -0700, Sonny Rao wrote: >

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-12 Thread Robert Foss
On 2016-08-10 02:05 PM, Jann Horn wrote: On Wed, Aug 10, 2016 at 10:45:51AM -0700, Sonny Rao wrote: On Wed, Aug 10, 2016 at 10:37 AM, Jann Horn wrote: On Wed, Aug 10, 2016 at 10:23:53AM -0700, Sonny Rao wrote: On Tue, Aug 9, 2016 at 2:01 PM, Robert Foss

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-12 Thread Robert Foss
On 2016-08-10 02:05 PM, Jann Horn wrote: On Wed, Aug 10, 2016 at 10:45:51AM -0700, Sonny Rao wrote: On Wed, Aug 10, 2016 at 10:37 AM, Jann Horn wrote: On Wed, Aug 10, 2016 at 10:23:53AM -0700, Sonny Rao wrote: On Tue, Aug 9, 2016 at 2:01 PM, Robert Foss wrote: On 2016-08-09 03:24 PM,

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Mateusz Guzik
On Wed, Aug 10, 2016 at 11:39:12AM -0400, Robert Foss wrote: > > > On 2016-08-09 04:17 PM, Robert Foss wrote: > > > > +static int totmaps_proc_show(struct seq_file *m, void *data) > > > > +{ > > > > +struct proc_maps_private *priv = m->private; > > > > +struct mm_struct *mm; > > > > +

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Mateusz Guzik
On Wed, Aug 10, 2016 at 11:39:12AM -0400, Robert Foss wrote: > > > On 2016-08-09 04:17 PM, Robert Foss wrote: > > > > +static int totmaps_proc_show(struct seq_file *m, void *data) > > > > +{ > > > > +struct proc_maps_private *priv = m->private; > > > > +struct mm_struct *mm; > > > > +

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Robert Foss
On 2016-08-10 11:02 AM, Jann Horn wrote: On Wed, Aug 10, 2016 at 10:16:45AM -0400, Robert Foss wrote: On 2016-08-09 06:30 PM, Jann Horn wrote: On Tue, Aug 09, 2016 at 05:01:44PM -0400, Robert Foss wrote: On 2016-08-09 03:24 PM, Jann Horn wrote: On Tue, Aug 09, 2016 at 12:05:43PM -0400,

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Robert Foss
On 2016-08-10 11:02 AM, Jann Horn wrote: On Wed, Aug 10, 2016 at 10:16:45AM -0400, Robert Foss wrote: On 2016-08-09 06:30 PM, Jann Horn wrote: On Tue, Aug 09, 2016 at 05:01:44PM -0400, Robert Foss wrote: On 2016-08-09 03:24 PM, Jann Horn wrote: On Tue, Aug 09, 2016 at 12:05:43PM -0400,

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Robert Foss
On 2016-08-09 06:30 PM, Jann Horn wrote: On Tue, Aug 09, 2016 at 05:01:44PM -0400, Robert Foss wrote: On 2016-08-09 03:24 PM, Jann Horn wrote: On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: + down_read(>mmap_sem); + hold_task_mempolicy(priv); + +

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Robert Foss
On 2016-08-09 06:30 PM, Jann Horn wrote: On Tue, Aug 09, 2016 at 05:01:44PM -0400, Robert Foss wrote: On 2016-08-09 03:24 PM, Jann Horn wrote: On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: + down_read(>mmap_sem); + hold_task_mempolicy(priv); + +

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Sonny Rao
On Wed, Aug 10, 2016 at 10:37 AM, Jann Horn wrote: > On Wed, Aug 10, 2016 at 10:23:53AM -0700, Sonny Rao wrote: >> On Tue, Aug 9, 2016 at 2:01 PM, Robert Foss >> wrote: >> > >> > >> > On 2016-08-09 03:24 PM, Jann Horn wrote: >> >> >> >> On Tue, Aug 09,

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Sonny Rao
On Wed, Aug 10, 2016 at 10:37 AM, Jann Horn wrote: > On Wed, Aug 10, 2016 at 10:23:53AM -0700, Sonny Rao wrote: >> On Tue, Aug 9, 2016 at 2:01 PM, Robert Foss >> wrote: >> > >> > >> > On 2016-08-09 03:24 PM, Jann Horn wrote: >> >> >> >> On Tue, Aug 09, 2016 at 12:05:43PM -0400,

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Jann Horn
On Wed, Aug 10, 2016 at 10:16:45AM -0400, Robert Foss wrote: > > > On 2016-08-09 06:30 PM, Jann Horn wrote: > >On Tue, Aug 09, 2016 at 05:01:44PM -0400, Robert Foss wrote: > >>On 2016-08-09 03:24 PM, Jann Horn wrote: > >>>On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote:

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Jann Horn
On Wed, Aug 10, 2016 at 10:16:45AM -0400, Robert Foss wrote: > > > On 2016-08-09 06:30 PM, Jann Horn wrote: > >On Tue, Aug 09, 2016 at 05:01:44PM -0400, Robert Foss wrote: > >>On 2016-08-09 03:24 PM, Jann Horn wrote: > >>>On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote:

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Sonny Rao
On Tue, Aug 9, 2016 at 2:01 PM, Robert Foss wrote: > > > On 2016-08-09 03:24 PM, Jann Horn wrote: >> >> On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: >>> >>> From: Sonny Rao >>> >>> This is based on earlier work by

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Sonny Rao
On Tue, Aug 9, 2016 at 2:01 PM, Robert Foss wrote: > > > On 2016-08-09 03:24 PM, Jann Horn wrote: >> >> On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: >>> >>> From: Sonny Rao >>> >>> This is based on earlier work by Thiago Goncales. It implements a new >>> per process

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Robert Foss
On 2016-08-10 11:42 AM, Mateusz Guzik wrote: On Wed, Aug 10, 2016 at 11:39:12AM -0400, Robert Foss wrote: On 2016-08-09 04:17 PM, Robert Foss wrote: +static int totmaps_proc_show(struct seq_file *m, void *data) +{ +struct proc_maps_private *priv = m->private; +struct mm_struct *mm;

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Robert Foss
On 2016-08-10 11:42 AM, Mateusz Guzik wrote: On Wed, Aug 10, 2016 at 11:39:12AM -0400, Robert Foss wrote: On 2016-08-09 04:17 PM, Robert Foss wrote: +static int totmaps_proc_show(struct seq_file *m, void *data) +{ +struct proc_maps_private *priv = m->private; +struct mm_struct *mm;

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Jann Horn
On Wed, Aug 10, 2016 at 10:23:53AM -0700, Sonny Rao wrote: > On Tue, Aug 9, 2016 at 2:01 PM, Robert Foss wrote: > > > > > > On 2016-08-09 03:24 PM, Jann Horn wrote: > >> > >> On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: > >>> > >>> From:

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Jann Horn
On Wed, Aug 10, 2016 at 10:23:53AM -0700, Sonny Rao wrote: > On Tue, Aug 9, 2016 at 2:01 PM, Robert Foss wrote: > > > > > > On 2016-08-09 03:24 PM, Jann Horn wrote: > >> > >> On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: > >>> > >>> From: Sonny Rao > >>> > >>> This

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Jann Horn
On Wed, Aug 10, 2016 at 10:45:51AM -0700, Sonny Rao wrote: > On Wed, Aug 10, 2016 at 10:37 AM, Jann Horn wrote: > > On Wed, Aug 10, 2016 at 10:23:53AM -0700, Sonny Rao wrote: > >> On Tue, Aug 9, 2016 at 2:01 PM, Robert Foss > >> wrote: > >> > > >> > >

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Jann Horn
On Wed, Aug 10, 2016 at 10:45:51AM -0700, Sonny Rao wrote: > On Wed, Aug 10, 2016 at 10:37 AM, Jann Horn wrote: > > On Wed, Aug 10, 2016 at 10:23:53AM -0700, Sonny Rao wrote: > >> On Tue, Aug 9, 2016 at 2:01 PM, Robert Foss > >> wrote: > >> > > >> > > >> > On 2016-08-09 03:24 PM, Jann Horn

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Robert Foss
On 2016-08-09 04:17 PM, Robert Foss wrote: +static int totmaps_proc_show(struct seq_file *m, void *data) +{ +struct proc_maps_private *priv = m->private; +struct mm_struct *mm; +struct vm_area_struct *vma; +struct mem_size_stats *mss_sum = priv->mss; + +/* reference to

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-10 Thread Robert Foss
On 2016-08-09 04:17 PM, Robert Foss wrote: +static int totmaps_proc_show(struct seq_file *m, void *data) +{ +struct proc_maps_private *priv = m->private; +struct mm_struct *mm; +struct vm_area_struct *vma; +struct mem_size_stats *mss_sum = priv->mss; + +/* reference to

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Sonny Rao
On Tue, Aug 9, 2016 at 12:16 PM, Konstantin Khlebnikov wrote: > > On Tue, Aug 9, 2016 at 7:05 PM, wrote: > > From: Sonny Rao > > > > This is based on earlier work by Thiago Goncales. It implements a new > > per process proc

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Sonny Rao
On Tue, Aug 9, 2016 at 12:16 PM, Konstantin Khlebnikov wrote: > > On Tue, Aug 9, 2016 at 7:05 PM, wrote: > > From: Sonny Rao > > > > This is based on earlier work by Thiago Goncales. It implements a new > > per process proc file which summarizes the contents of the smaps file > > but doesn't

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Jann Horn
On Tue, Aug 09, 2016 at 05:01:44PM -0400, Robert Foss wrote: > On 2016-08-09 03:24 PM, Jann Horn wrote: > >On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: > >>+ down_read(>mmap_sem); > >>+ hold_task_mempolicy(priv); > >>+ > >>+ for (vma = mm->mmap; vma !=

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Jann Horn
On Tue, Aug 09, 2016 at 05:01:44PM -0400, Robert Foss wrote: > On 2016-08-09 03:24 PM, Jann Horn wrote: > >On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: > >>+ down_read(>mmap_sem); > >>+ hold_task_mempolicy(priv); > >>+ > >>+ for (vma = mm->mmap; vma !=

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Robert Foss
On 2016-08-09 03:24 PM, Jann Horn wrote: On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: From: Sonny Rao This is based on earlier work by Thiago Goncales. It implements a new per process proc file which summarizes the contents of the smaps

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Robert Foss
On 2016-08-09 03:24 PM, Jann Horn wrote: On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: From: Sonny Rao This is based on earlier work by Thiago Goncales. It implements a new per process proc file which summarizes the contents of the smaps file but doesn't display

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Robert Foss
On 2016-08-09 12:29 PM, Mateusz Guzik wrote: On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: From: Sonny Rao This is based on earlier work by Thiago Goncales. It implements a new per process proc file which summarizes the contents of the

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Robert Foss
On 2016-08-09 12:29 PM, Mateusz Guzik wrote: On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: From: Sonny Rao This is based on earlier work by Thiago Goncales. It implements a new per process proc file which summarizes the contents of the smaps file but doesn't

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Jann Horn
On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: > From: Sonny Rao > > This is based on earlier work by Thiago Goncales. It implements a new > per process proc file which summarizes the contents of the smaps file > but doesn't display any

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Jann Horn
On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: > From: Sonny Rao > > This is based on earlier work by Thiago Goncales. It implements a new > per process proc file which summarizes the contents of the smaps file > but doesn't display any addresses. It gives more

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Konstantin Khlebnikov
On Tue, Aug 9, 2016 at 7:05 PM, wrote: > From: Sonny Rao > > This is based on earlier work by Thiago Goncales. It implements a new > per process proc file which summarizes the contents of the smaps file > but doesn't display any addresses. It

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Konstantin Khlebnikov
On Tue, Aug 9, 2016 at 7:05 PM, wrote: > From: Sonny Rao > > This is based on earlier work by Thiago Goncales. It implements a new > per process proc file which summarizes the contents of the smaps file > but doesn't display any addresses. It gives more detailed information > than statm like

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Sonny Rao
On Tue, Aug 9, 2016 at 9:58 AM, Alexey Dobriyan wrote: > > On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: > > From: Sonny Rao > > > > This is based on earlier work by Thiago Goncales. It implements a new > > per process proc

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Sonny Rao
On Tue, Aug 9, 2016 at 9:58 AM, Alexey Dobriyan wrote: > > On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: > > From: Sonny Rao > > > > This is based on earlier work by Thiago Goncales. It implements a new > > per process proc file which summarizes the contents of the

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Sonny Rao
On Tue, Aug 9, 2016 at 9:29 AM, Mateusz Guzik wrote: > On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: >> From: Sonny Rao >> >> This is based on earlier work by Thiago Goncales. It implements a new >> per process proc file

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Sonny Rao
On Tue, Aug 9, 2016 at 9:29 AM, Mateusz Guzik wrote: > On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: >> From: Sonny Rao >> >> This is based on earlier work by Thiago Goncales. It implements a new >> per process proc file which summarizes the contents of the smaps

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Alexey Dobriyan
On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: > From: Sonny Rao > > This is based on earlier work by Thiago Goncales. It implements a new > per process proc file which summarizes the contents of the smaps file > but doesn't display any

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Alexey Dobriyan
On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: > From: Sonny Rao > > This is based on earlier work by Thiago Goncales. It implements a new > per process proc file which summarizes the contents of the smaps file > but doesn't display any addresses. It gives more

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Mateusz Guzik
On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: > From: Sonny Rao > > This is based on earlier work by Thiago Goncales. It implements a new > per process proc file which summarizes the contents of the smaps file > but doesn't display any

Re: [PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread Mateusz Guzik
On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.f...@collabora.com wrote: > From: Sonny Rao > > This is based on earlier work by Thiago Goncales. It implements a new > per process proc file which summarizes the contents of the smaps file > but doesn't display any addresses. It gives more

[PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread robert . foss
From: Sonny Rao This is based on earlier work by Thiago Goncales. It implements a new per process proc file which summarizes the contents of the smaps file but doesn't display any addresses. It gives more detailed information than statm like the PSS (proprotional set

[PACTH v1] mm, proc: Implement /proc//totmaps

2016-08-09 Thread robert . foss
From: Sonny Rao This is based on earlier work by Thiago Goncales. It implements a new per process proc file which summarizes the contents of the smaps file but doesn't display any addresses. It gives more detailed information than statm like the PSS (proprotional set size). It differs from the