Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust

2016-01-21 Thread Pekka Enberg
On 01/22/2016 01:12 AM, David Rientjes wrote: NACK to your patch as it is just covering up buggy code silently. The problem needs to be addressed in change_memory_common() to return if there is no size to change (numpages == 0). It's a two line fix to that function. So add a WARN_ON there

Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust

2016-01-21 Thread Mika Penttilä
On 01/22/2016 01:12 AM, David Rientjes wrote: > On Thu, 21 Jan 2016, Mika Penttilä wrote: > >> Recent changes (4.4.0+) in module loader triggered oops on ARM : >> >> The module in question is in-tree module : >> drivers/misc/ti-st/st_drv.ko >> >> The BUG is here : >> >> [ 53.638335]

Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust

2016-01-21 Thread David Rientjes
On Thu, 21 Jan 2016, Mika Penttilä wrote: > Recent changes (4.4.0+) in module loader triggered oops on ARM : > > The module in question is in-tree module : > drivers/misc/ti-st/st_drv.ko > > The BUG is here : > > [ 53.638335] [ cut here ] > [ 53.642967] kernel BUG at

Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust

2016-01-21 Thread David Rientjes
On Thu, 21 Jan 2016, Mika Penttilä wrote: > Recent changes (4.4.0+) in module loader triggered oops on ARM : > > The module in question is in-tree module : > drivers/misc/ti-st/st_drv.ko > > The BUG is here : > > [ 53.638335] [ cut here ] > [ 53.642967] kernel BUG at

Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust

2016-01-21 Thread Mika Penttilä
On 01/22/2016 01:12 AM, David Rientjes wrote: > On Thu, 21 Jan 2016, Mika Penttilä wrote: > >> Recent changes (4.4.0+) in module loader triggered oops on ARM : >> >> The module in question is in-tree module : >> drivers/misc/ti-st/st_drv.ko >> >> The BUG is here : >> >> [ 53.638335]

Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust

2016-01-21 Thread Pekka Enberg
On 01/22/2016 01:12 AM, David Rientjes wrote: NACK to your patch as it is just covering up buggy code silently. The problem needs to be addressed in change_memory_common() to return if there is no size to change (numpages == 0). It's a two line fix to that function. So add a WARN_ON there

[PATCH, REGRESSION v3] mm: make apply_to_page_range more robust

2016-01-20 Thread Mika Penttilä
Recent changes (4.4.0+) in module loader triggered oops on ARM : The module in question is in-tree module : drivers/misc/ti-st/st_drv.ko The BUG is here : [ 53.638335] [ cut here ] [ 53.642967] kernel BUG at mm/memory.c:1878! [ 53.647153] Internal error: Oops - BUG: 0

[PATCH, REGRESSION v3] mm: make apply_to_page_range more robust

2016-01-20 Thread Mika Penttilä
Recent changes (4.4.0+) in module loader triggered oops on ARM : The module in question is in-tree module : drivers/misc/ti-st/st_drv.ko The BUG is here : [ 53.638335] [ cut here ] [ 53.642967] kernel BUG at mm/memory.c:1878! [ 53.647153] Internal error: Oops - BUG: 0