Re: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess

2019-05-30 Thread Christoph Hellwig
On Thu, May 30, 2019 at 01:46:18AM +, Maciej Rozycki wrote: > > +#if defined(__BYTE_ORDER__) && __BYTE_ORDER__ != __ORDER_BIG_ENDIAN__ > > +#error "Unsupported endianess, check your toolchain" > > Typo here: s/endianess/endianness/. The original patch has already been merged, please send a

Re: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess

2019-05-29 Thread Maciej Rozycki
On Fri, 12 Apr 2019, Christoph Hellwig wrote: > diff --git a/include/uapi/linux/byteorder/big_endian.h > b/include/uapi/linux/byteorder/big_endian.h > index 2199adc6a6c2..34a5864526d2 100644 > --- a/include/uapi/linux/byteorder/big_endian.h > +++ b/include/uapi/linux/byteorder/big_endian.h > @@

Re: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess

2019-05-15 Thread Arnd Bergmann
On Mon, May 13, 2019 at 2:04 PM Christoph Hellwig wrote: > > On Mon, May 13, 2019 at 01:50:19PM +0200, Dmitry Vyukov wrote: > > > We did have some bugs in the past (~1-2 y/ago) but AFAIK they are all > > > fixed now. These days I build most of my kernels with a bi-endian 64-bit > > > toolchain,

Re: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess

2019-05-13 Thread Christoph Hellwig
On Mon, May 13, 2019 at 01:50:19PM +0200, Dmitry Vyukov wrote: > > We did have some bugs in the past (~1-2 y/ago) but AFAIK they are all > > fixed now. These days I build most of my kernels with a bi-endian 64-bit > > toolchain, and switching endian without running `make clean` also works. > >

Re: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess

2019-05-13 Thread Dmitry Vyukov
From: Michael Ellerman Date: Mon, May 13, 2019 at 1:33 PM To: Dmitry Vyukov, Arnd Bergmann Cc: Nick Kossifidis, Christoph Hellwig, Linus Torvalds, Andrew Morton, linux-arch, Linux Kernel Mailing List, linuxppc-dev > Dmitry Vyukov writes: > > From: Arnd Bergmann > > Date: Sat, May 11, 2019 at

Re: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess

2019-05-13 Thread Michael Ellerman
Dmitry Vyukov writes: > From: Arnd Bergmann > Date: Sat, May 11, 2019 at 2:51 AM > To: Dmitry Vyukov > Cc: Nick Kossifidis, Christoph Hellwig, Linus Torvalds, Andrew Morton, > linux-arch, Linux Kernel Mailing List, linuxppc-dev > >> On Fri, May 10, 2019 at 6:53 AM Dmitry Vyukov wrote: >> > > >>

Re: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess

2019-05-13 Thread Dmitry Vyukov
From: Arnd Bergmann Date: Sat, May 11, 2019 at 2:51 AM To: Dmitry Vyukov Cc: Nick Kossifidis, Christoph Hellwig, Linus Torvalds, Andrew Morton, linux-arch, Linux Kernel Mailing List, linuxppc-dev > On Fri, May 10, 2019 at 6:53 AM Dmitry Vyukov wrote: > > > > > > I think it's good to have a

Re: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess

2019-05-10 Thread Arnd Bergmann
On Fri, May 10, 2019 at 6:53 AM Dmitry Vyukov wrote: > > > > I think it's good to have a sanity check in-place for consistency. > > > Hi, > > This broke our cross-builds from x86. I am using: > > $ powerpc64le-linux-gnu-gcc --version > powerpc64le-linux-gnu-gcc (Debian 7.2.0-7) 7.2.0 > > and it

Re: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess

2019-05-10 Thread Dmitry Vyukov
From: Nick Kossifidis Date: Fri, Apr 12, 2019 at 6:08 PM To: Arnd Bergmann Cc: Christoph Hellwig, Linus Torvalds, Andrew Morton, linux-arch, , Linux Kernel Mailing List > Στις 2019-04-12 17:53, Arnd Bergmann έγραψε: > > On Fri, Apr 12, 2019 at 4:36 PM Christoph Hellwig wrote: > >> > >> When

Re: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess

2019-04-12 Thread Nick Kossifidis
Στις 2019-04-12 17:53, Arnd Bergmann έγραψε: On Fri, Apr 12, 2019 at 4:36 PM Christoph Hellwig wrote: When removing some dead big endian checks in the RISC-V code Nick suggested that we should have some generic sanity checks. I don't think we should have thos inside the RISC-V code, but

Re: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess

2019-04-12 Thread Arnd Bergmann
On Fri, Apr 12, 2019 at 4:55 PM Christoph Hellwig wrote: > > On Fri, Apr 12, 2019 at 04:53:28PM +0200, Arnd Bergmann wrote: > > On Fri, Apr 12, 2019 at 4:36 PM Christoph Hellwig wrote: > > > > > > When removing some dead big endian checks in the RISC-V code Nick > > > suggested that we should

Re: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess

2019-04-12 Thread Christoph Hellwig
On Fri, Apr 12, 2019 at 04:53:28PM +0200, Arnd Bergmann wrote: > On Fri, Apr 12, 2019 at 4:36 PM Christoph Hellwig wrote: > > > > When removing some dead big endian checks in the RISC-V code Nick > > suggested that we should have some generic sanity checks. I don't think > > we should have thos

Re: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess

2019-04-12 Thread Arnd Bergmann
On Fri, Apr 12, 2019 at 4:36 PM Christoph Hellwig wrote: > > When removing some dead big endian checks in the RISC-V code Nick > suggested that we should have some generic sanity checks. I don't think > we should have thos inside the RISC-V code, but maybe it might make > sense to have these in

[PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess

2019-04-12 Thread Christoph Hellwig
When removing some dead big endian checks in the RISC-V code Nick suggested that we should have some generic sanity checks. I don't think we should have thos inside the RISC-V code, but maybe it might make sense to have these in the generic byteorder headers. Note that these are UAPI headers and