Re: [PATCH, RFC 0/9] Introduce huge zero page

2012-08-16 Thread Andi Kleen
> Because this is done the right way (i.e. to allocate an hugepage at > the first wp fault, and to fallback exclusively if compaction fails) > it will help much less than the 4k zero pages if the zero pages are The main benefit is that you have a zero page with THP enabled. So it lowers the cost

Re: [PATCH, RFC 0/9] Introduce huge zero page

2012-08-16 Thread H. Peter Anvin
On 08/16/2012 12:40 PM, Andrea Arcangeli wrote: > Hi Andrew, > > On Thu, Aug 16, 2012 at 12:20:23PM -0700, Andrew Morton wrote: >> That's a pretty big improvement for a rather fake test case. I wonder >> how much benefit we'd see with real workloads? > > The same discussion happened about the

Re: [PATCH, RFC 0/9] Introduce huge zero page

2012-08-16 Thread Andrea Arcangeli
Hi Andrew, On Thu, Aug 16, 2012 at 12:20:23PM -0700, Andrew Morton wrote: > That's a pretty big improvement for a rather fake test case. I wonder > how much benefit we'd see with real workloads? The same discussion happened about the zero page in general and there's no easy answer. I seem to

Re: [PATCH, RFC 0/9] Introduce huge zero page

2012-08-16 Thread Andrew Morton
On Thu, 9 Aug 2012 12:08:11 +0300 "Kirill A. Shutemov" wrote: > During testing I noticed big (up to 2.5 times) memory consumption overhead > on some workloads (e.g. ft.A from NPB) if THP is enabled. > > The main reason for that big difference is lacking zero page in THP case. > We have to

Re: [PATCH, RFC 0/9] Introduce huge zero page

2012-08-16 Thread Andrew Morton
On Thu, 9 Aug 2012 12:08:11 +0300 Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: During testing I noticed big (up to 2.5 times) memory consumption overhead on some workloads (e.g. ft.A from NPB) if THP is enabled. The main reason for that big difference is lacking zero page in

Re: [PATCH, RFC 0/9] Introduce huge zero page

2012-08-16 Thread Andrea Arcangeli
Hi Andrew, On Thu, Aug 16, 2012 at 12:20:23PM -0700, Andrew Morton wrote: That's a pretty big improvement for a rather fake test case. I wonder how much benefit we'd see with real workloads? The same discussion happened about the zero page in general and there's no easy answer. I seem to

Re: [PATCH, RFC 0/9] Introduce huge zero page

2012-08-16 Thread H. Peter Anvin
On 08/16/2012 12:40 PM, Andrea Arcangeli wrote: Hi Andrew, On Thu, Aug 16, 2012 at 12:20:23PM -0700, Andrew Morton wrote: That's a pretty big improvement for a rather fake test case. I wonder how much benefit we'd see with real workloads? The same discussion happened about the zero page

Re: [PATCH, RFC 0/9] Introduce huge zero page

2012-08-16 Thread Andi Kleen
Because this is done the right way (i.e. to allocate an hugepage at the first wp fault, and to fallback exclusively if compaction fails) it will help much less than the 4k zero pages if the zero pages are The main benefit is that you have a zero page with THP enabled. So it lowers the cost of

Re: [PATCH, RFC 0/9] Introduce huge zero page

2012-08-10 Thread Kirill A. Shutemov
On Fri, Aug 10, 2012 at 11:49:12AM +0800, Wanpeng Li wrote: > On Thu, Aug 09, 2012 at 12:08:11PM +0300, Kirill A. Shutemov wrote: > >From: "Kirill A. Shutemov" > > > >During testing I noticed big (up to 2.5 times) memory consumption overhead > >on some workloads (e.g. ft.A from NPB) if THP is

Re: [PATCH, RFC 0/9] Introduce huge zero page

2012-08-10 Thread Kirill A. Shutemov
On Fri, Aug 10, 2012 at 11:49:12AM +0800, Wanpeng Li wrote: On Thu, Aug 09, 2012 at 12:08:11PM +0300, Kirill A. Shutemov wrote: From: Kirill A. Shutemov kirill.shute...@linux.intel.com During testing I noticed big (up to 2.5 times) memory consumption overhead on some workloads (e.g. ft.A

[PATCH, RFC 0/9] Introduce huge zero page

2012-08-09 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" During testing I noticed big (up to 2.5 times) memory consumption overhead on some workloads (e.g. ft.A from NPB) if THP is enabled. The main reason for that big difference is lacking zero page in THP case. We have to allocate a real page on read page fault. A

[PATCH, RFC 0/9] Introduce huge zero page

2012-08-09 Thread Kirill A. Shutemov
From: Kirill A. Shutemov kirill.shute...@linux.intel.com During testing I noticed big (up to 2.5 times) memory consumption overhead on some workloads (e.g. ft.A from NPB) if THP is enabled. The main reason for that big difference is lacking zero page in THP case. We have to allocate a real page