Re: [PATCH,RFC] pci: do not mark exported functions as __devinit

2007-03-02 Thread Greg KH
On Sat, Mar 03, 2007 at 12:02:14AM +0100, Sam Ravnborg wrote: > > > > Yes, we allow them to be exported globally, as other init code might > > need to call them, like these functions. > > > > So yes, I think we need to find a way to fix the warning tools, as the > > code is correct here. > >

Re: [PATCH,RFC] pci: do not mark exported functions as __devinit

2007-03-02 Thread Sam Ravnborg
> > Yes, we allow them to be exported globally, as other init code might > need to call them, like these functions. > > So yes, I think we need to find a way to fix the warning tools, as the > code is correct here. This was the patch that I made to ignore these. It is on top of other pending

Re: [PATCH,RFC] pci: do not mark exported functions as __devinit

2007-03-02 Thread Sam Ravnborg
On Fri, Mar 02, 2007 at 12:47:52PM -0800, Greg KH wrote: > On Tue, Feb 27, 2007 at 10:27:02AM +0100, Sam Ravnborg wrote: > > Functions marked __devinit will be removed after kernel init. > > But being exported they are potentially called by a module > > much later. > > So the safer choice seems to

Re: [PATCH,RFC] pci: do not mark exported functions as __devinit

2007-03-02 Thread Greg KH
On Tue, Feb 27, 2007 at 10:27:02AM +0100, Sam Ravnborg wrote: > Functions marked __devinit will be removed after kernel init. > But being exported they are potentially called by a module > much later. > So the safer choice seems to be to keep the function even > in the non CONFIG_HOTPLUG case. >

Re: [PATCH,RFC] pci: do not mark exported functions as __devinit

2007-03-02 Thread Greg KH
On Tue, Feb 27, 2007 at 10:27:02AM +0100, Sam Ravnborg wrote: Functions marked __devinit will be removed after kernel init. But being exported they are potentially called by a module much later. So the safer choice seems to be to keep the function even in the non CONFIG_HOTPLUG case. This

Re: [PATCH,RFC] pci: do not mark exported functions as __devinit

2007-03-02 Thread Sam Ravnborg
On Fri, Mar 02, 2007 at 12:47:52PM -0800, Greg KH wrote: On Tue, Feb 27, 2007 at 10:27:02AM +0100, Sam Ravnborg wrote: Functions marked __devinit will be removed after kernel init. But being exported they are potentially called by a module much later. So the safer choice seems to be to

Re: [PATCH,RFC] pci: do not mark exported functions as __devinit

2007-03-02 Thread Sam Ravnborg
Yes, we allow them to be exported globally, as other init code might need to call them, like these functions. So yes, I think we need to find a way to fix the warning tools, as the code is correct here. This was the patch that I made to ignore these. It is on top of other pending changes

Re: [PATCH,RFC] pci: do not mark exported functions as __devinit

2007-03-02 Thread Greg KH
On Sat, Mar 03, 2007 at 12:02:14AM +0100, Sam Ravnborg wrote: Yes, we allow them to be exported globally, as other init code might need to call them, like these functions. So yes, I think we need to find a way to fix the warning tools, as the code is correct here. This was the

[PATCH,RFC] pci: do not mark exported functions as __devinit

2007-02-27 Thread Sam Ravnborg
Functions marked __devinit will be removed after kernel init. But being exported they are potentially called by a module much later. So the safer choice seems to be to keep the function even in the non CONFIG_HOTPLUG case. This silence the follwoing section mismatch warnings: WARNING:

[PATCH,RFC] pci: do not mark exported functions as __devinit

2007-02-27 Thread Sam Ravnborg
Functions marked __devinit will be removed after kernel init. But being exported they are potentially called by a module much later. So the safer choice seems to be to keep the function even in the non CONFIG_HOTPLUG case. This silence the follwoing section mismatch warnings: WARNING: