Re: [PATCH/RFC] iio: hi8435: do not enable all events by default

On Mon, May 29, 2017 at 7:40 AM, Nikita Yushchenko wrote: > They originally wanted gpio-style access to use with userspace > polling, and were not pleased with entire IIO thing. The GPIO userspace ABI supports events with timestamps. tools/gpio/gpio-event-mon.c

Re: [PATCH/RFC] iio: hi8435: do not enable all events by default

On Mon, May 29, 2017 at 7:40 AM, Nikita Yushchenko wrote: > They originally wanted gpio-style access to use with userspace > polling, and were not pleased with entire IIO thing. The GPIO userspace ABI supports events with timestamps. tools/gpio/gpio-event-mon.c Yours, Linus Walleij

Re: [PATCH/RFC] iio: hi8435: do not enable all events by default

On Mon, 29 May 2017 08:40:26 +0300 Nikita Yushchenko wrote: > >> Still, isn't there subsystem-level default that all events are disabled > >> by default? If such, then current hi8435 state breaks subsystem-level > >> rules, which is a [userspace-visible] bug.

Re: [PATCH/RFC] iio: hi8435: do not enable all events by default

On Mon, 29 May 2017 08:40:26 +0300 Nikita Yushchenko wrote: > >> Still, isn't there subsystem-level default that all events are disabled > >> by default? If such, then current hi8435 state breaks subsystem-level > >> rules, which is a [userspace-visible] bug. I'm not sure how far should > >>

Re: [PATCH/RFC] iio: hi8435: do not enable all events by default

>> Still, isn't there subsystem-level default that all events are disabled >> by default? If such, then current hi8435 state breaks subsystem-level >> rules, which is a [userspace-visible] bug. I'm not sure how far should >> we go in bug compatibility. > > It is indeed the subsystem default (as

Re: [PATCH/RFC] iio: hi8435: do not enable all events by default

>> Still, isn't there subsystem-level default that all events are disabled >> by default? If such, then current hi8435 state breaks subsystem-level >> rules, which is a [userspace-visible] bug. I'm not sure how far should >> we go in bug compatibility. > > It is indeed the subsystem default (as

Re: Fw: [PATCH/RFC] iio: hi8435: do not enable all events by default

n; Peter Meerwald-Stadler; Sanchayan > Maity; Gregor Boirie; Matt Ranostay; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org; Chris Healy; Jeff White; Vladimir Barinov > Subject: Re: [PATCH/RFC] iio: hi8435: do not enable all events by default > > On Thu, 25 May

Re: Fw: [PATCH/RFC] iio: hi8435: do not enable all events by default

oirie; Matt Ranostay; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org; Chris Healy; Jeff White; Vladimir Barinov > Subject: Re: [PATCH/RFC] iio: hi8435: do not enable all events by default > > On Thu, 25 May 2017 08:47:47 +0300 > Nikita Yushchenko wrote: > >> 24.05.

Re: [PATCH/RFC] iio: hi8435: do not enable all events by default

On Thu, 25 May 2017 08:47:47 +0300 Nikita Yushchenko wrote: > 24.05.2017 22:27, Jonathan Cameron wrote: > > On Tue, 23 May 2017 11:08:30 +0300 > > Nikita Yushchenko wrote: > > > >> Having all events enabled by default is

Re: [PATCH/RFC] iio: hi8435: do not enable all events by default

On Thu, 25 May 2017 08:47:47 +0300 Nikita Yushchenko wrote: > 24.05.2017 22:27, Jonathan Cameron wrote: > > On Tue, 23 May 2017 11:08:30 +0300 > > Nikita Yushchenko wrote: > > > >> Having all events enabled by default is misleading. > >> Userspace should explicitly enable events they want to

Re: [PATCH/RFC] iio: hi8435: do not enable all events by default

24.05.2017 22:27, Jonathan Cameron wrote: > On Tue, 23 May 2017 11:08:30 +0300 > Nikita Yushchenko wrote: > >> Having all events enabled by default is misleading. >> Userspace should explicitly enable events they want to receive. >> >> Signed-off-by: Nikita

Re: [PATCH/RFC] iio: hi8435: do not enable all events by default

24.05.2017 22:27, Jonathan Cameron wrote: > On Tue, 23 May 2017 11:08:30 +0300 > Nikita Yushchenko wrote: > >> Having all events enabled by default is misleading. >> Userspace should explicitly enable events they want to receive. >> >> Signed-off-by: Nikita Yushchenko > I agree in principle,

Re: [PATCH/RFC] iio: hi8435: do not enable all events by default

On Tue, 23 May 2017 11:08:30 +0300 Nikita Yushchenko wrote: > Having all events enabled by default is misleading. > Userspace should explicitly enable events they want to receive. > > Signed-off-by: Nikita Yushchenko I agree in

Re: [PATCH/RFC] iio: hi8435: do not enable all events by default

On Tue, 23 May 2017 11:08:30 +0300 Nikita Yushchenko wrote: > Having all events enabled by default is misleading. > Userspace should explicitly enable events they want to receive. > > Signed-off-by: Nikita Yushchenko I agree in principle, but this is a userspace ABI change. Sadly we can't do

[PATCH/RFC] iio: hi8435: do not enable all events by default

Having all events enabled by default is misleading. Userspace should explicitly enable events they want to receive. Signed-off-by: Nikita Yushchenko --- drivers/iio/adc/hi8435.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/iio/adc/hi8435.c

[PATCH/RFC] iio: hi8435: do not enable all events by default

Having all events enabled by default is misleading. Userspace should explicitly enable events they want to receive. Signed-off-by: Nikita Yushchenko --- drivers/iio/adc/hi8435.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/iio/adc/hi8435.c b/drivers/iio/adc/hi8435.c index