Re: [PATCH/RFC 02/16] perf top: Fix and cleanup perf_top__record_precise_ip()

2015-12-10 Thread Namhyung Kim
Hi Arnaldo, On Thu, Dec 10, 2015 at 04:04:17PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 10, 2015 at 04:53:21PM +0900, Namhyung Kim escreveu: > > At first, it has duplicate ui__has_annotation() and 'sort__has_sym' > > and 'use_browser' check. In fact, the ui__has_annotation() should

Re: [PATCH/RFC 02/16] perf top: Fix and cleanup perf_top__record_precise_ip()

2015-12-10 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 10, 2015 at 04:53:21PM +0900, Namhyung Kim escreveu: > At first, it has duplicate ui__has_annotation() and 'sort__has_sym' > and 'use_browser' check. In fact, the ui__has_annotation() should be > removed as it needs to annotate on --stdio as well. And the > top->sym_filter_entry is

Re: [PATCH/RFC 02/16] perf top: Fix and cleanup perf_top__record_precise_ip()

2015-12-10 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 10, 2015 at 04:53:21PM +0900, Namhyung Kim escreveu: > At first, it has duplicate ui__has_annotation() and 'sort__has_sym' > and 'use_browser' check. In fact, the ui__has_annotation() should be > removed as it needs to annotate on --stdio as well. And the > top->sym_filter_entry is

Re: [PATCH/RFC 02/16] perf top: Fix and cleanup perf_top__record_precise_ip()

2015-12-10 Thread Namhyung Kim
Hi Arnaldo, On Thu, Dec 10, 2015 at 04:04:17PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 10, 2015 at 04:53:21PM +0900, Namhyung Kim escreveu: > > At first, it has duplicate ui__has_annotation() and 'sort__has_sym' > > and 'use_browser' check. In fact, the ui__has_annotation() should

[PATCH/RFC 02/16] perf top: Fix and cleanup perf_top__record_precise_ip()

2015-12-09 Thread Namhyung Kim
At first, it has duplicate ui__has_annotation() and 'sort__has_sym' and 'use_browser' check. In fact, the ui__has_annotation() should be removed as it needs to annotate on --stdio as well. And the top->sym_filter_entry is used only for stdio mode, so make it clear on the condition too. Also the

[PATCH/RFC 02/16] perf top: Fix and cleanup perf_top__record_precise_ip()

2015-12-09 Thread Namhyung Kim
At first, it has duplicate ui__has_annotation() and 'sort__has_sym' and 'use_browser' check. In fact, the ui__has_annotation() should be removed as it needs to annotate on --stdio as well. And the top->sym_filter_entry is used only for stdio mode, so make it clear on the condition too. Also the