Re: [PATCH/RFC 17/17] tracing/uprobes: Add @+file_offset fetch method

2013-12-03 Thread Masami Hiramatsu
(2013/12/03 15:23), Namhyung Kim wrote: >>> So do you want me to change to make it simpler without a fetch_param? >> >> Yes, yes. Assuming that you agree, of course. > > Okay, here goes v8 then. :) > > I also push it (with other changes come from Srikar) to the > uprobe/fetch-v8 branch in my

Re: [PATCH/RFC 17/17] tracing/uprobes: Add @+file_offset fetch method

2013-12-03 Thread Masami Hiramatsu
(2013/12/03 15:23), Namhyung Kim wrote: So do you want me to change to make it simpler without a fetch_param? Yes, yes. Assuming that you agree, of course. Okay, here goes v8 then. :) I also push it (with other changes come from Srikar) to the uprobe/fetch-v8 branch in my tree for your

Re: [PATCH/RFC 17/17] tracing/uprobes: Add @+file_offset fetch method

2013-12-02 Thread Namhyung Kim
>> So do you want me to change to make it simpler without a fetch_param? > > Yes, yes. Assuming that you agree, of course. Okay, here goes v8 then. :) I also push it (with other changes come from Srikar) to the uprobe/fetch-v8 branch in my tree for your convenience. :) Thanks, Namhyung >From

Re: [PATCH/RFC 17/17] tracing/uprobes: Add @+file_offset fetch method

2013-12-02 Thread Namhyung Kim
So do you want me to change to make it simpler without a fetch_param? Yes, yes. Assuming that you agree, of course. Okay, here goes v8 then. :) I also push it (with other changes come from Srikar) to the uprobe/fetch-v8 branch in my tree for your convenience. :) Thanks, Namhyung From

Re: [PATCH/RFC 17/17] tracing/uprobes: Add @+file_offset fetch method

2013-11-29 Thread Oleg Nesterov
Hi Namhyung, On 11/29, Namhyung Kim wrote: > > Hi Oleg, > > On Thu, 28 Nov 2013 17:31:48 +0100, Oleg Nesterov wrote: > > On 11/28, Namhyung Kim wrote: > >> > >> I thought we need a fetch_param anyway if we will add support for > >> cross-fetch later. But I won't insist it strongly, I can delay

Re: [PATCH/RFC 17/17] tracing/uprobes: Add @+file_offset fetch method

2013-11-29 Thread Oleg Nesterov
Hi Namhyung, On 11/29, Namhyung Kim wrote: Hi Oleg, On Thu, 28 Nov 2013 17:31:48 +0100, Oleg Nesterov wrote: On 11/28, Namhyung Kim wrote: I thought we need a fetch_param anyway if we will add support for cross-fetch later. But I won't insist it strongly, I can delay it to later

Re: [PATCH/RFC 17/17] tracing/uprobes: Add @+file_offset fetch method

2013-11-28 Thread Namhyung Kim
Hi Oleg, On Thu, 28 Nov 2013 17:31:48 +0100, Oleg Nesterov wrote: > On 11/28, Namhyung Kim wrote: >> >> I thought we need a fetch_param anyway if we will add support for >> cross-fetch later. But I won't insist it strongly, I can delay it to >> later work and make current code simpler if you

Re: [PATCH/RFC 17/17] tracing/uprobes: Add @+file_offset fetch method

2013-11-28 Thread Oleg Nesterov
On 11/28, Namhyung Kim wrote: > > I thought we need a fetch_param anyway if we will add support for > cross-fetch later. But I won't insist it strongly, I can delay it to > later work and make current code simpler if you want. :) OK, great, > >> static int uprobe_dispatcher(struct

Re: [PATCH/RFC 17/17] tracing/uprobes: Add @+file_offset fetch method

2013-11-28 Thread Oleg Nesterov
On 11/28, Namhyung Kim wrote: I thought we need a fetch_param anyway if we will add support for cross-fetch later. But I won't insist it strongly, I can delay it to later work and make current code simpler if you want. :) OK, great, static int uprobe_dispatcher(struct uprobe_consumer

Re: [PATCH/RFC 17/17] tracing/uprobes: Add @+file_offset fetch method

2013-11-28 Thread Namhyung Kim
Hi Oleg, On Thu, 28 Nov 2013 17:31:48 +0100, Oleg Nesterov wrote: On 11/28, Namhyung Kim wrote: I thought we need a fetch_param anyway if we will add support for cross-fetch later. But I won't insist it strongly, I can delay it to later work and make current code simpler if you want. :)

Re: [PATCH/RFC 17/17] tracing/uprobes: Add @+file_offset fetch method

2013-11-27 Thread Namhyung Kim
Hi Oleg, On Wed, 27 Nov 2013 19:55:46 +0100, Oleg Nesterov wrote: > Hi Namhyung, > > I'll certainly try to read (and even apply ;) this series carefully. Thanks in advance. :) > > But let me make a couple of nits right now, even if I do not understand > this code yet. Okay. > > On 11/27,

Re: [PATCH/RFC 17/17] tracing/uprobes: Add @+file_offset fetch method

2013-11-27 Thread Oleg Nesterov
Hi Namhyung, I'll certainly try to read (and even apply ;) this series carefully. But let me make a couple of nits right now, even if I do not understand this code yet. On 11/27, Namhyung Kim wrote: > > + } else if (arg[1] == '+') { > + struct

Re: [PATCH/RFC 17/17] tracing/uprobes: Add @+file_offset fetch method

2013-11-27 Thread Oleg Nesterov
Hi Namhyung, I'll certainly try to read (and even apply ;) this series carefully. But let me make a couple of nits right now, even if I do not understand this code yet. On 11/27, Namhyung Kim wrote: + } else if (arg[1] == '+') { + struct

Re: [PATCH/RFC 17/17] tracing/uprobes: Add @+file_offset fetch method

2013-11-27 Thread Namhyung Kim
Hi Oleg, On Wed, 27 Nov 2013 19:55:46 +0100, Oleg Nesterov wrote: Hi Namhyung, I'll certainly try to read (and even apply ;) this series carefully. Thanks in advance. :) But let me make a couple of nits right now, even if I do not understand this code yet. Okay. On 11/27, Namhyung Kim

[PATCH/RFC 17/17] tracing/uprobes: Add @+file_offset fetch method

2013-11-26 Thread Namhyung Kim
From: Namhyung Kim Enable to fetch data from a file offset. Currently it only supports fetching from same binary uprobe set. It'll translate the file offset to a proper virtual address in the process. The syntax is "@+OFFSET" as it does similar to normal memory fetching (@ADDR) which does no

[PATCH/RFC 17/17] tracing/uprobes: Add @+file_offset fetch method

2013-11-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com Enable to fetch data from a file offset. Currently it only supports fetching from same binary uprobe set. It'll translate the file offset to a proper virtual address in the process. The syntax is @+OFFSET as it does similar to normal memory fetching