Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

2008-02-11 Thread Kyle McMartin
On Mon, Feb 11, 2008 at 05:23:33PM +0100, Roel Kluin wrote: > How about just doing something like this: diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c index 9448d4e..63f9b7f 100644 --- a/arch/parisc/kernel/pci-dma.c +++ b/arch/parisc/kernel/pci-dma.c @@ -409,7 +409,7 @@

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

2008-02-11 Thread Roel Kluin
James Bottomley wrote: > On Mon, 2008-02-11 at 17:23 +0100, Roel Kluin wrote: >> duplicate pa11_dma_alloc_consistent; more appropriate appears >> pa11_dma_alloc_noncoherent here. >> >> Not tested, please confirm that this fix is correct > > No, it looks completely incorrect to me. What makes

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

2008-02-11 Thread James Bottomley
On Mon, 2008-02-11 at 09:42 -0700, Matthew Wilcox wrote: > On Mon, Feb 11, 2008 at 05:23:33PM +0100, Roel Kluin wrote: > > duplicate pa11_dma_alloc_consistent; more appropriate appears > > pa11_dma_alloc_noncoherent here. > > > > Not tested, please confirm that this fix is correct > > I don't

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

2008-02-11 Thread Roel Kluin
Matthew Wilcox wrote: > On Mon, Feb 11, 2008 at 05:23:33PM +0100, Roel Kluin wrote: >> duplicate pa11_dma_alloc_consistent; more appropriate appears >> pa11_dma_alloc_noncoherent here. >> >> Not tested, please confirm that this fix is correct > > I don't think it is. The memories are fading, so

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

2008-02-11 Thread James Bottomley
On Mon, 2008-02-11 at 17:23 +0100, Roel Kluin wrote: > duplicate pa11_dma_alloc_consistent; more appropriate appears > pa11_dma_alloc_noncoherent here. > > Not tested, please confirm that this fix is correct No, it looks completely incorrect to me. What makes you think a pcxl box has a

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

2008-02-11 Thread Matthew Wilcox
On Mon, Feb 11, 2008 at 05:23:33PM +0100, Roel Kluin wrote: > duplicate pa11_dma_alloc_consistent; more appropriate appears > pa11_dma_alloc_noncoherent here. > > Not tested, please confirm that this fix is correct I don't think it is. The memories are fading, so I don't recall why it is we do

[PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

2008-02-11 Thread Roel Kluin
duplicate pa11_dma_alloc_consistent; more appropriate appears pa11_dma_alloc_noncoherent here. Not tested, please confirm that this fix is correct --- fix noncoherent allocation Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/parisc/kernel/pci-dma.c

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

2008-02-11 Thread Roel Kluin
James Bottomley wrote: On Mon, 2008-02-11 at 17:23 +0100, Roel Kluin wrote: duplicate pa11_dma_alloc_consistent; more appropriate appears pa11_dma_alloc_noncoherent here. Not tested, please confirm that this fix is correct No, it looks completely incorrect to me. What makes you think a

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

2008-02-11 Thread James Bottomley
On Mon, 2008-02-11 at 09:42 -0700, Matthew Wilcox wrote: On Mon, Feb 11, 2008 at 05:23:33PM +0100, Roel Kluin wrote: duplicate pa11_dma_alloc_consistent; more appropriate appears pa11_dma_alloc_noncoherent here. Not tested, please confirm that this fix is correct I don't think it

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

2008-02-11 Thread James Bottomley
On Mon, 2008-02-11 at 17:23 +0100, Roel Kluin wrote: duplicate pa11_dma_alloc_consistent; more appropriate appears pa11_dma_alloc_noncoherent here. Not tested, please confirm that this fix is correct No, it looks completely incorrect to me. What makes you think a pcxl box has a problem

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

2008-02-11 Thread Matthew Wilcox
On Mon, Feb 11, 2008 at 05:23:33PM +0100, Roel Kluin wrote: duplicate pa11_dma_alloc_consistent; more appropriate appears pa11_dma_alloc_noncoherent here. Not tested, please confirm that this fix is correct I don't think it is. The memories are fading, so I don't recall why it is we do it

[PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

2008-02-11 Thread Roel Kluin
duplicate pa11_dma_alloc_consistent; more appropriate appears pa11_dma_alloc_noncoherent here. Not tested, please confirm that this fix is correct --- fix noncoherent allocation Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/parisc/kernel/pci-dma.c

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

2008-02-11 Thread Roel Kluin
Matthew Wilcox wrote: On Mon, Feb 11, 2008 at 05:23:33PM +0100, Roel Kluin wrote: duplicate pa11_dma_alloc_consistent; more appropriate appears pa11_dma_alloc_noncoherent here. Not tested, please confirm that this fix is correct I don't think it is. The memories are fading, so I don't

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

2008-02-11 Thread Kyle McMartin
On Mon, Feb 11, 2008 at 05:23:33PM +0100, Roel Kluin wrote: How about just doing something like this: diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c index 9448d4e..63f9b7f 100644 --- a/arch/parisc/kernel/pci-dma.c +++ b/arch/parisc/kernel/pci-dma.c @@ -409,7 +409,7 @@