Re: [PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port

2007-06-24 Thread Wang Zhenyu
On 2007.06.23 11:50:49 +, Andrew Morton wrote: > On Sat, 23 Jun 2007 14:42:21 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > > > > I probably _could_ work this out, and kinda did with a bit of > > list-trolling > > > (verdict: needed in 2.6.22) but please, take care to describe the > > > im

Re: [PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port

2007-06-23 Thread Dave Jones
On Sat, Jun 23, 2007 at 11:50:49AM -0700, Andrew Morton wrote: > On Sat, 23 Jun 2007 14:42:21 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > > > > I probably _could_ work this out, and kinda did with a bit of > > list-trolling > > > (verdict: needed in 2.6.22) but please, take care to descr

Re: [PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port

2007-06-23 Thread Andrew Morton
On Sat, 23 Jun 2007 14:42:21 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > > I probably _could_ work this out, and kinda did with a bit of list-trolling > > (verdict: needed in 2.6.22) but please, take care to describe the > > importance of a patch in the changelog? > > This got merged a day o

Re: [PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port

2007-06-23 Thread Dave Jones
On Sat, Jun 23, 2007 at 09:52:03AM -0700, Andrew Morton wrote: > > On Thu, 21 Jun 2007 13:43:18 +0800 Wang Zhenyu <[EMAIL PROTECTED]> wrote: > > Thanks Carlo to report this problem. The following patch should fix > > his and potential issue. > > > > [AGPGART] intel_agp: don't load if no IGD d

Re: [PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port

2007-06-23 Thread Andrew Morton
> On Thu, 21 Jun 2007 13:43:18 +0800 Wang Zhenyu <[EMAIL PROTECTED]> wrote: > Thanks Carlo to report this problem. The following patch should fix > his and potential issue. > > [AGPGART] intel_agp: don't load if no IGD detected and no AGP port > > After i915 chip, GMCH has no AGP port. Origin bri

Re: [PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port

2007-06-21 Thread Wang Zhenyu
On 2007.06.21 18:10:50 +, Carlo Wood wrote: > > I am glad to see that you found a real reason for why it might have > gone wrong. Just not initializing because it's not needed, but not > understanding WHY it went wrong would have been rather unsatisfactory. > yes, I understand, but it looks

Re: [PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port

2007-06-21 Thread Carlo Wood
On Thu, Jun 21, 2007 at 01:43:18PM +0800, Wang Zhenyu wrote: > Thanks Carlo to report this problem. The following patch should fix > his and potential issue. Thanks for fixing it Wang :) I have to admit that the Real Reason I did put time into this is because I wanted to be sure that when debian u

[PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port

2007-06-20 Thread Wang Zhenyu
Thanks Carlo to report this problem. The following patch should fix his and potential issue. [AGPGART] intel_agp: don't load if no IGD detected and no AGP port After i915 chip, GMCH has no AGP port. Origin bridge driver in device table will try to access illegal regs like APBASE, APSIZE, etc. Th