Re: [PATCH][V2][next] regulator: axp20x: check rdev is null before dereferencing it

2019-02-14 Thread Dan Carpenter
On Tue, Feb 05, 2019 at 11:37:40AM +0800, Chen-Yu Tsai wrote: > On Sat, Dec 22, 2018 at 7:32 PM Colin King wrote: > > > > From: Colin Ian King > > > > Currently rdev is dereferenced when assigning desc before rdev is null > > checked, hence there is a potential null pointer dereference on rdev.

Re: [PATCH][V2][next] regulator: axp20x: check rdev is null before dereferencing it

2019-02-04 Thread Chen-Yu Tsai
On Sat, Dec 22, 2018 at 7:32 PM Colin King wrote: > > From: Colin Ian King > > Currently rdev is dereferenced when assigning desc before rdev is null > checked, hence there is a potential null pointer dereference on rdev. > Fix this by null checking rdev first. > > Detected by CoverityScan,

Re: [PATCH][V2][next] regulator: axp20x: check rdev is null before dereferencing it

2019-02-04 Thread Dan Carpenter
On Mon, Feb 04, 2019 at 07:13:30PM +, Colin Ian King wrote: > > drivers/regulator/axp20x-regulator.c | 8 ++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/regulator/axp20x-regulator.c > > b/drivers/regulator/axp20x-regulator.c > > index

Re: [PATCH][V2][next] regulator: axp20x: check rdev is null before dereferencing it

2019-02-04 Thread Mark Brown
On Mon, Feb 04, 2019 at 07:13:30PM +, Colin Ian King wrote: > ping? Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please

Re: [PATCH][V2][next] regulator: axp20x: check rdev is null before dereferencing it

2019-02-04 Thread Colin Ian King
ping? On 22/12/2018 11:31, Colin King wrote: > From: Colin Ian King > > Currently rdev is dereferenced when assigning desc before rdev is null > checked, hence there is a potential null pointer dereference on rdev. > Fix this by null checking rdev first. > > Detected by CoverityScan,

[PATCH][V2][next] regulator: axp20x: check rdev is null before dereferencing it

2018-12-22 Thread Colin King
From: Colin Ian King Currently rdev is dereferenced when assigning desc before rdev is null checked, hence there is a potential null pointer dereference on rdev. Fix this by null checking rdev first. Detected by CoverityScan, CID#1476031 ("Dereference before null check") Fixes: 77e3e3b165db