Re: [PATCH][V2] cxgb4: fix -ve error check on a signed iq

2016-09-25 Thread David Miller
From: Colin King Date: Sun, 25 Sep 2016 14:14:45 -0700 > From: Colin Ian King > > iq is unsigned, so the error check for iq < 0 has no effect so errors > can slip past this check. Fix this by making iq signed and also > get_filter_steerq

Re: [PATCH][V2] cxgb4: fix -ve error check on a signed iq

2016-09-25 Thread David Miller
From: Colin King Date: Sun, 25 Sep 2016 14:14:45 -0700 > From: Colin Ian King > > iq is unsigned, so the error check for iq < 0 has no effect so errors > can slip past this check. Fix this by making iq signed and also > get_filter_steerq return a signed int so a -ve error can be returned. >

[PATCH][V2] cxgb4: fix -ve error check on a signed iq

2016-09-25 Thread Colin King
From: Colin Ian King iq is unsigned, so the error check for iq < 0 has no effect so errors can slip past this check. Fix this by making iq signed and also get_filter_steerq return a signed int so a -ve error can be returned. Signed-off-by: Colin Ian King

[PATCH][V2] cxgb4: fix -ve error check on a signed iq

2016-09-25 Thread Colin King
From: Colin Ian King iq is unsigned, so the error check for iq < 0 has no effect so errors can slip past this check. Fix this by making iq signed and also get_filter_steerq return a signed int so a -ve error can be returned. Signed-off-by: Colin Ian King ---