Re: [PATCH][V2] drivers/net: appletalk/cops: remove redundant if statement and mask

2018-12-25 Thread Sergei Shtylyov
On 24.12.2018 22:41, Colin King wrote: From: Colin Ian King The two different assignments for pkt_len are actually the same and so the if statement is redundant and can be removed. Masking a u8 return value from inb() with 0xFF is also redundant and can also be emoved. Removed. :-)

Re: [PATCH][V2] drivers/net: appletalk/cops: remove redundant if statement and mask

2018-12-24 Thread David Miller
From: Colin King Date: Mon, 24 Dec 2018 19:41:46 + > From: Colin Ian King > > The two different assignments for pkt_len are actually the same and > so the if statement is redundant and can be removed. Masking a u8 > return value from inb() with 0xFF is also redundant and can also be >

[PATCH][V2] drivers/net: appletalk/cops: remove redundant if statement and mask

2018-12-24 Thread Colin King
From: Colin Ian King The two different assignments for pkt_len are actually the same and so the if statement is redundant and can be removed. Masking a u8 return value from inb() with 0xFF is also redundant and can also be emoved. Similarly, the two different outb calls are identical as the