Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-06-25 Thread Mark Rutland
On Tue, Jun 23, 2020 at 06:44:56PM +0100, Will Deacon wrote: > On Tue, Jun 23, 2020 at 06:19:10PM +0100, Will Deacon wrote: > > So, I think we should take this patch (which puts the PC where you'd expect > > to find it for compat tasks) and then we could consider removing the current > > lr/sp

Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-06-23 Thread Will Deacon
On Tue, Jun 23, 2020 at 06:19:10PM +0100, Will Deacon wrote: > So, I think we should take this patch (which puts the PC where you'd expect > to find it for compat tasks) and then we could consider removing the current > lr/sp fudging as a separate patch, which we could revert if it causes a >

Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-06-23 Thread Will Deacon
On Thu, Jun 18, 2020 at 02:03:32PM +0100, Mark Rutland wrote: > On Thu, May 28, 2020 at 08:54:19AM +0100, Will Deacon wrote: > > On Thu, May 28, 2020 at 09:06:07AM +0800, Jiping Ma wrote: > > > On 05/27/2020 11:19 PM, Mark Rutland wrote: > > > > On Wed, May 27, 2020 at 09:33:00AM +0800, Jiping Ma

Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-06-18 Thread Mark Rutland
On Thu, May 28, 2020 at 08:54:19AM +0100, Will Deacon wrote: > On Thu, May 28, 2020 at 09:06:07AM +0800, Jiping Ma wrote: > > On 05/27/2020 11:19 PM, Mark Rutland wrote: > > > On Wed, May 27, 2020 at 09:33:00AM +0800, Jiping Ma wrote: > > > > On 05/26/2020 06:26 PM, Mark Rutland wrote: > > > > >

Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-05-28 Thread Jiping Ma
On 05/28/2020 03:54 PM, Will Deacon wrote: On Thu, May 28, 2020 at 09:06:07AM +0800, Jiping Ma wrote: On 05/27/2020 11:19 PM, Mark Rutland wrote: On Wed, May 27, 2020 at 09:33:00AM +0800, Jiping Ma wrote: On 05/26/2020 06:26 PM, Mark Rutland wrote: On Mon, May 11, 2020 at 10:52:07AM

Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-05-28 Thread Will Deacon
On Thu, May 28, 2020 at 09:06:07AM +0800, Jiping Ma wrote: > On 05/27/2020 11:19 PM, Mark Rutland wrote: > > On Wed, May 27, 2020 at 09:33:00AM +0800, Jiping Ma wrote: > > > On 05/26/2020 06:26 PM, Mark Rutland wrote: > > > > On Mon, May 11, 2020 at 10:52:07AM +0800, Jiping Ma wrote: > > > This

Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-05-27 Thread Jiping Ma
On 05/27/2020 11:19 PM, Mark Rutland wrote: On Wed, May 27, 2020 at 09:33:00AM +0800, Jiping Ma wrote: On 05/26/2020 06:26 PM, Mark Rutland wrote: On Mon, May 11, 2020 at 10:52:07AM +0800, Jiping Ma wrote: Modified the patch subject and the change description. PC value is get from

Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-05-27 Thread Mark Rutland
On Wed, May 27, 2020 at 09:33:00AM +0800, Jiping Ma wrote: > > > On 05/26/2020 06:26 PM, Mark Rutland wrote: > > On Mon, May 11, 2020 at 10:52:07AM +0800, Jiping Ma wrote: > > > Modified the patch subject and the change description. > > > > > > PC value is get from regs[15] in REGS_ABI_32 mode,

Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-05-27 Thread Mark Rutland
On Tue, May 26, 2020 at 08:54:19PM +0100, Will Deacon wrote: > On Tue, May 26, 2020 at 11:26:11AM +0100, Mark Rutland wrote: > > On Mon, May 11, 2020 at 10:52:07AM +0800, Jiping Ma wrote: > > > Modified the patch subject and the change description. > > > > > > PC value is get from regs[15] in

Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-05-26 Thread Jiping Ma
On 05/26/2020 06:26 PM, Mark Rutland wrote: On Mon, May 11, 2020 at 10:52:07AM +0800, Jiping Ma wrote: Modified the patch subject and the change description. PC value is get from regs[15] in REGS_ABI_32 mode, but correct PC is regs->pc(regs[PERF_REG_ARM64_PC]) in arm64 kernel, which caused

Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-05-26 Thread Jiping Ma
On 05/27/2020 03:54 AM, Will Deacon wrote: On Tue, May 26, 2020 at 11:26:11AM +0100, Mark Rutland wrote: On Mon, May 11, 2020 at 10:52:07AM +0800, Jiping Ma wrote: Modified the patch subject and the change description. PC value is get from regs[15] in REGS_ABI_32 mode, but correct PC is

Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-05-26 Thread Will Deacon
On Tue, May 26, 2020 at 11:26:11AM +0100, Mark Rutland wrote: > On Mon, May 11, 2020 at 10:52:07AM +0800, Jiping Ma wrote: > > Modified the patch subject and the change description. > > > > PC value is get from regs[15] in REGS_ABI_32 mode, but correct PC > > is regs->pc(regs[PERF_REG_ARM64_PC])

Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-05-26 Thread Mark Rutland
On Mon, May 11, 2020 at 10:52:07AM +0800, Jiping Ma wrote: > Modified the patch subject and the change description. > > PC value is get from regs[15] in REGS_ABI_32 mode, but correct PC > is regs->pc(regs[PERF_REG_ARM64_PC]) in arm64 kernel, which caused > that perf can not parser the backtrace

Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-05-25 Thread Jiping Ma
Hi, Will Please help to review the change. Thanks, Jiping On 05/11/2020 10:52 AM, Jiping Ma wrote: Modified the patch subject and the change description. PC value is get from regs[15] in REGS_ABI_32 mode, but correct PC is regs->pc(regs[PERF_REG_ARM64_PC]) in arm64 kernel, which caused that

[PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-05-10 Thread Jiping Ma
Modified the patch subject and the change description. PC value is get from regs[15] in REGS_ABI_32 mode, but correct PC is regs->pc(regs[PERF_REG_ARM64_PC]) in arm64 kernel, which caused that perf can not parser the backtrace of app with dwarf mode in the 32bit system and 64bit kernel.